Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In starknet-wrapper, call prepare methods from final parent methods, not from implemented #152

Closed
ivpavici opened this issue Jul 8, 2022 · 1 comment
Closed

In starknet-wrapper, call prepare methods from final parent methods, not from implemented #152

ivpavici opened this issue Jul 8, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@ivpavici
Copy link
Contributor

ivpavici commented Jul 8, 2022

e.g. when implementing a wrapper, deploy must be implemented. It has to call prepareDeployOptions . This should be done implicitly in a parent method, not force the developer of every child method to explicitly call it (as we currently do).
@ivpavici ivpavici added the enhancement New feature or request label Jul 8, 2022
@ivpavici
Copy link
Contributor Author

Probably obsolete because of #396
I cannot even find prepareDeployOptions anymore

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in starknet-hardhat-plugin Aug 24, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in starknet-hardhat-plugin Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
starknet-hardhat-plugin
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ivpavici