Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContractAddress, ClassHash and EthAddress decoding #385

Open
notV4l opened this issue Jun 20, 2023 · 1 comment
Open

ContractAddress, ClassHash and EthAddress decoding #385

notV4l opened this issue Jun 20, 2023 · 1 comment
Labels
breaking A breaking change enhancement New feature or request

Comments

@notV4l
Copy link
Contributor

notV4l commented Jun 20, 2023

Actually this types are handle as common numeric types :

const COMMON_NUMERIC_TYPES = [
"felt",
"core::felt252",
"core::integer::u8",
"core::integer::u16",
"core::integer::u32",
"core::integer::u64",
"core::integer::u128",
"core::starknet::contract_address::ContractAddress",
"core::starknet::class_hash::ClassHash",
"core::starknet::eth_address::EthAddress"
];

It could be converted to hex representation
ie :
3407481119780572850671182801001023516830125398818876583940565901076194792664 would decode to 0x78890e347461d95a8eacddaeb35b577f4ef29a6fbf825326d8d97022e2a14d8

@FabijanC
Copy link
Collaborator

Would make sense for ContractAddress, ClassHash and EthAddress. But this would be a breaking change.

@FabijanC FabijanC added enhancement New feature or request breaking A breaking change labels Jun 20, 2023
@FabijanC FabijanC moved this from 🆕 New to 📋 Backlog in starknet-hardhat-plugin Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants