Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code blocks don't wrap #3823

Closed
2 tasks
beechnut opened this issue Apr 12, 2024 · 5 comments
Closed
2 tasks

Code blocks don't wrap #3823

beechnut opened this issue Apr 12, 2024 · 5 comments
Assignees
Labels

Comments

@beechnut
Copy link
Contributor

Expected Behavior

When I encounter a code block in the blog, it should wrap like a text editor would, or scroll horizontally so you can see all the code.

Actual Behavior

When I encounter a code block in the blog, if it's long enough, it runs off-screen. However, the horizontal scroll settings prevent me from scrolling to see the full block.

Inserting line breaks isn't necessarily the right solution — in this case, I would expect the database client to error if line breaks were inserted here. We want people to be able to copy and paste the code.

Screenshot 2024-04-12 at 11 08 47 AM

Steps to reproduce the behavior

  • Include a long code block in a blog post, may we suggest:
grant CREATE SESSION, ALTER SESSION, CREATE DATABASE LINK, CREATE MATERIALIZED VIEW, CREATE PROCEDURE, CREATE PUBLIC SYNONYM, CREATE ROLE, CREATE SEQUENCE, CREATE SYNONYM, CREATE TABLE, CREATE TRIGGER, CREATE TYPE, CREATE VIEW, UNLIMITED TABLESPACE to { username 2 };

This issue is done when

  • Code blocks wrap or scroll internally (like the code block in this very issue! ☝🏼)
@peterrowland peterrowland self-assigned this May 28, 2024
@peterrowland
Copy link
Member

Tested adding overflow-x: auto to the code css, and it has the desired effect.

@peterrowland
Copy link
Member

PR for changes.

@bpdesigns
Copy link
Member

@cantsin can you look at this today before @peterrowland is out of the office?

@cantsin
Copy link
Member

cantsin commented Jun 7, 2024

LGTM but I am unsure how this ongoing work on 18f.gsa.gov impacts migration. @beechnut can you chime in here? OK to merge?

@beechnut
Copy link
Contributor Author

beechnut commented Jun 7, 2024

@cantsin @peterrowland Ok to merge! Shouldn't affect anything in-progress.

@cantsin cantsin closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants