From c8aa2643695953e270ee1b50646021e64923e0b5 Mon Sep 17 00:00:00 2001 From: Jenny Verdeyen Date: Fri, 10 Jan 2025 11:25:08 -0500 Subject: [PATCH 1/6] LG-15379 removes post office closure alerts from barcode page and email changelog: User-Facing Improvements, In-person proofing, removes post office closure alerts from barcode page and email --- .../in_person/ready_to_verify_controller.rb | 2 - .../in_person/ready_to_verify/show.html.erb | 8 ---- .../_in_person_ready_to_verify.html.erb | 15 ------- config/application.yml.default | 2 +- config/locales/en.yml | 5 --- config/locales/es.yml | 5 --- config/locales/fr.yml | 5 --- config/locales/zh.yml | 5 --- spec/mailers/user_mailer_spec.rb | 44 ------------------- .../ready_to_verify/show.html.erb_spec.rb | 44 ------------------- 10 files changed, 1 insertion(+), 134 deletions(-) diff --git a/app/controllers/idv/in_person/ready_to_verify_controller.rb b/app/controllers/idv/in_person/ready_to_verify_controller.rb index 79e7172745d..fbd0aeeee2c 100644 --- a/app/controllers/idv/in_person/ready_to_verify_controller.rb +++ b/app/controllers/idv/in_person/ready_to_verify_controller.rb @@ -18,8 +18,6 @@ class ReadyToVerifyController < ApplicationController def show @is_enhanced_ipp = resolved_authn_context_result.enhanced_ipp? - @show_closed_post_office_banner = - IdentityConfig.store.in_person_proofing_post_office_closed_alert_enabled analytics.idv_in_person_ready_to_verify_visit(**opt_in_analytics_properties) @presenter = ReadyToVerifyPresenter.new( enrollment: enrollment, diff --git a/app/views/idv/in_person/ready_to_verify/show.html.erb b/app/views/idv/in_person/ready_to_verify/show.html.erb index 109f9cdd468..6cc213c8a91 100644 --- a/app/views/idv/in_person/ready_to_verify/show.html.erb +++ b/app/views/idv/in_person/ready_to_verify/show.html.erb @@ -228,14 +228,6 @@ <% end %> -<%# Alert %> -<% if @show_closed_post_office_banner %> - <%= render AlertComponent.new(type: :warning, class: 'margin-y-4', text_tag: :div) do %> -

<%= t('in_person_proofing.post_office_closed.heading') %>

-

<%= t('in_person_proofing.post_office_closed.body') %>

- <% end %> -<% end %> - <% if !@is_enhanced_ipp %>

<%= t('in_person_proofing.body.location.change_location_heading') %>

diff --git a/app/views/user_mailer/shared/_in_person_ready_to_verify.html.erb b/app/views/user_mailer/shared/_in_person_ready_to_verify.html.erb index 3db2200a903..9fcddaa4dbd 100644 --- a/app/views/user_mailer/shared/_in_person_ready_to_verify.html.erb +++ b/app/views/user_mailer/shared/_in_person_ready_to_verify.html.erb @@ -275,21 +275,6 @@ <% end %> -<%# alert %> -<% if @show_closed_post_office_banner %> - - - - - -
- <%= image_tag('email/warning.png', width: 16, height: 16, alt: '', style: 'margin-top: 4px;') %> - -

<%= t('in_person_proofing.post_office_closed.heading') %>

-

<%= t('in_person_proofing.post_office_closed.body') %>

-
-<% end %> - <% if !@is_enhanced_ipp %>

<%= t('in_person_proofing.body.location.change_location_heading') %>

diff --git a/config/application.yml.default b/config/application.yml.default index eda29fb51a7..2cd125ee303 100644 --- a/config/application.yml.default +++ b/config/application.yml.default @@ -194,7 +194,7 @@ in_person_outage_message_enabled: false in_person_proofing_enabled: false in_person_proofing_enforce_tmx: false in_person_proofing_opt_in_enabled: false -in_person_proofing_post_office_closed_alert_enabled: true +in_person_proofing_post_office_closed_alert_enabled: false in_person_results_delay_in_hours: 1 in_person_send_proofing_notifications_enabled: false in_person_stop_expiring_enrollments: false diff --git a/config/locales/en.yml b/config/locales/en.yml index 607a9978a57..e7743b7728d 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -1327,11 +1327,6 @@ in_person_proofing.headings.state_id_milestone_2: Enter the information on your in_person_proofing.headings.switch_back: Switch back to your computer to prepare to verify your identity in person in_person_proofing.headings.update_address: Update your current address in_person_proofing.headings.update_state_id: Update the information on your ID -in_person_proofing.post_office_closed.body: Post Office locations will resume regular hours on Friday, January 10, 2025. -in_person_proofing.post_office_closed.email.body_html: You will not be able to visit a Post Office on Thursday, January 9, 2025 to finish verifying your identity. Post Office locations will resume regular hours on Friday, January 10, 2025. -in_person_proofing.post_office_closed.email.heading: All Post Offices will be closed on January 9, 2025 to honor former President Jimmy Carter -in_person_proofing.post_office_closed.email.subject: All Post Offices will be closed on Thursday, January 9, 2025 -in_person_proofing.post_office_closed.heading: All Post Offices will be closed on Thursday, January 9, 2025 to honor former President Jimmy Carter. in_person_proofing.process.barcode.caption_label: Enrollment code in_person_proofing.process.barcode.heading: Show your %{app_name} barcode in_person_proofing.process.barcode.info: The retail associate needs to scan your barcode at the top of this page. You can print this page or show it on your mobile device. diff --git a/config/locales/es.yml b/config/locales/es.yml index a8ba9e3d01a..ffc5ae31eaa 100644 --- a/config/locales/es.yml +++ b/config/locales/es.yml @@ -1338,11 +1338,6 @@ in_person_proofing.headings.state_id_milestone_2: Ingrese la información de su in_person_proofing.headings.switch_back: Vuelva a su computadora para preparar la verificación de su identidad en persona in_person_proofing.headings.update_address: Actualice su dirección actual in_person_proofing.headings.update_state_id: Actualice la información de su identificación -in_person_proofing.post_office_closed.body: Las oficinas de correos reanudarán su horario habitual el viernes 10 de enero de 2025. -in_person_proofing.post_office_closed.email.body_html: No podrás visitar una Oficina de Correos el jueves 9 de enero de 2025 para terminar de verificar tu identidad. Las oficinas de correos reanudarán su horario habitual el viernes 10 de enero de 2025. -in_person_proofing.post_office_closed.email.heading: Todas las oficinas de correos estarán cerradas el 9 de enero de 2025 en honor al expresidente Jimmy Carter -in_person_proofing.post_office_closed.email.subject: Todas las oficinas de correos estarán cerradas el jueves 9 de enero de 2025 -in_person_proofing.post_office_closed.heading: Todas las oficinas de correos estarán cerradas el jueves 9 de enero de 2025 en honor al ex presidente Jimmy Carter. in_person_proofing.process.barcode.caption_label: Código de registro in_person_proofing.process.barcode.heading: Muestre su código de barras de %{app_name} in_person_proofing.process.barcode.info: El empleado debe escanear el código de barras que aparece en la parte superior de esta página. Puede imprimir esta página o mostrarla en su dispositivo móvil. diff --git a/config/locales/fr.yml b/config/locales/fr.yml index 0f1739b0090..2370d08b078 100644 --- a/config/locales/fr.yml +++ b/config/locales/fr.yml @@ -1327,11 +1327,6 @@ in_person_proofing.headings.state_id_milestone_2: Saisissez les informations fig in_person_proofing.headings.switch_back: Revenez à votre ordinateur pour vous préparer à confirmer votre identité en personne in_person_proofing.headings.update_address: Mettez à jour votre adresse actuelle in_person_proofing.headings.update_state_id: Mettez à jour les informations figurant sur votre document d’identité -in_person_proofing.post_office_closed.body: Les bureaux de poste reprendront leurs horaires habituels le vendredi 10 janvier 2025. -in_person_proofing.post_office_closed.email.body_html: Vous ne pourrez pas vous rendre dans un bureau de Poste le jeudi 9 janvier 2025 pour terminer la vérification de votre identité. Les bureaux de poste reprendront leurs horaires habituels le vendredi 10 janvier 2025 -in_person_proofing.post_office_closed.email.heading: Tous les bureaux de poste seront fermés le 9 janvier 2025 en l’honneur de l’ancien président Jimmy Carter -in_person_proofing.post_office_closed.email.subject: Tous les bureaux de poste seront fermés le jeudi 9 janvier 2025 -in_person_proofing.post_office_closed.heading: Tous les bureaux de poste seront fermés le jeudi 9 janvier 2025 en l’honneur de l’ancien président Jimmy Carter. in_person_proofing.process.barcode.caption_label: Code d’inscription in_person_proofing.process.barcode.heading: Montrez votre code-barres %{app_name} in_person_proofing.process.barcode.info: Le préposé doit scanner votre code-barres en haut de cette page. Vous pouvez imprimer cette page ou la montrer sur votre appareil mobile. diff --git a/config/locales/zh.yml b/config/locales/zh.yml index 65db2d4ab7d..bc581aecbb8 100644 --- a/config/locales/zh.yml +++ b/config/locales/zh.yml @@ -1340,11 +1340,6 @@ in_person_proofing.headings.state_id_milestone_2: 输入你州政府颁发身份 in_person_proofing.headings.switch_back: 切换回你的电脑，来准备亲身去验证身份。 in_person_proofing.headings.update_address: 更新你当前地址 in_person_proofing.headings.update_state_id: 更新你身份证件上的信息 -in_person_proofing.post_office_closed.body: 邮局地点将于 2025 年 1 月 10 日星期五恢复正常工作时间。 -in_person_proofing.post_office_closed.email.body_html: 您将无法在 2025 年 1 月 9 日星期四前往邮局完成身份验证。 邮局地点将于 2025 年 1 月 10 日星期五恢复正常工作时间 -in_person_proofing.post_office_closed.email.heading: 所有邮局将于 2025 年 1 月 9 日关闭，以纪念前总统吉米·卡特 -in_person_proofing.post_office_closed.email.subject: 所有邮局将于 2025 年 1 月 9 日星期四关闭 -in_person_proofing.post_office_closed.heading: 所有邮局将于 2025 年 1 月 9 日关闭，以纪念前总统吉米·卡特。 in_person_proofing.process.barcode.caption_label: 注册代码 in_person_proofing.process.barcode.heading: 出示你的 %{app_name} 条形码 in_person_proofing.process.barcode.info: 邮局工作人员需要扫描该页顶部的条形码你可以把该页打印出来，或在你的移动设备上显示。 diff --git a/spec/mailers/user_mailer_spec.rb b/spec/mailers/user_mailer_spec.rb index 6c182992a74..c8704a03815 100644 --- a/spec/mailers/user_mailer_spec.rb +++ b/spec/mailers/user_mailer_spec.rb @@ -934,50 +934,6 @@ def expect_email_body_to_have_help_and_contact_links end end - context 'post office closed alert' do - context 'when the post office closed alert flag is disabled' do - before do - allow(IdentityConfig.store) - .to receive(:in_person_proofing_post_office_closed_alert_enabled) - .and_return(false) - end - - it 'does not render the post office closed alert' do - aggregate_failures do - [ - t('in_person_proofing.post_office_closed.heading'), - t('in_person_proofing.post_office_closed.body'), - ].each do |copy| - Array(copy).each do |part| - expect(mail.html_part.body).to_not have_content(part) - end - end - end - end - end - - context 'when the post office closed alert flag is enabled' do - before do - allow(IdentityConfig.store) - .to receive(:in_person_proofing_post_office_closed_alert_enabled) - .and_return(true) - end - - it 'renders the post office closed alert' do - aggregate_failures do - [ - t('in_person_proofing.post_office_closed.heading'), - t('in_person_proofing.post_office_closed.body'), - ].each do |copy| - Array(copy).each do |part| - expect(mail.html_part.body).to have_content(part) - end - end - end - end - end - end - context 'Need to change location section' do context 'when Enhanced IPP is not enabled' do let(:is_enhanced_ipp) { false } diff --git a/spec/views/idv/in_person/ready_to_verify/show.html.erb_spec.rb b/spec/views/idv/in_person/ready_to_verify/show.html.erb_spec.rb index f5874ffb8a2..04bccd8e056 100644 --- a/spec/views/idv/in_person/ready_to_verify/show.html.erb_spec.rb +++ b/spec/views/idv/in_person/ready_to_verify/show.html.erb_spec.rb @@ -176,50 +176,6 @@ end end - context 'post office warning' do - context 'when the show closed post office banner is disabled' do - before do - @show_closed_post_office_banner = false - end - - it 'does not render the post office closed alert' do - render - - aggregate_failures do - [ - t('in_person_proofing.post_office_closed.heading'), - t('in_person_proofing.post_office_closed.body'), - ].each do |copy| - Array(copy).each do |part| - expect(rendered).to_not have_content(part) - end - end - end - end - end - - context 'when the show closed post office banner is enabled' do - before do - @show_closed_post_office_banner = true - end - - it 'renders the post office closed alert' do - render - - aggregate_failures do - [ - t('in_person_proofing.post_office_closed.heading'), - t('in_person_proofing.post_office_closed.body'), - ].each do |copy| - Array(copy).each do |part| - expect(rendered).to have_content(part) - end - end - end - end - end - end - context 'what to expect section' do context 'when Enhanced IPP is not enabled' do let(:is_enhanced_ipp) { false } From a1aefde622bea3fe55ec5127921c6716b7b71ea2 Mon Sep 17 00:00:00 2001 From: Jenny Verdeyen Date: Fri, 10 Jan 2025 13:15:52 -0500 Subject: [PATCH 2/6] remove feature flag after all --- config/application.yml.default | 1 - 1 file changed, 1 deletion(-) diff --git a/config/application.yml.default b/config/application.yml.default index 2cd125ee303..32b091452c5 100644 --- a/config/application.yml.default +++ b/config/application.yml.default @@ -194,7 +194,6 @@ in_person_outage_message_enabled: false in_person_proofing_enabled: false in_person_proofing_enforce_tmx: false in_person_proofing_opt_in_enabled: false -in_person_proofing_post_office_closed_alert_enabled: false in_person_results_delay_in_hours: 1 in_person_send_proofing_notifications_enabled: false in_person_stop_expiring_enrollments: false From c476366e4de4656149b3ac38b590942f329e45fa Mon Sep 17 00:00:00 2001 From: Jenny Verdeyen Date: Mon, 13 Jan 2025 11:49:05 -0500 Subject: [PATCH 3/6] remove other occurences of the config variable --- app/mailers/user_mailer.rb | 4 ---- config/application.yml.default | 1 - lib/identity_config.rb | 1 - .../in_person/ready_to_verify_controller_spec.rb | 13 ------------- 4 files changed, 19 deletions(-) diff --git a/app/mailers/user_mailer.rb b/app/mailers/user_mailer.rb index caed7d1e823..70817860a68 100644 --- a/app/mailers/user_mailer.rb +++ b/app/mailers/user_mailer.rb @@ -312,8 +312,6 @@ def in_person_ready_to_verify(enrollment:, is_enhanced_ipp:) is_enhanced_ipp: is_enhanced_ipp, ) @is_enhanced_ipp = is_enhanced_ipp - @show_closed_post_office_banner = - IdentityConfig.store.in_person_proofing_post_office_closed_alert_enabled mail( to: email_address.email, @@ -328,8 +326,6 @@ def in_person_ready_to_verify_reminder(enrollment:) ).image_data @is_enhanced_ipp = enrollment.enhanced_ipp? - @show_closed_post_office_banner = - IdentityConfig.store.in_person_proofing_post_office_closed_alert_enabled with_user_locale(user) do @presenter = Idv::InPerson::ReadyToVerifyPresenter.new( diff --git a/config/application.yml.default b/config/application.yml.default index 32b091452c5..7b7ba471545 100644 --- a/config/application.yml.default +++ b/config/application.yml.default @@ -561,7 +561,6 @@ test: hmac_fingerprinter_key: a2c813d4dca919340866ba58063e4072adc459b767a74cf2666d5c1eef3861db26708e7437abde1755eb24f4034386b0fea1850a1cb7e56bff8fae3cc6ade96c hmac_fingerprinter_key_queue: '["old-key-one", "old-key-two"]' identity_pki_disabled: true - in_person_proofing_post_office_closed_alert_enabled: false lexisnexis_trueid_account_id: 'test_account' lockout_period_in_minutes: 5 logins_per_email_and_ip_limit: 2 diff --git a/lib/identity_config.rb b/lib/identity_config.rb index dda63760833..9cb0d1499c0 100644 --- a/lib/identity_config.rb +++ b/lib/identity_config.rb @@ -218,7 +218,6 @@ def self.store config.add(:in_person_proofing_enabled, type: :boolean) config.add(:in_person_proofing_enforce_tmx, type: :boolean) config.add(:in_person_proofing_opt_in_enabled, type: :boolean) - config.add(:in_person_proofing_post_office_closed_alert_enabled, type: :boolean) config.add(:in_person_results_delay_in_hours, type: :integer) config.add(:in_person_send_proofing_notifications_enabled, type: :boolean) config.add(:in_person_stop_expiring_enrollments, type: :boolean) diff --git a/spec/controllers/idv/in_person/ready_to_verify_controller_spec.rb b/spec/controllers/idv/in_person/ready_to_verify_controller_spec.rb index 86e3f4664c5..f9cf72a229d 100644 --- a/spec/controllers/idv/in_person/ready_to_verify_controller_spec.rb +++ b/spec/controllers/idv/in_person/ready_to_verify_controller_spec.rb @@ -128,19 +128,6 @@ expect(assigns(:is_enhanced_ipp)).to be true end end - - context 'with in_person_proofing_post_office_closed_alert_enabled' do - let(:ipp_post_office_closed_alert_enabled) { true } - before do - allow(IdentityConfig.store) - .to receive(:in_person_proofing_post_office_closed_alert_enabled) - .and_return(ipp_post_office_closed_alert_enabled) - end - - it 'renders the show template' do - expect(response).to render_template :show - end - end end end From ac7c5850f99e8a1c223c4304861f53a55740c100 Mon Sep 17 00:00:00 2001 From: Jenny Verdeyen Date: Mon, 13 Jan 2025 14:05:35 -0500 Subject: [PATCH 4/6] a few more --- app/mailers/user_mailer.rb | 10 ---------- .../ready_to_verify_controller_spec.rb | 1 - spec/mailers/previews/user_mailer_preview.rb | 4 ---- spec/mailers/user_mailer_spec.rb | 18 ------------------ 4 files changed, 33 deletions(-) diff --git a/app/mailers/user_mailer.rb b/app/mailers/user_mailer.rb index 70817860a68..611e4c48d07 100644 --- a/app/mailers/user_mailer.rb +++ b/app/mailers/user_mailer.rb @@ -435,16 +435,6 @@ def account_reinstated end end - def in_person_post_office_closed - with_user_locale(user) do - @hide_title = true - mail( - to: email_address.email, - subject: t('in_person_proofing.post_office_closed.email.subject'), - ) - end - end - private attr_reader :user, :email_address diff --git a/spec/controllers/idv/in_person/ready_to_verify_controller_spec.rb b/spec/controllers/idv/in_person/ready_to_verify_controller_spec.rb index f9cf72a229d..cc14296fd92 100644 --- a/spec/controllers/idv/in_person/ready_to_verify_controller_spec.rb +++ b/spec/controllers/idv/in_person/ready_to_verify_controller_spec.rb @@ -32,7 +32,6 @@ context 'with in person proofing enabled' do let(:in_person_proofing_enabled) { true } - let(:ipp_post_office_closed_alert_enabled) { false } context 'authenticated' do before do diff --git a/spec/mailers/previews/user_mailer_preview.rb b/spec/mailers/previews/user_mailer_preview.rb index 9f36238d62f..66edf8f05ee 100644 --- a/spec/mailers/previews/user_mailer_preview.rb +++ b/spec/mailers/previews/user_mailer_preview.rb @@ -286,10 +286,6 @@ def account_reinstated ).account_reinstated end - def in_person_post_office_closed - UserMailer.with(user: user, email_address: email_address_record).in_person_post_office_closed - end - private def user diff --git a/spec/mailers/user_mailer_spec.rb b/spec/mailers/user_mailer_spec.rb index c8704a03815..9a401748e96 100644 --- a/spec/mailers/user_mailer_spec.rb +++ b/spec/mailers/user_mailer_spec.rb @@ -1580,22 +1580,4 @@ def expect_email_body_to_have_help_and_contact_links it_behaves_like 'an email that respects user email locale preference' end - describe '#in_person_post_office_closed' do - let(:mail) do - UserMailer.with(user: user, email_address: email_address).in_person_post_office_closed - end - - it_behaves_like 'a system email' - it_behaves_like 'an email that respects user email locale preference' - - it 'includes a translated header' do - expect(mail.html_part.body) - .to include(t('in_person_proofing.post_office_closed.email.heading', locale: :en)) - end - - it 'includes a translated body' do - expect(mail.html_part.body) - .to include(t('in_person_proofing.post_office_closed.email.body_html', locale: :en)) - end - end end From 1db1e3081d716c48671d535468c708a6220af82d Mon Sep 17 00:00:00 2001 From: Jenny Verdeyen Date: Mon, 13 Jan 2025 14:37:54 -0500 Subject: [PATCH 5/6] remove a file --- app/views/user_mailer/in_person_post_office_closed.html.erb | 2 -- 1 file changed, 2 deletions(-) delete mode 100644 app/views/user_mailer/in_person_post_office_closed.html.erb diff --git a/app/views/user_mailer/in_person_post_office_closed.html.erb b/app/views/user_mailer/in_person_post_office_closed.html.erb deleted file mode 100644 index 14abf7ed812..00000000000 --- a/app/views/user_mailer/in_person_post_office_closed.html.erb +++ /dev/null @@ -1,2 +0,0 @@ -

<%= t('in_person_proofing.post_office_closed.email.heading') %>

-

<%= t('in_person_proofing.post_office_closed.email.body_html') %>

From a8edc4d446889ccc6ecd32404242e109b8a38003 Mon Sep 17 00:00:00 2001 From: Jenny Verdeyen Date: Mon, 13 Jan 2025 14:55:43 -0500 Subject: [PATCH 6/6] lint --- spec/mailers/user_mailer_spec.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/spec/mailers/user_mailer_spec.rb b/spec/mailers/user_mailer_spec.rb index 9a401748e96..93e5c9d94c4 100644 --- a/spec/mailers/user_mailer_spec.rb +++ b/spec/mailers/user_mailer_spec.rb @@ -1579,5 +1579,4 @@ def expect_email_body_to_have_help_and_contact_links it_behaves_like 'a system email' it_behaves_like 'an email that respects user email locale preference' end - end