Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support basic-auth credentials #28

Open
FreshlyBrewedCode opened this issue Dec 6, 2021 · 1 comment
Open

Support basic-auth credentials #28

FreshlyBrewedCode opened this issue Dec 6, 2021 · 1 comment
Assignees
@jespersmith

Comments

@FreshlyBrewedCode
Copy link

I noticed that this package does not support the basic-auth tokens i.e.

[npmAuth."<REGISTRY URL>"]
_auth = "<BASE64 TOKEN>"

in fact, using the _auth field instead of token in the .upmconfig.toml will break the credential UI.

A solution could be to refactor the CredentialManager and support two types of NPMCredential objects using polymorphism. Some of the logic from the Write() method could be moved to an abstract method in NPMCredential to support the different credential types.

Or another option would be to simply add the _auth field to the current implementation of NPMCredential and handle it accordingly.
@FreshlyBrewedCode FreshlyBrewedCode mentioned this issue Dec 6, 2021
Closed
@jespersmith jespersmith self-assigned this Dec 13, 2021
@jespersmith
Copy link
Contributor

jespersmith commented Mar 22, 2022 •
edited
Loading

Sorry, I missed this completely. I'll look at the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jespersmith jespersmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jespersmith @FreshlyBrewedCode