Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling the rule @@||example.org^$important,document doesn't properly update the Browser Assistant icon #105

Open
contribucious opened this issue Mar 27, 2023 · 3 comments
Assignees

Comments

@contribucious
Copy link

👋 Hello,

Please find below two different but related problems.
Ensure a clean state between the two.

Note: Issue opened in CoreLibs instead of Browser Assistant,
based on my previous ones here and there (which had been moved to CoreLibs).

Thanks in advance! ✌️
 


💻 Environment

AdGuard Browser Assistant: Beta 1.3.32 (on Firefox 111.0.1)
AdGuard: 7.13 nightly 5 (build 4224, CL 1.11.69)
Windows: 10 Pro 22H2 (OS Build 19045.2728)

@contribucious
Copy link
Author

contribucious commented Mar 27, 2023

🔍 Problem 1 — STR

  1. Add this user rule into Filter Editor:
    @@||example.org^$important,document
  2. Go to https://example.org/  ›››  BA icon is gray. ✔️
  3. Remove (or disable) this rule from the filter editor.
  4. Wait a bit and observe that the BA icon remains gray, instead of switching to green. ✖️
    Even after a click on the icon, which shows the popup with the correct reality (i.e. the updated state).
⚙️ Workaround

Click on another tab you have (or create one with + in your browser) and go back to your tab. Icon is now correctly green.

@contribucious
Copy link
Author

🔍 Problem 2 — STR

  1. Add this user rule into Filter Editor:
    @@||example.org^$important,document
  2. Go to https://example.org/  ›››  BA icon is gray. ✔️
  3. Disable this rule from the filter editor.
    • Wait a bit and observe that the BA icon remains gray, instead of switching to green. ✖️
  4. But now, re-enable this allowlisting rule from the filter editor.
    • Observe that the BA icon instantly turns green (expected behavior: gray). ✖️
  5. And now, wait a bit and re-disable it again.
    • Observe that the BA icon instantly turns gray (expected behavior: green). ✖️
↪️ And in fact, from now on, at each enabling/disabling, the change observed will always be the opposite of the one expected.

 
Remarks:

  • Workaround detailed above (to refresh the icon) also works for this problem.
  • Here also, only the icon is problematic (the content of the popup is always correct).

@adguard-bot adguard-bot assigned vozersky and unassigned zzebrum May 5, 2023
@ameshkov ameshkov transferred this issue from AdguardTeam/CoreLibs May 16, 2023
@ameshkov
Copy link
Member

Surprisingly enough, this one should be opened in the assistant repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants