-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 30 sec. countdown on the Browser Assistant icon (during Do not filter for 30 seconds
)
#80
Comments
🔍 Possible visual resultMainView it …
AlternativeView it …
🆙 Another alternative (variant, less visible in small size as a badge however)View it …
🆕 Another one (2 big characters only)View it …
|
@contribucious Great idea, will consider implementing it. |
We can't style the badge as you proposed in the second comment. |
You're right. Badge is very limited in fact — unlike Icon — regarding animation. Badge ( ⚙️ Although possible using canvas (note: despite the generic "badge" word in the blog post title, technically it's the icon that is animated there) (source), this in order "to create more dynamic UIs", it's more typically used for a "loading" (i.e. perpetual spinning) icon visibly.↪️ Need to see if possible regarding a possible "slow" countdown one, more adapted. Even possibly a very basic one like a "I" with 3 vertical bricks (like a "AA battery"): from 30 to 20 (3/3 shown), from 20 to 10 (2/3 shown), from 10 to 0 (1/3 shown).But unfortunately, if I understand correctly, during the 30 seconds, the gray shield will have to be replaced by this animation (which uses canvas). We cannot have both at the same time, except … to create a very complex canvas. |
I prefer it to be an easy solution |
Of course. I just mentioned this as a bonus, as the only possibility AFAIK to do this (i.e. to have both animation + keeping the gray shield icon), but not as a real de facto solution. 😉 |
Keep in mind that there are plans to add blocked element statistics to the icon. |
I think the simplest and most adequate solution here will be just to update the badge itself (30s … 29s … 28s …) using And possibly to use
|
@gork7777 Very nice one! 👍 Although the icon should be gray during these 30 seconds (as it is now), since the protection is switched off during this time (action is @maximtop To avoid having to use canvas, especially because not required here (i.e. no "perpetual loading" icon with complex animation), could we imagine having simply 30x the static image of @gork7777 for each second of the countdown (i.e. (And possibly, as a bonus to this already explicit visual, displaying the number of seconds like |
Update Because unfortunately, here is what the Manifest V3 documentation says:
And, just for info/context (source):
|
Hi, 👋
It might be a good idea IMHO to display the 30 second countdown on the extension icon, when using the
Don't filter for 30 seconds
option.Useful, as we don't know where we are in time when we close the Browser Assistant popup and use the website.☺️
🔹 Possible subtlety: trigger its display only when the popup is closed. This, in order to prevent a double display of the countdown while the popup is still open — i.e. on the extension icon + in the popup. And … leave it or not on the extension icon if/when the popup is reopened (up to you).
Visual rendering
↪️ Like this but with a gray shield and displaying
19s
instead — if there are19s
left in the countdown for example. ⏳ℹ️ Versus blocking counter visually? In addition to the presence of the character "s", and the decrease every second clearly recognizable, all this in addition on a gray shield in this situation and as a result of the user's immediate own action, to be possibly even more visually distinct from a possible/probable future blocking counter — already present in
AdGuard Browser extension
—, just change the background color + text color + possibly round the corners or display it within a circle or an oval instead. And/Or … either display at his side an animated-or-not hourglass (:hourglass_flowing_sand:) or a vertical bar (such as a capital i) that decreases from top to bottom, or instead, if displayed within a circle, simply animate the "unfilling" of the border of the circle itself to show that a countdown is in progress.💡 Future-proof: Once the
30s
delay is over, the shield will turn green again (once this issue is fixed though) and … a potential future blocking counter will take over instead. To count the new blocked XHR & co requests for example. Not incompatible with the future, therefore. ✔️Thank you in advance. 👍
Environment
Browser Assistant 1.3.13 on Firefox 103.0.2
AdGuard 7.10.2 on Windows 10 Pro 21H2 (OS Build 19044.1865)
The text was updated successfully, but these errors were encountered: