-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iPad (6th Generation) v14.0.1 not correctly recognized #188
Comments
Idea for a possible solution: |
Hey @ajafff . Thanks for reporting this with the details 👍 |
This was tested on a real device. I tried to contribute a fix. Unfortunately I don't understand what's going on in the code. For example, I don't know how the condition on line 72 could ever be true. |
Ahan. I'm gonna see if this is the same on my iPad 2. If it isn't the same, then wouldn't be able to test it unfortunaly. |
I just tested that. |
@ajafff then that's the cause. We can add this to the code then. I'm gonna try to get it done and released soon. Feel free to share a PR if you got time. I'll do it otherwise as soon as possible. |
Is it done !! |
Hey @sumitgsh . Not yet. Feel free to raise a PR if you're interested. |
text |
Using
ngx-device-detector@2.0.1
Safari:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0 Safari/605.1.15
Firefox Daylight 29.1:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15
Both give the following results:
device:
Unknown
, expectediPad
deviceType:
tablet
os:
Mac
, expectediOS
browser:
Safari
(that's fine for me to not be able to distinguish between Safari and Firefox)works on
Chrome:
Mozilla/5.0 (iPad; CPU OS 14_0 like Max OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/86.0.4240.93 Mobile/14E148 Safari/604.1
Edge:
Mozilla/5.0 (iPad; CPU OS 14_0_1 like Max OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0 EdgiOS/44.11.15 Mobile/14E148 Safari/604.1.15
The text was updated successfully, but these errors were encountered: