Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Brave Browser #269

Open
MattSenter opened this issue Feb 24, 2023 · 0 comments
Open

Detect Brave Browser #269

MattSenter opened this issue Feb 24, 2023 · 0 comments

Comments

@MattSenter
Copy link

Is your feature request related to a problem? Please describe.
Brave Browser is a popular alternative to Chrome, but there is no detection for it in the current library.

Describe the solution you'd like
Should be able to detect Brave Browser.

Describe alternatives you've considered
Considered not modifying this library and instead using it for all cases except Brave Browser, but then I just decided to commit to this lib.
MattSenter pushed a commit to lolli/ngx-device-detector that referenced this issue Feb 24, 2023
AhsanAyaz#269 Brave Browser Detection
f54445f 
# Problem

There is no detection for Brave Browser in this library.

# Solution

Add `userAgentData` inspection to detect Brave Browser. Note that `userAgentData` can also be used to detect `Chrome` over the legacy `userAgent` string.
MattSenter pushed a commit to lolli/ngx-device-detector that referenced this issue May 10, 2023
AhsanAyaz#269 Fix lint errors
b98922a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MattSenter