From 2bff1482e11ad808c9ca20f5cbdcf0bccdc9d71e Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Wed, 17 Jul 2024 12:05:10 +0200 Subject: [PATCH 01/62] Boilerplate to trigger and wait external workflow --- .github/workflows/pull-request.yml | 39 ++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 2eac12c85d3..a716c30e14e 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -492,6 +492,45 @@ jobs: echo "result ${{ toJson(steps.pr-forbidden.*.result) }}" && echo "result ${{ steps.pr-forbidden.*.result }}" echo "result ${{ contains(toJson(steps.pr-forbidden.*.result), 'failure') }}" + determine-complexity: + outputs: + level: ${{ steps.complexity.outputs.level }} + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 + with: + fetch-depth: 1 + - name: Determine complexity + id: complexity + run: | + echo "::set-output level=major" + + verify-downstream: + needs: [determine-complexity] + if: ${{ needs.determine-complexity.outputs.level == 'major' }} + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 + with: + fetch-depth: 1 + - name: Tests - HxP Frontend + uses: the-actions-org/workflow-dispatch@3133c5d135c7dbe4be4f9793872b6ef331b53bc7 # v4.0.0 + with: + repo: Alfresco/hxp-frontend-apps + ref: develop + workflow: acceptance-tests.yml + inputs: > + { + "environment": "hxpsRc", + "notify-on-failure": true, + "rp-trigger": "adf-to-hxp-test", + "slack-channel-id": "D056HA6MP6Y", + "slack-message-title": "ADF => HxP check\n🔴 Frontend e2e test failed" + } + token: ${{ secrets.ALFRESCO_BUILD_GH_TOKEN }} + wait-for-completion: true finalize: if: ${{ always() }} runs-on: ubuntu-latest From 2864879a043a968da1351b897c32b536a4b733aa Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Wed, 17 Jul 2024 12:59:42 +0200 Subject: [PATCH 02/62] Simulate major change --- lib/core/src/lib/auth/oidc/auth.service.ts | 73 +++++++++++----------- 1 file changed, 37 insertions(+), 36 deletions(-) diff --git a/lib/core/src/lib/auth/oidc/auth.service.ts b/lib/core/src/lib/auth/oidc/auth.service.ts index 4d44aa2d372..a6d3efe00ca 100644 --- a/lib/core/src/lib/auth/oidc/auth.service.ts +++ b/lib/core/src/lib/auth/oidc/auth.service.ts @@ -20,42 +20,43 @@ import { Observable } from 'rxjs'; /** * Provide authentication/authorization through OAuth2/OIDC protocol. + * simulate a change */ export abstract class AuthService { - abstract onLogin: Observable; - - abstract onTokenReceived: Observable; - - /** Subscribe to whether the user has valid Id/Access tokens. */ - abstract authenticated$: Observable; - - /** Get whether the user has valid Id/Access tokens. */ - abstract authenticated: boolean; - - /** Subscribe to errors reaching the IdP. */ - abstract idpUnreachable$: Observable; - - /** - * Initiate the IdP login flow. - */ - abstract login(currentUrl?: string): Promise | void; - - abstract baseAuthLogin(username: string, password: string): Observable ; - - /** - * Disconnect from IdP. - * - * @returns Promise may be returned depending on implementation - */ - abstract logout(): Promise | void; - - /** - * Complete the login flow. - * - * In browsers, checks URL for auth and stored state. Call this once the application returns from IdP. - * - * @returns Promise, resolve with stored state, reject if unable to reach IdP - */ - abstract loginCallback(loginOptions?: LoginOptions): Promise; - abstract updateIDPConfiguration(...args: any[]): void; + abstract onLogin: Observable; + + abstract onTokenReceived: Observable; + + /** Subscribe to whether the user has valid Id/Access tokens. */ + abstract authenticated$: Observable; + + /** Get whether the user has valid Id/Access tokens. */ + abstract authenticated: boolean; + + /** Subscribe to errors reaching the IdP. */ + abstract idpUnreachable$: Observable; + + /** + * Initiate the IdP login flow. + */ + abstract login(currentUrl?: string): Promise | void; + + abstract baseAuthLogin(username: string, password: string): Observable; + + /** + * Disconnect from IdP. + * + * @returns Promise may be returned depending on implementation + */ + abstract logout(): Promise | void; + + /** + * Complete the login flow. + * + * In browsers, checks URL for auth and stored state. Call this once the application returns from IdP. + * + * @returns Promise, resolve with stored state, reject if unable to reach IdP + */ + abstract loginCallback(loginOptions?: LoginOptions): Promise; + abstract updateIDPConfiguration(...args: any[]): void; } From 8e5d9b91eec9ff9804eb7e5451bd804e2d329fc5 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Wed, 17 Jul 2024 13:03:01 +0200 Subject: [PATCH 03/62] Speed up workflow --- .github/workflows/pull-request.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index a716c30e14e..07cb19004bf 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -113,6 +113,7 @@ jobs: fi check-if-pr-is-approved: + if: false runs-on: ubuntu-latest steps: - name: Checkout repository @@ -196,6 +197,7 @@ jobs: name: "Setup" runs-on: ubuntu-latest needs: [check-if-pr-is-approved, pre-checks] + if: false steps: - name: Checkout repository uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -216,6 +218,7 @@ jobs: name: "Unit tests: ${{ matrix.unit-tests.name }}" runs-on: ubuntu-latest needs: [setup] + if: false strategy: fail-fast: false # max-parallel: 4 @@ -250,6 +253,7 @@ jobs: name: "Lint" runs-on: ubuntu-latest needs: [setup] + if: false steps: - name: Checkout repository uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -265,6 +269,7 @@ jobs: name: "Build libs" runs-on: ubuntu-latest needs: [setup] + if: false steps: - name: Checkout repository uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -282,6 +287,7 @@ jobs: name: "e2e: storybook" needs: [build-libs, lint, unit-tests] runs-on: ubuntu-latest + if: false steps: - name: Checkout repository uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -301,6 +307,7 @@ jobs: name: "e2e: ${{ matrix.e2e-test.description }}" needs: [build-libs, lint, unit-tests] runs-on: ubuntu-latest + if: false strategy: fail-fast: false # max-parallel: 4 From ea4d6cd3b70ddfa41fdc6cbf8d4bd0464f480de4 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Wed, 17 Jul 2024 13:09:09 +0200 Subject: [PATCH 04/62] set status --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 07cb19004bf..5a41deb6550 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -511,7 +511,7 @@ jobs: - name: Determine complexity id: complexity run: | - echo "::set-output level=major" + echo "level=major" >> $GITHUB_OUTPUT verify-downstream: needs: [determine-complexity] From 33094d31ac4ac51ae9d552ca4ce15bdee65b81e8 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Wed, 17 Jul 2024 13:36:10 +0200 Subject: [PATCH 05/62] Target fix branch and link adf --- .github/workflows/pull-request.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 5a41deb6550..824132c69e3 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -526,11 +526,12 @@ jobs: uses: the-actions-org/workflow-dispatch@3133c5d135c7dbe4be4f9793872b6ef331b53bc7 # v4.0.0 with: repo: Alfresco/hxp-frontend-apps - ref: develop + ref: fix/AAE-24001-check-adf workflow: acceptance-tests.yml inputs: > { "environment": "hxpsRc", + "force-adf-link": true, "notify-on-failure": true, "rp-trigger": "adf-to-hxp-test", "slack-channel-id": "D056HA6MP6Y", From e56add620cfb9df0a389a2e0a955157d18341da2 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Wed, 17 Jul 2024 13:50:11 +0200 Subject: [PATCH 06/62] Simulate breaking change --- lib/core/src/lib/auth/oidc/public-api.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/core/src/lib/auth/oidc/public-api.ts b/lib/core/src/lib/auth/oidc/public-api.ts index 969076ddb2a..21b8b8168c3 100644 --- a/lib/core/src/lib/auth/oidc/public-api.ts +++ b/lib/core/src/lib/auth/oidc/public-api.ts @@ -17,7 +17,7 @@ export * from './auth-routing.module'; export * from './auth.module'; -export * from './auth.service'; +// export * from './auth.service'; export * from './oidc-auth.guard'; export * from './redirect-auth.service'; export * from './view/authentication-confirmation/authentication-confirmation.component'; From 857157bbe5ab60cf08b9487367b1a1c8bdf1dd78 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Wed, 17 Jul 2024 13:55:11 +0200 Subject: [PATCH 07/62] Simulate breaking change 2 --- lib/core/src/lib/auth/oidc/public-api.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/core/src/lib/auth/oidc/public-api.ts b/lib/core/src/lib/auth/oidc/public-api.ts index 21b8b8168c3..848e01b8f7b 100644 --- a/lib/core/src/lib/auth/oidc/public-api.ts +++ b/lib/core/src/lib/auth/oidc/public-api.ts @@ -18,7 +18,7 @@ export * from './auth-routing.module'; export * from './auth.module'; // export * from './auth.service'; -export * from './oidc-auth.guard'; +// export * from './oidc-auth.guard'; export * from './redirect-auth.service'; export * from './view/authentication-confirmation/authentication-confirmation.component'; export * from './oidc-authentication.service'; From ec62de3ea0815e71ba701469d2c537b7c092f59e Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Wed, 17 Jul 2024 14:00:50 +0200 Subject: [PATCH 08/62] Simulate breaking change 3 --- lib/core/src/lib/auth/oidc/public-api.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/core/src/lib/auth/oidc/public-api.ts b/lib/core/src/lib/auth/oidc/public-api.ts index 848e01b8f7b..f90a99457d5 100644 --- a/lib/core/src/lib/auth/oidc/public-api.ts +++ b/lib/core/src/lib/auth/oidc/public-api.ts @@ -19,6 +19,6 @@ export * from './auth-routing.module'; export * from './auth.module'; // export * from './auth.service'; // export * from './oidc-auth.guard'; -export * from './redirect-auth.service'; +// export * from './redirect-auth.service'; export * from './view/authentication-confirmation/authentication-confirmation.component'; export * from './oidc-authentication.service'; From ad3ced0bedcfd743b53fd77b18e82cfe6311e153 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Wed, 17 Jul 2024 15:06:15 +0200 Subject: [PATCH 09/62] Simulate breaking change 4 --- lib/core/src/lib/auth/oidc/public-api.ts | 2 +- package-lock.json | 301 +++++++++++++++++- package.json | 5 +- .../github/update/useme-to-test-restokit.js | 175 ++++++---- 4 files changed, 419 insertions(+), 64 deletions(-) diff --git a/lib/core/src/lib/auth/oidc/public-api.ts b/lib/core/src/lib/auth/oidc/public-api.ts index f90a99457d5..848e01b8f7b 100644 --- a/lib/core/src/lib/auth/oidc/public-api.ts +++ b/lib/core/src/lib/auth/oidc/public-api.ts @@ -19,6 +19,6 @@ export * from './auth-routing.module'; export * from './auth.module'; // export * from './auth.service'; // export * from './oidc-auth.guard'; -// export * from './redirect-auth.service'; +export * from './redirect-auth.service'; export * from './view/authentication-confirmation/authentication-confirmation.component'; export * from './oidc-authentication.service'; diff --git a/package-lock.json b/package-lock.json index 2068812ad39..8fef791f544 100644 --- a/package-lock.json +++ b/package-lock.json @@ -25,8 +25,9 @@ "@cspell/eslint-plugin": "^7.3.6", "@mat-datetimepicker/core": "11.0.3", "@ngx-translate/core": "^14.0.0", - "@storybook/core-server": "^8.1.10", - "@storybook/theming": "^8.1.10", + "@octokit/core": "^6.1.2", + "@octokit/rest": "^19.0.13", + "@storybook/core-server": "^7.6.5", "angular-oauth2-oidc": "^13.0.1", "angular-oauth2-oidc-jwks": "^17.0.2", "apollo-angular": "^5.0.2", @@ -8258,6 +8259,287 @@ "dev": true, "license": "ISC" }, + "node_modules/@octokit/auth-token": { + "version": "5.1.1", + "resolved": "https://registry.npmjs.org/@octokit/auth-token/-/auth-token-5.1.1.tgz", + "integrity": "sha512-rh3G3wDO8J9wSjfI436JUKzHIxq8NaiL0tVeB2aXmG6p/9859aUOAjA9pmSPNGGZxfwmaJ9ozOJImuNVJdpvbA==", + "engines": { + "node": ">= 18" + } + }, + "node_modules/@octokit/core": { + "version": "6.1.2", + "resolved": "https://registry.npmjs.org/@octokit/core/-/core-6.1.2.tgz", + "integrity": "sha512-hEb7Ma4cGJGEUNOAVmyfdB/3WirWMg5hDuNFVejGEDFqupeOysLc2sG6HJxY2etBp5YQu5Wtxwi020jS9xlUwg==", + "dependencies": { + "@octokit/auth-token": "^5.0.0", + "@octokit/graphql": "^8.0.0", + "@octokit/request": "^9.0.0", + "@octokit/request-error": "^6.0.1", + "@octokit/types": "^13.0.0", + "before-after-hook": "^3.0.2", + "universal-user-agent": "^7.0.0" + }, + "engines": { + "node": ">= 18" + } + }, + "node_modules/@octokit/endpoint": { + "version": "10.1.1", + "resolved": "https://registry.npmjs.org/@octokit/endpoint/-/endpoint-10.1.1.tgz", + "integrity": "sha512-JYjh5rMOwXMJyUpj028cu0Gbp7qe/ihxfJMLc8VZBMMqSwLgOxDI1911gV4Enl1QSavAQNJcwmwBF9M0VvLh6Q==", + "dependencies": { + "@octokit/types": "^13.0.0", + "universal-user-agent": "^7.0.2" + }, + "engines": { + "node": ">= 18" + } + }, + "node_modules/@octokit/graphql": { + "version": "8.1.1", + "resolved": "https://registry.npmjs.org/@octokit/graphql/-/graphql-8.1.1.tgz", + "integrity": "sha512-ukiRmuHTi6ebQx/HFRCXKbDlOh/7xEV6QUXaE7MJEKGNAncGI/STSbOkl12qVXZrfZdpXctx5O9X1AIaebiDBg==", + "dependencies": { + "@octokit/request": "^9.0.0", + "@octokit/types": "^13.0.0", + "universal-user-agent": "^7.0.0" + }, + "engines": { + "node": ">= 18" + } + }, + "node_modules/@octokit/openapi-types": { + "version": "22.2.0", + "resolved": "https://registry.npmjs.org/@octokit/openapi-types/-/openapi-types-22.2.0.tgz", + "integrity": "sha512-QBhVjcUa9W7Wwhm6DBFu6ZZ+1/t/oYxqc2tp81Pi41YNuJinbFRx8B133qVOrAaBbF7D/m0Et6f9/pZt9Rc+tg==" + }, + "node_modules/@octokit/plugin-paginate-rest": { + "version": "6.1.2", + "resolved": "https://registry.npmjs.org/@octokit/plugin-paginate-rest/-/plugin-paginate-rest-6.1.2.tgz", + "integrity": "sha512-qhrmtQeHU/IivxucOV1bbI/xZyC/iOBhclokv7Sut5vnejAIAEXVcGQeRpQlU39E0WwK9lNvJHphHri/DB6lbQ==", + "dependencies": { + "@octokit/tsconfig": "^1.0.2", + "@octokit/types": "^9.2.3" + }, + "engines": { + "node": ">= 14" + }, + "peerDependencies": { + "@octokit/core": ">=4" + } + }, + "node_modules/@octokit/plugin-paginate-rest/node_modules/@octokit/openapi-types": { + "version": "18.1.1", + "resolved": "https://registry.npmjs.org/@octokit/openapi-types/-/openapi-types-18.1.1.tgz", + "integrity": "sha512-VRaeH8nCDtF5aXWnjPuEMIYf1itK/s3JYyJcWFJT8X9pSNnBtriDf7wlEWsGuhPLl4QIH4xM8fqTXDwJ3Mu6sw==" + }, + "node_modules/@octokit/plugin-paginate-rest/node_modules/@octokit/types": { + "version": "9.3.2", + "resolved": "https://registry.npmjs.org/@octokit/types/-/types-9.3.2.tgz", + "integrity": "sha512-D4iHGTdAnEEVsB8fl95m1hiz7D5YiRdQ9b/OEb3BYRVwbLsGHcRVPz+u+BgRLNk0Q0/4iZCBqDN96j2XNxfXrA==", + "dependencies": { + "@octokit/openapi-types": "^18.0.0" + } + }, + "node_modules/@octokit/plugin-request-log": { + "version": "1.0.4", + "resolved": "https://registry.npmjs.org/@octokit/plugin-request-log/-/plugin-request-log-1.0.4.tgz", + "integrity": "sha512-mLUsMkgP7K/cnFEw07kWqXGF5LKrOkD+lhCrKvPHXWDywAwuDUeDwWBpc69XK3pNX0uKiVt8g5z96PJ6z9xCFA==", + "peerDependencies": { + "@octokit/core": ">=3" + } + }, + "node_modules/@octokit/plugin-rest-endpoint-methods": { + "version": "7.2.3", + "resolved": "https://registry.npmjs.org/@octokit/plugin-rest-endpoint-methods/-/plugin-rest-endpoint-methods-7.2.3.tgz", + "integrity": "sha512-I5Gml6kTAkzVlN7KCtjOM+Ruwe/rQppp0QU372K1GP7kNOYEKe8Xn5BW4sE62JAHdwpq95OQK/qGNyKQMUzVgA==", + "dependencies": { + "@octokit/types": "^10.0.0" + }, + "engines": { + "node": ">= 14" + }, + "peerDependencies": { + "@octokit/core": ">=3" + } + }, + "node_modules/@octokit/plugin-rest-endpoint-methods/node_modules/@octokit/openapi-types": { + "version": "18.1.1", + "resolved": "https://registry.npmjs.org/@octokit/openapi-types/-/openapi-types-18.1.1.tgz", + "integrity": "sha512-VRaeH8nCDtF5aXWnjPuEMIYf1itK/s3JYyJcWFJT8X9pSNnBtriDf7wlEWsGuhPLl4QIH4xM8fqTXDwJ3Mu6sw==" + }, + "node_modules/@octokit/plugin-rest-endpoint-methods/node_modules/@octokit/types": { + "version": "10.0.0", + "resolved": "https://registry.npmjs.org/@octokit/types/-/types-10.0.0.tgz", + "integrity": "sha512-Vm8IddVmhCgU1fxC1eyinpwqzXPEYu0NrYzD3YZjlGjyftdLBTeqNblRC0jmJmgxbJIsQlyogVeGnrNaaMVzIg==", + "dependencies": { + "@octokit/openapi-types": "^18.0.0" + } + }, + "node_modules/@octokit/request": { + "version": "9.1.3", + "resolved": "https://registry.npmjs.org/@octokit/request/-/request-9.1.3.tgz", + "integrity": "sha512-V+TFhu5fdF3K58rs1pGUJIDH5RZLbZm5BI+MNF+6o/ssFNT4vWlCh/tVpF3NxGtP15HUxTTMUbsG5llAuU2CZA==", + "dependencies": { + "@octokit/endpoint": "^10.0.0", + "@octokit/request-error": "^6.0.1", + "@octokit/types": "^13.1.0", + "universal-user-agent": "^7.0.2" + }, + "engines": { + "node": ">= 18" + } + }, + "node_modules/@octokit/request-error": { + "version": "6.1.4", + "resolved": "https://registry.npmjs.org/@octokit/request-error/-/request-error-6.1.4.tgz", + "integrity": "sha512-VpAhIUxwhWZQImo/dWAN/NpPqqojR6PSLgLYAituLM6U+ddx9hCioFGwBr5Mi+oi5CLeJkcAs3gJ0PYYzU6wUg==", + "dependencies": { + "@octokit/types": "^13.0.0" + }, + "engines": { + "node": ">= 18" + } + }, + "node_modules/@octokit/rest": { + "version": "19.0.13", + "resolved": "https://registry.npmjs.org/@octokit/rest/-/rest-19.0.13.tgz", + "integrity": "sha512-/EzVox5V9gYGdbAI+ovYj3nXQT1TtTHRT+0eZPcuC05UFSWO3mdO9UY1C0i2eLF9Un1ONJkAk+IEtYGAC+TahA==", + "dependencies": { + "@octokit/core": "^4.2.1", + "@octokit/plugin-paginate-rest": "^6.1.2", + "@octokit/plugin-request-log": "^1.0.4", + "@octokit/plugin-rest-endpoint-methods": "^7.1.2" + }, + "engines": { + "node": ">= 14" + } + }, + "node_modules/@octokit/rest/node_modules/@octokit/auth-token": { + "version": "3.0.4", + "resolved": "https://registry.npmjs.org/@octokit/auth-token/-/auth-token-3.0.4.tgz", + "integrity": "sha512-TWFX7cZF2LXoCvdmJWY7XVPi74aSY0+FfBZNSXEXFkMpjcqsQwDSYVv5FhRFaI0V1ECnwbz4j59T/G+rXNWaIQ==", + "engines": { + "node": ">= 14" + } + }, + "node_modules/@octokit/rest/node_modules/@octokit/core": { + "version": "4.2.4", + "resolved": "https://registry.npmjs.org/@octokit/core/-/core-4.2.4.tgz", + "integrity": "sha512-rYKilwgzQ7/imScn3M9/pFfUf4I1AZEH3KhyJmtPdE2zfaXAn2mFfUy4FbKewzc2We5y/LlKLj36fWJLKC2SIQ==", + "dependencies": { + "@octokit/auth-token": "^3.0.0", + "@octokit/graphql": "^5.0.0", + "@octokit/request": "^6.0.0", + "@octokit/request-error": "^3.0.0", + "@octokit/types": "^9.0.0", + "before-after-hook": "^2.2.0", + "universal-user-agent": "^6.0.0" + }, + "engines": { + "node": ">= 14" + } + }, + "node_modules/@octokit/rest/node_modules/@octokit/endpoint": { + "version": "7.0.6", + "resolved": "https://registry.npmjs.org/@octokit/endpoint/-/endpoint-7.0.6.tgz", + "integrity": "sha512-5L4fseVRUsDFGR00tMWD/Trdeeihn999rTMGRMC1G/Ldi1uWlWJzI98H4Iak5DB/RVvQuyMYKqSK/R6mbSOQyg==", + "dependencies": { + "@octokit/types": "^9.0.0", + "is-plain-object": "^5.0.0", + "universal-user-agent": "^6.0.0" + }, + "engines": { + "node": ">= 14" + } + }, + "node_modules/@octokit/rest/node_modules/@octokit/graphql": { + "version": "5.0.6", + "resolved": "https://registry.npmjs.org/@octokit/graphql/-/graphql-5.0.6.tgz", + "integrity": "sha512-Fxyxdy/JH0MnIB5h+UQ3yCoh1FG4kWXfFKkpWqjZHw/p+Kc8Y44Hu/kCgNBT6nU1shNumEchmW/sUO1JuQnPcw==", + "dependencies": { + "@octokit/request": "^6.0.0", + "@octokit/types": "^9.0.0", + "universal-user-agent": "^6.0.0" + }, + "engines": { + "node": ">= 14" + } + }, + "node_modules/@octokit/rest/node_modules/@octokit/openapi-types": { + "version": "18.1.1", + "resolved": "https://registry.npmjs.org/@octokit/openapi-types/-/openapi-types-18.1.1.tgz", + "integrity": "sha512-VRaeH8nCDtF5aXWnjPuEMIYf1itK/s3JYyJcWFJT8X9pSNnBtriDf7wlEWsGuhPLl4QIH4xM8fqTXDwJ3Mu6sw==" + }, + "node_modules/@octokit/rest/node_modules/@octokit/request": { + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@octokit/request/-/request-6.2.8.tgz", + "integrity": "sha512-ow4+pkVQ+6XVVsekSYBzJC0VTVvh/FCTUUgTsboGq+DTeWdyIFV8WSCdo0RIxk6wSkBTHqIK1mYuY7nOBXOchw==", + "dependencies": { + "@octokit/endpoint": "^7.0.0", + "@octokit/request-error": "^3.0.0", + "@octokit/types": "^9.0.0", + "is-plain-object": "^5.0.0", + "node-fetch": "^2.6.7", + "universal-user-agent": "^6.0.0" + }, + "engines": { + "node": ">= 14" + } + }, + "node_modules/@octokit/rest/node_modules/@octokit/request-error": { + "version": "3.0.3", + "resolved": "https://registry.npmjs.org/@octokit/request-error/-/request-error-3.0.3.tgz", + "integrity": "sha512-crqw3V5Iy2uOU5Np+8M/YexTlT8zxCfI+qu+LxUB7SZpje4Qmx3mub5DfEKSO8Ylyk0aogi6TYdf6kxzh2BguQ==", + "dependencies": { + "@octokit/types": "^9.0.0", + "deprecation": "^2.0.0", + "once": "^1.4.0" + }, + "engines": { + "node": ">= 14" + } + }, + "node_modules/@octokit/rest/node_modules/@octokit/types": { + "version": "9.3.2", + "resolved": "https://registry.npmjs.org/@octokit/types/-/types-9.3.2.tgz", + "integrity": "sha512-D4iHGTdAnEEVsB8fl95m1hiz7D5YiRdQ9b/OEb3BYRVwbLsGHcRVPz+u+BgRLNk0Q0/4iZCBqDN96j2XNxfXrA==", + "dependencies": { + "@octokit/openapi-types": "^18.0.0" + } + }, + "node_modules/@octokit/rest/node_modules/before-after-hook": { + "version": "2.2.3", + "resolved": "https://registry.npmjs.org/before-after-hook/-/before-after-hook-2.2.3.tgz", + "integrity": "sha512-NzUnlZexiaH/46WDhANlyR2bXRopNg4F/zuSA3OpZnllCUgRaOF2znDioDWrmbNVsuZk6l9pMquQB38cfBZwkQ==" + }, + "node_modules/@octokit/rest/node_modules/is-plain-object": { + "version": "5.0.0", + "resolved": "https://registry.npmjs.org/is-plain-object/-/is-plain-object-5.0.0.tgz", + "integrity": "sha512-VRSzKkbMm5jMDoKLbltAkFQ5Qr7VDiTFGXxYFXXowVj387GeGNOCsOH6Msy00SGZ3Fp84b1Naa1psqgcCIEP5Q==", + "engines": { + "node": ">=0.10.0" + } + }, + "node_modules/@octokit/rest/node_modules/universal-user-agent": { + "version": "6.0.1", + "resolved": "https://registry.npmjs.org/universal-user-agent/-/universal-user-agent-6.0.1.tgz", + "integrity": "sha512-yCzhz6FN2wU1NiiQRogkTQszlQSlpWaw8SvVegAc+bDxbzHgh1vX8uIe8OYyMH6DwH+sdTJsgMl36+mSMdRJIQ==" + }, + "node_modules/@octokit/tsconfig": { + "version": "1.0.2", + "resolved": "https://registry.npmjs.org/@octokit/tsconfig/-/tsconfig-1.0.2.tgz", + "integrity": "sha512-I0vDR0rdtP8p2lGMzvsJzbhdOWy405HcGovrspJ8RRibHnyRgggUSNO5AIox5LmqiwmatHKYsvj6VGFHkqS7lA==" + }, + "node_modules/@octokit/types": { + "version": "13.5.0", + "resolved": "https://registry.npmjs.org/@octokit/types/-/types-13.5.0.tgz", + "integrity": "sha512-HdqWTf5Z3qwDVlzCrP8UJquMwunpDiMPt5er+QjGzL4hqr/vBVY/MauQgS1xWxCDT1oMx1EULyqxncdCY/NVSQ==", + "dependencies": { + "@octokit/openapi-types": "^22.2.0" + } + }, "node_modules/@paperist/types-remark": { "version": "0.1.3", "dev": true, @@ -16484,6 +16766,11 @@ "tweetnacl": "^0.14.3" } }, + "node_modules/before-after-hook": { + "version": "3.0.2", + "resolved": "https://registry.npmjs.org/before-after-hook/-/before-after-hook-3.0.2.tgz", + "integrity": "sha512-Nik3Sc0ncrMK4UUdXQmAnRtzmNQTAAXmXIopizwZ1W1t8QmfJj+zL4OA2I7XPTPW5z5TDqv4hRo/JzouDJnX3A==" + }, "node_modules/bent": { "version": "7.3.12", "dev": true, @@ -19309,6 +19596,11 @@ "node": ">= 0.6.0" } }, + "node_modules/deprecation": { + "version": "2.3.1", + "resolved": "https://registry.npmjs.org/deprecation/-/deprecation-2.3.1.tgz", + "integrity": "sha512-xmHIy4F3scKVwMsQ4WnVaS8bHOx0DmVwRywosKhaILI0ywMDWPtBSku2HNxRvF7jtwDRsoEwYQSfbxj8b7RlJQ==" + }, "node_modules/dequal": { "version": "2.0.3", "dev": true, @@ -36058,6 +36350,11 @@ "license": "MIT", "peer": true }, + "node_modules/universal-user-agent": { + "version": "7.0.2", + "resolved": "https://registry.npmjs.org/universal-user-agent/-/universal-user-agent-7.0.2.tgz", + "integrity": "sha512-0JCqzSKnStlRRQfCdowvqy3cy0Dvtlb8xecj/H8JFZuCze4rwjPZQOgvFvn0Ws/usCHQFGpyr+pB9adaGwXn4Q==" + }, "node_modules/universalify": { "version": "2.0.1", "dev": true, diff --git a/package.json b/package.json index b2de7ad985b..f88274ea62d 100644 --- a/package.json +++ b/package.json @@ -72,8 +72,9 @@ "@cspell/eslint-plugin": "^7.3.6", "@mat-datetimepicker/core": "11.0.3", "@ngx-translate/core": "^14.0.0", - "@storybook/core-server": "^8.1.10", - "@storybook/theming": "^8.1.10", + "@octokit/core": "^6.1.2", + "@octokit/rest": "^19.0.13", + "@storybook/core-server": "^7.6.5", "angular-oauth2-oidc": "^13.0.1", "angular-oauth2-oidc-jwks": "^17.0.2", "apollo-angular": "^5.0.2", diff --git a/scripts/github/update/useme-to-test-restokit.js b/scripts/github/update/useme-to-test-restokit.js index 0fb17506ff5..7cd042f238d 100755 --- a/scripts/github/update/useme-to-test-restokit.js +++ b/scripts/github/update/useme-to-test-restokit.js @@ -1,7 +1,6 @@ - -const { Octokit } = require("@octokit/rest"); +const { Octokit } = require('@octokit/rest'); const octokit = new Octokit({ - auth: "", + auth: '', userAgent: 'myApp v1.2.3', baseUrl: 'https://api.github.com', log: { @@ -9,64 +8,122 @@ const octokit = new Octokit({ info: () => {}, warn: console.warn, error: console.error - }, - request: { + }, + request: { agent: undefined, fetch: undefined, timeout: 0 - } + } +}); + +async function getPRDetails(owner, repo, pull_number) { + const { data: files } = await octokit.pulls.listFiles({ + owner, + repo, + pull_number }); - - async function asyncCall() { - const organization = 'alfresco'; - - const { data: availablePakages } = await octokit.rest.packages.getAllPackageVersionsForPackageOwnedByOrg({ - package_type: 'npm', - package_name: 'adf-core', - org: organization - }); - - // console.log(availablePakages[0]) - - availablePakages.push({ - id: 123, - name: '6.0.0-A.3', - metadata: { package_type: 'npm' } - }) - availablePakages.push({ - id: 222, - name: '6.0.1', - metadata: { package_type: 'npm' } - }) - - const filteredReleasePkgs = availablePakages.filter( (item) => item.name.match('^[0-9]*.[0-9]*.[0-9]*.A.[0-9]*$') || item.name.match('^[0-9]*.[0-9]*.[0-9]*$') ) - console.log(filteredReleasePkgs) - - // console.log('alpha') - // const filteredAlphaPkgs = availablePakages.filter( (item) => item.name.match('^[0-9]*\.[0-9]*\.[0-9]*.A\.[0-9]\.[0-9]*$') ) - // console.log(filteredAlphaPkgs) - - - - // const { data: info } = await octokit.rest.packages.getPackageForOrganization({ - // package_type: 'npm', - // package_name: 'adf-core', - // org: organization - // }); - - // console.log(info) - - // const { data: infos } = await octokit.rest.packages.getPackageVersionForOrganization({ - // package_type: 'npm', - // package_name: 'adf-core', - // org: organization, - // package_version_id: 85591610 - // }); - - // console.log(infos) - - } - - - asyncCall(); \ No newline at end of file + let filesChanged = files.length; + let linesChanged = files.reduce((total, file) => total + file.additions + file.deletions, 0); + + let level = 'unknown'; + let packageName = 'unknown'; + let packagesAffected = new Set(); + for (let file of files) { + if (file.filename.startsWith('lib/core/')) { + if (file.filename.startsWith('lib/core/auth/')) { + level = 'extreme'; + } + level = 'major'; + packageName = 'core'; + packagesAffected.add(packageName); + break; + } else if (file.filename.startsWith('lib/extensions/')) { + level = 'major'; + packageName = 'extensions'; + packagesAffected.add(packageName); + + break; + } else { + level = 'minor'; + packagesAffected.add(packageName); + } + } + + if (level !== 'major') { + if (linesChanged > 100) { + level = 'major'; + } else if (linesChanged > 50) { + level = 'medium'; + } + } + + if (level !== 'major') { + if (filesChanged > 10) { + level = 'major'; + } else if (filesChanged > 5) { + level = 'medium'; + } + } + + return { + filesChanged, + linesChanged, + level: level, + packagesAffected: Array.from(packagesAffected) + }; +} + +async function asyncCall() { + const organization = 'alfresco'; + const owner = 'Alfresco'; + const repo = 'alfresco-ng2-components'; + const pull_number = '9957'; + + const changes = await getPRDetails(owner, repo, pull_number); + + // const { data: availablePakages } = await octokit.rest.packages.getAllPackageVersionsForPackageOwnedByOrg({ + // package_type: 'npm', + // package_name: 'adf-core', + // org: organization + // }); + + // // console.log(availablePakages[0]) + + // availablePakages.push({ + // id: 123, + // name: '6.0.0-A.3', + // metadata: { package_type: 'npm' } + // }) + // availablePakages.push({ + // id: 222, + // name: '6.0.1', + // metadata: { package_type: 'npm' } + // }) + + // const filteredReleasePkgs = availablePakages.filter( (item) => item.name.match('^[0-9]*.[0-9]*.[0-9]*.A.[0-9]*$') || item.name.match('^[0-9]*.[0-9]*.[0-9]*$') ) + // console.log(filteredReleasePkgs) + + // console.log('alpha') + // const filteredAlphaPkgs = availablePakages.filter( (item) => item.name.match('^[0-9]*\.[0-9]*\.[0-9]*.A\.[0-9]\.[0-9]*$') ) + // console.log(filteredAlphaPkgs) + + // const { data: info } = await octokit.rest.packages.getPackageForOrganization({ + // package_type: 'npm', + // package_name: 'adf-core', + // org: organization + // }); + + // console.log(info) + + // const { data: infos } = await octokit.rest.packages.getPackageVersionForOrganization({ + // package_type: 'npm', + // package_name: 'adf-core', + // org: organization, + // package_version_id: 85591610 + // }); + + // console.log(infos) +} + +asyncCall(); From 9f9e31dc9c267a7add647270c332f5aaafd1013d Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Wed, 17 Jul 2024 15:24:43 +0200 Subject: [PATCH 10/62] Simulate breaking change 5 --- lib/core/src/lib/auth/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/core/src/lib/auth/index.ts b/lib/core/src/lib/auth/index.ts index 54beb1a252f..07d12dd6640 100644 --- a/lib/core/src/lib/auth/index.ts +++ b/lib/core/src/lib/auth/index.ts @@ -15,4 +15,4 @@ * limitations under the License. */ -export * from './public-api'; +export * from './public-api2'; From 2cbd46601fffb8c3006b8602861fe63c7eb438b3 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Wed, 17 Jul 2024 15:34:08 +0200 Subject: [PATCH 11/62] Simulate breaking change 6 --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 824132c69e3..c65e6011d23 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -530,7 +530,7 @@ jobs: workflow: acceptance-tests.yml inputs: > { - "environment": "hxpsRc", + "environment": "apaRc", "force-adf-link": true, "notify-on-failure": true, "rp-trigger": "adf-to-hxp-test", From 6f67261bd234e68eec3a9ecef11ee00854fe9120 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 15:04:40 +0200 Subject: [PATCH 12/62] Simulate breaking change 7 --- lib/core/src/lib/auth/index.ts | 2 +- lib/core/src/lib/auth/oidc/oidc-authentication.service.ts | 4 ---- lib/core/src/lib/auth/oidc/public-api.ts | 4 ++-- lib/core/src/lib/auth/services/base-authentication.service.ts | 2 +- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/core/src/lib/auth/index.ts b/lib/core/src/lib/auth/index.ts index 07d12dd6640..54beb1a252f 100644 --- a/lib/core/src/lib/auth/index.ts +++ b/lib/core/src/lib/auth/index.ts @@ -15,4 +15,4 @@ * limitations under the License. */ -export * from './public-api2'; +export * from './public-api'; diff --git a/lib/core/src/lib/auth/oidc/oidc-authentication.service.ts b/lib/core/src/lib/auth/oidc/oidc-authentication.service.ts index f9e8562e49e..8be96ba3668 100644 --- a/lib/core/src/lib/auth/oidc/oidc-authentication.service.ts +++ b/lib/core/src/lib/auth/oidc/oidc-authentication.service.ts @@ -59,10 +59,6 @@ export class OidcAuthenticationService extends BaseAuthenticationService { return false; } - isLoggedIn(): boolean { - return this.oauthService.hasValidAccessToken() && this.oauthService.hasValidIdToken(); - } - hasValidAccessToken(): boolean { return this.oauthService.hasValidAccessToken(); } diff --git a/lib/core/src/lib/auth/oidc/public-api.ts b/lib/core/src/lib/auth/oidc/public-api.ts index 848e01b8f7b..969076ddb2a 100644 --- a/lib/core/src/lib/auth/oidc/public-api.ts +++ b/lib/core/src/lib/auth/oidc/public-api.ts @@ -17,8 +17,8 @@ export * from './auth-routing.module'; export * from './auth.module'; -// export * from './auth.service'; -// export * from './oidc-auth.guard'; +export * from './auth.service'; +export * from './oidc-auth.guard'; export * from './redirect-auth.service'; export * from './view/authentication-confirmation/authentication-confirmation.component'; export * from './oidc-authentication.service'; diff --git a/lib/core/src/lib/auth/services/base-authentication.service.ts b/lib/core/src/lib/auth/services/base-authentication.service.ts index e4b50272c26..3985d3bbe9c 100644 --- a/lib/core/src/lib/auth/services/base-authentication.service.ts +++ b/lib/core/src/lib/auth/services/base-authentication.service.ts @@ -43,7 +43,7 @@ export abstract class BaseAuthenticationService implements AuthenticationService abstract getToken(): string; - abstract isLoggedIn(): boolean; + abstract isLoggedInNew(): boolean; abstract logout(): any; From d3c2e036b19f3e2e59ae4574a43dae30a7da96b5 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 15:12:30 +0200 Subject: [PATCH 13/62] Simulate breaking change 8 --- lib/core/src/lib/auth/services/base-authentication.service.ts | 2 +- .../src/lib/app/models/application-instance.model.ts | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/core/src/lib/auth/services/base-authentication.service.ts b/lib/core/src/lib/auth/services/base-authentication.service.ts index 3985d3bbe9c..e4b50272c26 100644 --- a/lib/core/src/lib/auth/services/base-authentication.service.ts +++ b/lib/core/src/lib/auth/services/base-authentication.service.ts @@ -43,7 +43,7 @@ export abstract class BaseAuthenticationService implements AuthenticationService abstract getToken(): string; - abstract isLoggedInNew(): boolean; + abstract isLoggedIn(): boolean; abstract logout(): any; diff --git a/lib/process-services-cloud/src/lib/app/models/application-instance.model.ts b/lib/process-services-cloud/src/lib/app/models/application-instance.model.ts index 792afa69459..fe2af3693a7 100644 --- a/lib/process-services-cloud/src/lib/app/models/application-instance.model.ts +++ b/lib/process-services-cloud/src/lib/app/models/application-instance.model.ts @@ -49,7 +49,6 @@ export interface Descriptor { } export enum DescriptorCustomUIAuthFlowType { - CODE = 'CODE', IMPLICIT = 'IMPLICIT' } From 79396430e988219b6b78e2128aa77c9008dddef0 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 15:20:26 +0200 Subject: [PATCH 14/62] Simulate breaking change 9 --- lib/core/src/lib/auth/oidc/oidc-authentication.service.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/core/src/lib/auth/oidc/oidc-authentication.service.ts b/lib/core/src/lib/auth/oidc/oidc-authentication.service.ts index 8be96ba3668..f9e8562e49e 100644 --- a/lib/core/src/lib/auth/oidc/oidc-authentication.service.ts +++ b/lib/core/src/lib/auth/oidc/oidc-authentication.service.ts @@ -59,6 +59,10 @@ export class OidcAuthenticationService extends BaseAuthenticationService { return false; } + isLoggedIn(): boolean { + return this.oauthService.hasValidAccessToken() && this.oauthService.hasValidIdToken(); + } + hasValidAccessToken(): boolean { return this.oauthService.hasValidAccessToken(); } From 1d3a15c12f5a55643752b66dc8e1205b7630abe4 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 15:46:43 +0200 Subject: [PATCH 15/62] Simulate breaking change 8 From ce0b4299d5813487a694954440b7f13d140bc884 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 15:52:09 +0200 Subject: [PATCH 16/62] Pass use local adf --- .github/workflows/pull-request.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index c65e6011d23..8dd64fe1246 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -531,6 +531,7 @@ jobs: inputs: > { "environment": "apaRc", + "use-local-adf": true, "force-adf-link": true, "notify-on-failure": true, "rp-trigger": "adf-to-hxp-test", From 01e5933203c13bcd957275c90605d75b586f8522 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 15:59:37 +0200 Subject: [PATCH 17/62] Simulate breaking change 9 From d8c277d00306ae1355fedea5044d8bb65d2bf74d Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 16:00:13 +0200 Subject: [PATCH 18/62] Simulate breaking change 10 --- .github/workflows/pull-request.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 8dd64fe1246..c65e6011d23 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -531,7 +531,6 @@ jobs: inputs: > { "environment": "apaRc", - "use-local-adf": true, "force-adf-link": true, "notify-on-failure": true, "rp-trigger": "adf-to-hxp-test", From 04b5611b44fba72c6182e95b2f57484a85528e88 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 16:41:10 +0200 Subject: [PATCH 19/62] Use local adf branch as input --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index c65e6011d23..d7d1ccf44bd 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -531,7 +531,7 @@ jobs: inputs: > { "environment": "apaRc", - "force-adf-link": true, + "use-local-ad": "fix/AAE-24001-complexity-trigger", "notify-on-failure": true, "rp-trigger": "adf-to-hxp-test", "slack-channel-id": "D056HA6MP6Y", From f107b6e95b5ea515443789a82062f9cd769a49fc Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 16:47:49 +0200 Subject: [PATCH 20/62] Use local adf branch as input fix --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index d7d1ccf44bd..cecc8e1b7e6 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -531,7 +531,7 @@ jobs: inputs: > { "environment": "apaRc", - "use-local-ad": "fix/AAE-24001-complexity-trigger", + "use-local-adf": "fix/AAE-24001-complexity-trigger", "notify-on-failure": true, "rp-trigger": "adf-to-hxp-test", "slack-channel-id": "D056HA6MP6Y", From 73a4bc3e17f7d8cba2dc3b497ec9869e9fca8270 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 16:56:25 +0200 Subject: [PATCH 21/62] Simulate breaking change 11 From c1926fbf5af3363da89072507869a59a227f6ab7 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 17:03:41 +0200 Subject: [PATCH 22/62] Simulate breaking change 12 From bf8d559f7683dff51aeabe6a648f8de17b38b1ea Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 17:08:24 +0200 Subject: [PATCH 23/62] Simulate breaking change 13 From f7ad618d79a0223d44f4058870880a1f9c7a7d4e Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 17:13:01 +0200 Subject: [PATCH 24/62] Simulate breaking change 14 From 2883b6e3d9e7a0d1efa3b93b44fd04b378234da8 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 17:18:43 +0200 Subject: [PATCH 25/62] Simulate breaking change 14 From c9572395caedf14ba076e56094531829dc7e1542 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 17:23:43 +0200 Subject: [PATCH 26/62] Simulate breaking change 15 From 2d9c6b84d744ce32580b51a7e875269d60f1f214 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Thu, 18 Jul 2024 17:31:01 +0200 Subject: [PATCH 27/62] Simulate breaking change 16 From 9115bf0a39a971839f4d448444fc394a23fc333b Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 10:14:05 +0200 Subject: [PATCH 28/62] Simulate breaking change 17 --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index cecc8e1b7e6..4a33ca9fa0b 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -531,7 +531,7 @@ jobs: inputs: > { "environment": "apaRc", - "use-local-adf": "fix/AAE-24001-complexity-trigger", + "use-local-adf": ${{ env.BRANCH_NAME }}, "notify-on-failure": true, "rp-trigger": "adf-to-hxp-test", "slack-channel-id": "D056HA6MP6Y", From d776c0ce8b84cc84a4c335154e876a4bbbc0dec3 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 10:27:05 +0200 Subject: [PATCH 29/62] Simulate breaking change 17 --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 4a33ca9fa0b..e0a9449c9d8 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -531,7 +531,7 @@ jobs: inputs: > { "environment": "apaRc", - "use-local-adf": ${{ env.BRANCH_NAME }}, + "use-local-adf": "${{ env.BRANCH_NAME }}", "notify-on-failure": true, "rp-trigger": "adf-to-hxp-test", "slack-channel-id": "D056HA6MP6Y", From b5d3b800a635a1fc2dc874097f16864444185d7a Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 10:31:39 +0200 Subject: [PATCH 30/62] Simulate breaking change 18 --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index e0a9449c9d8..36fb383fe70 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -113,7 +113,6 @@ jobs: fi check-if-pr-is-approved: - if: false runs-on: ubuntu-latest steps: - name: Checkout repository @@ -155,6 +154,7 @@ jobs: DEVEL_FLAG: ${{ inputs.devel }} GH_TOKEN: ${{ github.token }} skip_check: "false" + if: false run: | if [ "${{ github.event_name }}" == "schedule" ] || [ "${{ github.actor }}" == "dependabot[bot]" ]; then echo -e "\033[32mci:force check can be skipped\033[0m" From c230d488c7a4b9027e8f74e5b5810896c03fc432 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 11:07:48 +0200 Subject: [PATCH 31/62] Simulate breaking change 19 From f8981a4095644e06b79ace265076a4ab4762a880 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 11:12:03 +0200 Subject: [PATCH 32/62] Simulate breaking change 20 --- package-lock.json | 199 ---------------------------------------------- package.json | 1 - 2 files changed, 200 deletions(-) diff --git a/package-lock.json b/package-lock.json index 8fef791f544..25918e8712f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -26,7 +26,6 @@ "@mat-datetimepicker/core": "11.0.3", "@ngx-translate/core": "^14.0.0", "@octokit/core": "^6.1.2", - "@octokit/rest": "^19.0.13", "@storybook/core-server": "^7.6.5", "angular-oauth2-oidc": "^13.0.1", "angular-oauth2-oidc-jwks": "^17.0.2", @@ -8314,69 +8313,6 @@ "resolved": "https://registry.npmjs.org/@octokit/openapi-types/-/openapi-types-22.2.0.tgz", "integrity": "sha512-QBhVjcUa9W7Wwhm6DBFu6ZZ+1/t/oYxqc2tp81Pi41YNuJinbFRx8B133qVOrAaBbF7D/m0Et6f9/pZt9Rc+tg==" }, - "node_modules/@octokit/plugin-paginate-rest": { - "version": "6.1.2", - "resolved": "https://registry.npmjs.org/@octokit/plugin-paginate-rest/-/plugin-paginate-rest-6.1.2.tgz", - "integrity": "sha512-qhrmtQeHU/IivxucOV1bbI/xZyC/iOBhclokv7Sut5vnejAIAEXVcGQeRpQlU39E0WwK9lNvJHphHri/DB6lbQ==", - "dependencies": { - "@octokit/tsconfig": "^1.0.2", - "@octokit/types": "^9.2.3" - }, - "engines": { - "node": ">= 14" - }, - "peerDependencies": { - "@octokit/core": ">=4" - } - }, - "node_modules/@octokit/plugin-paginate-rest/node_modules/@octokit/openapi-types": { - "version": "18.1.1", - "resolved": "https://registry.npmjs.org/@octokit/openapi-types/-/openapi-types-18.1.1.tgz", - "integrity": "sha512-VRaeH8nCDtF5aXWnjPuEMIYf1itK/s3JYyJcWFJT8X9pSNnBtriDf7wlEWsGuhPLl4QIH4xM8fqTXDwJ3Mu6sw==" - }, - "node_modules/@octokit/plugin-paginate-rest/node_modules/@octokit/types": { - "version": "9.3.2", - "resolved": "https://registry.npmjs.org/@octokit/types/-/types-9.3.2.tgz", - "integrity": "sha512-D4iHGTdAnEEVsB8fl95m1hiz7D5YiRdQ9b/OEb3BYRVwbLsGHcRVPz+u+BgRLNk0Q0/4iZCBqDN96j2XNxfXrA==", - "dependencies": { - "@octokit/openapi-types": "^18.0.0" - } - }, - "node_modules/@octokit/plugin-request-log": { - "version": "1.0.4", - "resolved": "https://registry.npmjs.org/@octokit/plugin-request-log/-/plugin-request-log-1.0.4.tgz", - "integrity": "sha512-mLUsMkgP7K/cnFEw07kWqXGF5LKrOkD+lhCrKvPHXWDywAwuDUeDwWBpc69XK3pNX0uKiVt8g5z96PJ6z9xCFA==", - "peerDependencies": { - "@octokit/core": ">=3" - } - }, - "node_modules/@octokit/plugin-rest-endpoint-methods": { - "version": "7.2.3", - "resolved": "https://registry.npmjs.org/@octokit/plugin-rest-endpoint-methods/-/plugin-rest-endpoint-methods-7.2.3.tgz", - "integrity": "sha512-I5Gml6kTAkzVlN7KCtjOM+Ruwe/rQppp0QU372K1GP7kNOYEKe8Xn5BW4sE62JAHdwpq95OQK/qGNyKQMUzVgA==", - "dependencies": { - "@octokit/types": "^10.0.0" - }, - "engines": { - "node": ">= 14" - }, - "peerDependencies": { - "@octokit/core": ">=3" - } - }, - "node_modules/@octokit/plugin-rest-endpoint-methods/node_modules/@octokit/openapi-types": { - "version": "18.1.1", - "resolved": "https://registry.npmjs.org/@octokit/openapi-types/-/openapi-types-18.1.1.tgz", - "integrity": "sha512-VRaeH8nCDtF5aXWnjPuEMIYf1itK/s3JYyJcWFJT8X9pSNnBtriDf7wlEWsGuhPLl4QIH4xM8fqTXDwJ3Mu6sw==" - }, - "node_modules/@octokit/plugin-rest-endpoint-methods/node_modules/@octokit/types": { - "version": "10.0.0", - "resolved": "https://registry.npmjs.org/@octokit/types/-/types-10.0.0.tgz", - "integrity": "sha512-Vm8IddVmhCgU1fxC1eyinpwqzXPEYu0NrYzD3YZjlGjyftdLBTeqNblRC0jmJmgxbJIsQlyogVeGnrNaaMVzIg==", - "dependencies": { - "@octokit/openapi-types": "^18.0.0" - } - }, "node_modules/@octokit/request": { "version": "9.1.3", "resolved": "https://registry.npmjs.org/@octokit/request/-/request-9.1.3.tgz", @@ -8402,136 +8338,6 @@ "node": ">= 18" } }, - "node_modules/@octokit/rest": { - "version": "19.0.13", - "resolved": "https://registry.npmjs.org/@octokit/rest/-/rest-19.0.13.tgz", - "integrity": "sha512-/EzVox5V9gYGdbAI+ovYj3nXQT1TtTHRT+0eZPcuC05UFSWO3mdO9UY1C0i2eLF9Un1ONJkAk+IEtYGAC+TahA==", - "dependencies": { - "@octokit/core": "^4.2.1", - "@octokit/plugin-paginate-rest": "^6.1.2", - "@octokit/plugin-request-log": "^1.0.4", - "@octokit/plugin-rest-endpoint-methods": "^7.1.2" - }, - "engines": { - "node": ">= 14" - } - }, - "node_modules/@octokit/rest/node_modules/@octokit/auth-token": { - "version": "3.0.4", - "resolved": "https://registry.npmjs.org/@octokit/auth-token/-/auth-token-3.0.4.tgz", - "integrity": "sha512-TWFX7cZF2LXoCvdmJWY7XVPi74aSY0+FfBZNSXEXFkMpjcqsQwDSYVv5FhRFaI0V1ECnwbz4j59T/G+rXNWaIQ==", - "engines": { - "node": ">= 14" - } - }, - "node_modules/@octokit/rest/node_modules/@octokit/core": { - "version": "4.2.4", - "resolved": "https://registry.npmjs.org/@octokit/core/-/core-4.2.4.tgz", - "integrity": "sha512-rYKilwgzQ7/imScn3M9/pFfUf4I1AZEH3KhyJmtPdE2zfaXAn2mFfUy4FbKewzc2We5y/LlKLj36fWJLKC2SIQ==", - "dependencies": { - "@octokit/auth-token": "^3.0.0", - "@octokit/graphql": "^5.0.0", - "@octokit/request": "^6.0.0", - "@octokit/request-error": "^3.0.0", - "@octokit/types": "^9.0.0", - "before-after-hook": "^2.2.0", - "universal-user-agent": "^6.0.0" - }, - "engines": { - "node": ">= 14" - } - }, - "node_modules/@octokit/rest/node_modules/@octokit/endpoint": { - "version": "7.0.6", - "resolved": "https://registry.npmjs.org/@octokit/endpoint/-/endpoint-7.0.6.tgz", - "integrity": "sha512-5L4fseVRUsDFGR00tMWD/Trdeeihn999rTMGRMC1G/Ldi1uWlWJzI98H4Iak5DB/RVvQuyMYKqSK/R6mbSOQyg==", - "dependencies": { - "@octokit/types": "^9.0.0", - "is-plain-object": "^5.0.0", - "universal-user-agent": "^6.0.0" - }, - "engines": { - "node": ">= 14" - } - }, - "node_modules/@octokit/rest/node_modules/@octokit/graphql": { - "version": "5.0.6", - "resolved": "https://registry.npmjs.org/@octokit/graphql/-/graphql-5.0.6.tgz", - "integrity": "sha512-Fxyxdy/JH0MnIB5h+UQ3yCoh1FG4kWXfFKkpWqjZHw/p+Kc8Y44Hu/kCgNBT6nU1shNumEchmW/sUO1JuQnPcw==", - "dependencies": { - "@octokit/request": "^6.0.0", - "@octokit/types": "^9.0.0", - "universal-user-agent": "^6.0.0" - }, - "engines": { - "node": ">= 14" - } - }, - "node_modules/@octokit/rest/node_modules/@octokit/openapi-types": { - "version": "18.1.1", - "resolved": "https://registry.npmjs.org/@octokit/openapi-types/-/openapi-types-18.1.1.tgz", - "integrity": "sha512-VRaeH8nCDtF5aXWnjPuEMIYf1itK/s3JYyJcWFJT8X9pSNnBtriDf7wlEWsGuhPLl4QIH4xM8fqTXDwJ3Mu6sw==" - }, - "node_modules/@octokit/rest/node_modules/@octokit/request": { - "version": "6.2.8", - "resolved": "https://registry.npmjs.org/@octokit/request/-/request-6.2.8.tgz", - "integrity": "sha512-ow4+pkVQ+6XVVsekSYBzJC0VTVvh/FCTUUgTsboGq+DTeWdyIFV8WSCdo0RIxk6wSkBTHqIK1mYuY7nOBXOchw==", - "dependencies": { - "@octokit/endpoint": "^7.0.0", - "@octokit/request-error": "^3.0.0", - "@octokit/types": "^9.0.0", - "is-plain-object": "^5.0.0", - "node-fetch": "^2.6.7", - "universal-user-agent": "^6.0.0" - }, - "engines": { - "node": ">= 14" - } - }, - "node_modules/@octokit/rest/node_modules/@octokit/request-error": { - "version": "3.0.3", - "resolved": "https://registry.npmjs.org/@octokit/request-error/-/request-error-3.0.3.tgz", - "integrity": "sha512-crqw3V5Iy2uOU5Np+8M/YexTlT8zxCfI+qu+LxUB7SZpje4Qmx3mub5DfEKSO8Ylyk0aogi6TYdf6kxzh2BguQ==", - "dependencies": { - "@octokit/types": "^9.0.0", - "deprecation": "^2.0.0", - "once": "^1.4.0" - }, - "engines": { - "node": ">= 14" - } - }, - "node_modules/@octokit/rest/node_modules/@octokit/types": { - "version": "9.3.2", - "resolved": "https://registry.npmjs.org/@octokit/types/-/types-9.3.2.tgz", - "integrity": "sha512-D4iHGTdAnEEVsB8fl95m1hiz7D5YiRdQ9b/OEb3BYRVwbLsGHcRVPz+u+BgRLNk0Q0/4iZCBqDN96j2XNxfXrA==", - "dependencies": { - "@octokit/openapi-types": "^18.0.0" - } - }, - "node_modules/@octokit/rest/node_modules/before-after-hook": { - "version": "2.2.3", - "resolved": "https://registry.npmjs.org/before-after-hook/-/before-after-hook-2.2.3.tgz", - "integrity": "sha512-NzUnlZexiaH/46WDhANlyR2bXRopNg4F/zuSA3OpZnllCUgRaOF2znDioDWrmbNVsuZk6l9pMquQB38cfBZwkQ==" - }, - "node_modules/@octokit/rest/node_modules/is-plain-object": { - "version": "5.0.0", - "resolved": "https://registry.npmjs.org/is-plain-object/-/is-plain-object-5.0.0.tgz", - "integrity": "sha512-VRSzKkbMm5jMDoKLbltAkFQ5Qr7VDiTFGXxYFXXowVj387GeGNOCsOH6Msy00SGZ3Fp84b1Naa1psqgcCIEP5Q==", - "engines": { - "node": ">=0.10.0" - } - }, - "node_modules/@octokit/rest/node_modules/universal-user-agent": { - "version": "6.0.1", - "resolved": "https://registry.npmjs.org/universal-user-agent/-/universal-user-agent-6.0.1.tgz", - "integrity": "sha512-yCzhz6FN2wU1NiiQRogkTQszlQSlpWaw8SvVegAc+bDxbzHgh1vX8uIe8OYyMH6DwH+sdTJsgMl36+mSMdRJIQ==" - }, - "node_modules/@octokit/tsconfig": { - "version": "1.0.2", - "resolved": "https://registry.npmjs.org/@octokit/tsconfig/-/tsconfig-1.0.2.tgz", - "integrity": "sha512-I0vDR0rdtP8p2lGMzvsJzbhdOWy405HcGovrspJ8RRibHnyRgggUSNO5AIox5LmqiwmatHKYsvj6VGFHkqS7lA==" - }, "node_modules/@octokit/types": { "version": "13.5.0", "resolved": "https://registry.npmjs.org/@octokit/types/-/types-13.5.0.tgz", @@ -19596,11 +19402,6 @@ "node": ">= 0.6.0" } }, - "node_modules/deprecation": { - "version": "2.3.1", - "resolved": "https://registry.npmjs.org/deprecation/-/deprecation-2.3.1.tgz", - "integrity": "sha512-xmHIy4F3scKVwMsQ4WnVaS8bHOx0DmVwRywosKhaILI0ywMDWPtBSku2HNxRvF7jtwDRsoEwYQSfbxj8b7RlJQ==" - }, "node_modules/dequal": { "version": "2.0.3", "dev": true, diff --git a/package.json b/package.json index f88274ea62d..61766861397 100644 --- a/package.json +++ b/package.json @@ -73,7 +73,6 @@ "@mat-datetimepicker/core": "11.0.3", "@ngx-translate/core": "^14.0.0", "@octokit/core": "^6.1.2", - "@octokit/rest": "^19.0.13", "@storybook/core-server": "^7.6.5", "angular-oauth2-oidc": "^13.0.1", "angular-oauth2-oidc-jwks": "^17.0.2", From d87e3bc8bc25f9cf7def8909dfb29fc89f0b8162 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 11:15:37 +0200 Subject: [PATCH 33/62] Simulate breaking change 20 --- package-lock.json | 99 ----------------------------------------------- package.json | 1 - 2 files changed, 100 deletions(-) diff --git a/package-lock.json b/package-lock.json index 25918e8712f..2ef3571d755 100644 --- a/package-lock.json +++ b/package-lock.json @@ -25,7 +25,6 @@ "@cspell/eslint-plugin": "^7.3.6", "@mat-datetimepicker/core": "11.0.3", "@ngx-translate/core": "^14.0.0", - "@octokit/core": "^6.1.2", "@storybook/core-server": "^7.6.5", "angular-oauth2-oidc": "^13.0.1", "angular-oauth2-oidc-jwks": "^17.0.2", @@ -8258,94 +8257,6 @@ "dev": true, "license": "ISC" }, - "node_modules/@octokit/auth-token": { - "version": "5.1.1", - "resolved": "https://registry.npmjs.org/@octokit/auth-token/-/auth-token-5.1.1.tgz", - "integrity": "sha512-rh3G3wDO8J9wSjfI436JUKzHIxq8NaiL0tVeB2aXmG6p/9859aUOAjA9pmSPNGGZxfwmaJ9ozOJImuNVJdpvbA==", - "engines": { - "node": ">= 18" - } - }, - "node_modules/@octokit/core": { - "version": "6.1.2", - "resolved": "https://registry.npmjs.org/@octokit/core/-/core-6.1.2.tgz", - "integrity": "sha512-hEb7Ma4cGJGEUNOAVmyfdB/3WirWMg5hDuNFVejGEDFqupeOysLc2sG6HJxY2etBp5YQu5Wtxwi020jS9xlUwg==", - "dependencies": { - "@octokit/auth-token": "^5.0.0", - "@octokit/graphql": "^8.0.0", - "@octokit/request": "^9.0.0", - "@octokit/request-error": "^6.0.1", - "@octokit/types": "^13.0.0", - "before-after-hook": "^3.0.2", - "universal-user-agent": "^7.0.0" - }, - "engines": { - "node": ">= 18" - } - }, - "node_modules/@octokit/endpoint": { - "version": "10.1.1", - "resolved": "https://registry.npmjs.org/@octokit/endpoint/-/endpoint-10.1.1.tgz", - "integrity": "sha512-JYjh5rMOwXMJyUpj028cu0Gbp7qe/ihxfJMLc8VZBMMqSwLgOxDI1911gV4Enl1QSavAQNJcwmwBF9M0VvLh6Q==", - "dependencies": { - "@octokit/types": "^13.0.0", - "universal-user-agent": "^7.0.2" - }, - "engines": { - "node": ">= 18" - } - }, - "node_modules/@octokit/graphql": { - "version": "8.1.1", - "resolved": "https://registry.npmjs.org/@octokit/graphql/-/graphql-8.1.1.tgz", - "integrity": "sha512-ukiRmuHTi6ebQx/HFRCXKbDlOh/7xEV6QUXaE7MJEKGNAncGI/STSbOkl12qVXZrfZdpXctx5O9X1AIaebiDBg==", - "dependencies": { - "@octokit/request": "^9.0.0", - "@octokit/types": "^13.0.0", - "universal-user-agent": "^7.0.0" - }, - "engines": { - "node": ">= 18" - } - }, - "node_modules/@octokit/openapi-types": { - "version": "22.2.0", - "resolved": "https://registry.npmjs.org/@octokit/openapi-types/-/openapi-types-22.2.0.tgz", - "integrity": "sha512-QBhVjcUa9W7Wwhm6DBFu6ZZ+1/t/oYxqc2tp81Pi41YNuJinbFRx8B133qVOrAaBbF7D/m0Et6f9/pZt9Rc+tg==" - }, - "node_modules/@octokit/request": { - "version": "9.1.3", - "resolved": "https://registry.npmjs.org/@octokit/request/-/request-9.1.3.tgz", - "integrity": "sha512-V+TFhu5fdF3K58rs1pGUJIDH5RZLbZm5BI+MNF+6o/ssFNT4vWlCh/tVpF3NxGtP15HUxTTMUbsG5llAuU2CZA==", - "dependencies": { - "@octokit/endpoint": "^10.0.0", - "@octokit/request-error": "^6.0.1", - "@octokit/types": "^13.1.0", - "universal-user-agent": "^7.0.2" - }, - "engines": { - "node": ">= 18" - } - }, - "node_modules/@octokit/request-error": { - "version": "6.1.4", - "resolved": "https://registry.npmjs.org/@octokit/request-error/-/request-error-6.1.4.tgz", - "integrity": "sha512-VpAhIUxwhWZQImo/dWAN/NpPqqojR6PSLgLYAituLM6U+ddx9hCioFGwBr5Mi+oi5CLeJkcAs3gJ0PYYzU6wUg==", - "dependencies": { - "@octokit/types": "^13.0.0" - }, - "engines": { - "node": ">= 18" - } - }, - "node_modules/@octokit/types": { - "version": "13.5.0", - "resolved": "https://registry.npmjs.org/@octokit/types/-/types-13.5.0.tgz", - "integrity": "sha512-HdqWTf5Z3qwDVlzCrP8UJquMwunpDiMPt5er+QjGzL4hqr/vBVY/MauQgS1xWxCDT1oMx1EULyqxncdCY/NVSQ==", - "dependencies": { - "@octokit/openapi-types": "^22.2.0" - } - }, "node_modules/@paperist/types-remark": { "version": "0.1.3", "dev": true, @@ -16572,11 +16483,6 @@ "tweetnacl": "^0.14.3" } }, - "node_modules/before-after-hook": { - "version": "3.0.2", - "resolved": "https://registry.npmjs.org/before-after-hook/-/before-after-hook-3.0.2.tgz", - "integrity": "sha512-Nik3Sc0ncrMK4UUdXQmAnRtzmNQTAAXmXIopizwZ1W1t8QmfJj+zL4OA2I7XPTPW5z5TDqv4hRo/JzouDJnX3A==" - }, "node_modules/bent": { "version": "7.3.12", "dev": true, @@ -36151,11 +36057,6 @@ "license": "MIT", "peer": true }, - "node_modules/universal-user-agent": { - "version": "7.0.2", - "resolved": "https://registry.npmjs.org/universal-user-agent/-/universal-user-agent-7.0.2.tgz", - "integrity": "sha512-0JCqzSKnStlRRQfCdowvqy3cy0Dvtlb8xecj/H8JFZuCze4rwjPZQOgvFvn0Ws/usCHQFGpyr+pB9adaGwXn4Q==" - }, "node_modules/universalify": { "version": "2.0.1", "dev": true, diff --git a/package.json b/package.json index 61766861397..44179a5bb86 100644 --- a/package.json +++ b/package.json @@ -72,7 +72,6 @@ "@cspell/eslint-plugin": "^7.3.6", "@mat-datetimepicker/core": "11.0.3", "@ngx-translate/core": "^14.0.0", - "@octokit/core": "^6.1.2", "@storybook/core-server": "^7.6.5", "angular-oauth2-oidc": "^13.0.1", "angular-oauth2-oidc-jwks": "^17.0.2", From d8fc788a61433c92f2169f445544bc4bc246b36e Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 11:16:37 +0200 Subject: [PATCH 34/62] Simulate breaking change 20 --- .github/workflows/pull-request.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 36fb383fe70..d661b07c1d1 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -500,6 +500,7 @@ jobs: echo "result ${{ contains(toJson(steps.pr-forbidden.*.result), 'failure') }}" determine-complexity: + needs: check-if-pr-is-approved outputs: level: ${{ steps.complexity.outputs.level }} runs-on: ubuntu-latest From 13670d2f8a2a4169d919ceeeb165faeaa778309d Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 11:20:17 +0200 Subject: [PATCH 35/62] Simulate breaking change 20 --- .github/workflows/pull-request.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index d661b07c1d1..6483efc051d 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -523,6 +523,10 @@ jobs: uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 with: fetch-depth: 1 + - name: print branch name + shell: bash + run: | + echo "branch name: ${{ env.BRANCH_NAME }}" - name: Tests - HxP Frontend uses: the-actions-org/workflow-dispatch@3133c5d135c7dbe4be4f9793872b6ef331b53bc7 # v4.0.0 with: From 683c0fd2ccb14f51e75529d56b326709be4d19d4 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 11:24:59 +0200 Subject: [PATCH 36/62] Simulate breaking change 20 --- .github/workflows/pull-request.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 6483efc051d..4981053cf96 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -123,6 +123,10 @@ jobs: - name: Get branch name uses: Alfresco/alfresco-build-tools/.github/actions/get-branch-name@76affd16a4dd9a440cf66bf42656b1d826e8dfc2 # v5.34.0 + - name: print branch name + shell: bash + run: | + echo "branch name: ${{ env.BRANCH_NAME }}" - name: Save commit message uses: Alfresco/alfresco-build-tools/.github/actions/get-commit-message@76affd16a4dd9a440cf66bf42656b1d826e8dfc2 # v5.34.0 From f3d30ef91a78115fc3518f36ffe6092f33de99bc Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 11:27:13 +0200 Subject: [PATCH 37/62] Simulate breaking change 20 --- .github/workflows/pull-request.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 4981053cf96..892c8da1c22 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -527,10 +527,7 @@ jobs: uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 with: fetch-depth: 1 - - name: print branch name - shell: bash - run: | - echo "branch name: ${{ env.BRANCH_NAME }}" + - uses: Alfresco/alfresco-build-tools/.github/actions/get-branch-name@482f25ec9cb6ac522d5c03b21b6f8987d3cdb4f0 # v5.29.2 - name: Tests - HxP Frontend uses: the-actions-org/workflow-dispatch@3133c5d135c7dbe4be4f9793872b6ef331b53bc7 # v4.0.0 with: From 9f93d30458d442c756b745b87179ec9b7a34f322 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 11:37:13 +0200 Subject: [PATCH 38/62] Fix branch name --- .github/workflows/pull-request.yml | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 892c8da1c22..82589df0747 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -121,12 +121,7 @@ jobs: fetch-depth: 0 - name: Get branch name - uses: Alfresco/alfresco-build-tools/.github/actions/get-branch-name@76affd16a4dd9a440cf66bf42656b1d826e8dfc2 # v5.34.0 - - - name: print branch name - shell: bash - run: | - echo "branch name: ${{ env.BRANCH_NAME }}" + uses: Alfresco/alfresco-build-tools/.github/actions/get-branch-name@a288b9efdaa50413573b2e130896d906478b8e50 # v5.31.0 - name: Save commit message uses: Alfresco/alfresco-build-tools/.github/actions/get-commit-message@76affd16a4dd9a440cf66bf42656b1d826e8dfc2 # v5.34.0 @@ -519,7 +514,7 @@ jobs: echo "level=major" >> $GITHUB_OUTPUT verify-downstream: - needs: [determine-complexity] + needs: determine-complexity if: ${{ needs.determine-complexity.outputs.level == 'major' }} runs-on: ubuntu-latest steps: @@ -527,7 +522,7 @@ jobs: uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 with: fetch-depth: 1 - - uses: Alfresco/alfresco-build-tools/.github/actions/get-branch-name@482f25ec9cb6ac522d5c03b21b6f8987d3cdb4f0 # v5.29.2 + - uses: Alfresco/alfresco-build-tools/.github/actions/get-branch-name@a288b9efdaa50413573b2e130896d906478b8e50 # v5.31.0 - name: Tests - HxP Frontend uses: the-actions-org/workflow-dispatch@3133c5d135c7dbe4be4f9793872b6ef331b53bc7 # v4.0.0 with: From 9803dcc77e5eea92bcad6b683bf34683e8eb17d2 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 12:30:25 +0200 Subject: [PATCH 39/62] Create an action for determine the complexity --- .../actions/determine-complexity/action.yml | 37 ++++++++ .../determine-pr-complexity.js | 92 +++++++++++++++++++ .github/workflows/pull-request.yml | 7 +- 3 files changed, 133 insertions(+), 3 deletions(-) create mode 100644 .github/actions/determine-complexity/action.yml create mode 100644 .github/actions/determine-complexity/determine-pr-complexity.js diff --git a/.github/actions/determine-complexity/action.yml b/.github/actions/determine-complexity/action.yml new file mode 100644 index 00000000000..52c3770395d --- /dev/null +++ b/.github/actions/determine-complexity/action.yml @@ -0,0 +1,37 @@ +name: Determine Complexity +description: 'Determine the complexity of the PR' + +inputs: + file-changed-limit: + description: 'The limit of files changed in the PR to throw a major complexity' + required: true + type: number + lines-changed-limit: + description: 'The limit of lines changed in the PR to throw a major complexity' + required: true + type: number + +runs: + using: "composite" + + steps: + - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 + - name: Determine complexity + uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1 + env: + file-changed-limit: ${{ inputs.file-changed-limit }} + line-changed-limit: ${{ inputs.lines-changed-limit }} + with: + script: | + console.log('Determine Complexity'); + console.log(`File changed limit: ${process.env.fileChangedLimit}`); + const determineComplexity = require('./.github/actions/determine-complexity/determine-pr-complexity.js'); + + determineComplexity({ + core, + github, + context, + fileChangedLimit: process.env.fileChangedLimit, + lineChangedLimit: process.env.lineChangedLimit + }); + diff --git a/.github/actions/determine-complexity/determine-pr-complexity.js b/.github/actions/determine-complexity/determine-pr-complexity.js new file mode 100644 index 00000000000..73f18951736 --- /dev/null +++ b/.github/actions/determine-complexity/determine-pr-complexity.js @@ -0,0 +1,92 @@ +/*! + * @license + * Copyright © 2005-2023 Hyland Software, Inc. and its affiliates. All rights reserved. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +async function getPRDetails(github, core, owner, repo, pull_number) { + core.info(`Fetching PR details`); + + const { data: files } = await github.pulls.listFiles({ + owner, + repo, + pull_number + }); + + core.info(`Fetched PR details: ${JSON.stringify(files)}`); + + let filesChanged = files.length; + let linesChanged = files.reduce((total, file) => total + file.additions + file.deletions, 0); + + let level = 'unknown'; + let packageName = 'unknown'; + let packagesAffected = new Set(); + for (let file of files) { + if (file.filename.startsWith('lib/core/')) { + if (file.filename.startsWith('lib/core/auth/')) { + level = 'extreme'; + } + level = 'major'; + packageName = 'core'; + packagesAffected.add(packageName); + break; + } else if (file.filename.startsWith('lib/extensions/')) { + level = 'major'; + packageName = 'extensions'; + packagesAffected.add(packageName); + + break; + } else { + level = 'minor'; + packagesAffected.add(packageName); + } + } + + if (level !== 'major') { + if (linesChanged > 100) { + level = 'major'; + } else if (linesChanged > 50) { + level = 'medium'; + } + } + + if (level !== 'major') { + if (filesChanged > 10) { + level = 'major'; + } else if (filesChanged > 5) { + level = 'medium'; + } + } + + return { + filesChanged, + linesChanged, + level: level, + packagesAffected: Array.from(packagesAffected) + }; +} + +module.exports = async ({ core, github, context, fileChangedLimit = 5, linesChangedLimit = 50 }) => { + const owner = context.repo.owner; + const repo = context.repo.repo; + const pull_number = context.payload.pull_request.number; + + core.info(`Getting PR details for ${owner}/${repo}#${pull_number}`); + core.info(`Limit for files changed: ${fileChangedLimit}`); + core.info(`Limit for lines changed: ${linesChangedLimit}`); + + const details = await getPRDetails(github, owner, repo, pull_number); + + core.info(`PR details: ${JSON.stringify(details)}`); +}; diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 82589df0747..f24f1c2119e 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -509,9 +509,10 @@ jobs: with: fetch-depth: 1 - name: Determine complexity - id: complexity - run: | - echo "level=major" >> $GITHUB_OUTPUT + uses: ./.github/actions/determine-complexity + with: + file-changed-limit: 10 + lines-changed-limit: 100 verify-downstream: needs: determine-complexity From ace533ce190c9fd3c036c12f6e513cbdba21677b Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 12:33:15 +0200 Subject: [PATCH 40/62] Create an action for determine the complexity --- .github/actions/determine-complexity/determine-pr-complexity.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/determine-complexity/determine-pr-complexity.js b/.github/actions/determine-complexity/determine-pr-complexity.js index 73f18951736..ba58f82a5f9 100644 --- a/.github/actions/determine-complexity/determine-pr-complexity.js +++ b/.github/actions/determine-complexity/determine-pr-complexity.js @@ -86,7 +86,7 @@ module.exports = async ({ core, github, context, fileChangedLimit = 5, linesChan core.info(`Limit for files changed: ${fileChangedLimit}`); core.info(`Limit for lines changed: ${linesChangedLimit}`); - const details = await getPRDetails(github, owner, repo, pull_number); + const details = await getPRDetails(github, core, owner, repo, pull_number); core.info(`PR details: ${JSON.stringify(details)}`); }; From 275ba3371e24db403dbf83d897215f20a797d4cc Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 12:36:59 +0200 Subject: [PATCH 41/62] Create an action for determine the complexity --- .github/actions/determine-complexity/determine-pr-complexity.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/determine-complexity/determine-pr-complexity.js b/.github/actions/determine-complexity/determine-pr-complexity.js index ba58f82a5f9..01756e8811b 100644 --- a/.github/actions/determine-complexity/determine-pr-complexity.js +++ b/.github/actions/determine-complexity/determine-pr-complexity.js @@ -18,7 +18,7 @@ async function getPRDetails(github, core, owner, repo, pull_number) { core.info(`Fetching PR details`); - const { data: files } = await github.pulls.listFiles({ + const { data: files } = await github.rest.pulls.listFiles({ owner, repo, pull_number From eded939c6d3dc1e28089b5adb7e017f2e8b2bcb6 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 12:40:13 +0200 Subject: [PATCH 42/62] Export level --- .github/actions/determine-complexity/determine-pr-complexity.js | 1 + .github/workflows/pull-request.yml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/actions/determine-complexity/determine-pr-complexity.js b/.github/actions/determine-complexity/determine-pr-complexity.js index 01756e8811b..a3665103891 100644 --- a/.github/actions/determine-complexity/determine-pr-complexity.js +++ b/.github/actions/determine-complexity/determine-pr-complexity.js @@ -89,4 +89,5 @@ module.exports = async ({ core, github, context, fileChangedLimit = 5, linesChan const details = await getPRDetails(github, core, owner, repo, pull_number); core.info(`PR details: ${JSON.stringify(details)}`); + core.setOutput('level', details.level); }; diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index f24f1c2119e..1184820a437 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -512,7 +512,7 @@ jobs: uses: ./.github/actions/determine-complexity with: file-changed-limit: 10 - lines-changed-limit: 100 + lines-changed-limit: 450 verify-downstream: needs: determine-complexity From 0d50846fb6fa6aef17f08c3d522e153322595fed Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 12:42:17 +0200 Subject: [PATCH 43/62] Change params --- .../actions/determine-complexity/determine-pr-complexity.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/actions/determine-complexity/determine-pr-complexity.js b/.github/actions/determine-complexity/determine-pr-complexity.js index a3665103891..7d5bae14620 100644 --- a/.github/actions/determine-complexity/determine-pr-complexity.js +++ b/.github/actions/determine-complexity/determine-pr-complexity.js @@ -16,16 +16,12 @@ */ async function getPRDetails(github, core, owner, repo, pull_number) { - core.info(`Fetching PR details`); - const { data: files } = await github.rest.pulls.listFiles({ owner, repo, pull_number }); - core.info(`Fetched PR details: ${JSON.stringify(files)}`); - let filesChanged = files.length; let linesChanged = files.reduce((total, file) => total + file.additions + file.deletions, 0); From cab5d2154869c918a3045a356092172ccaa458be Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 12:46:12 +0200 Subject: [PATCH 44/62] Rely on limit --- .../determine-pr-complexity.js | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/.github/actions/determine-complexity/determine-pr-complexity.js b/.github/actions/determine-complexity/determine-pr-complexity.js index 7d5bae14620..ab4e3b33310 100644 --- a/.github/actions/determine-complexity/determine-pr-complexity.js +++ b/.github/actions/determine-complexity/determine-pr-complexity.js @@ -30,9 +30,6 @@ async function getPRDetails(github, core, owner, repo, pull_number) { let packagesAffected = new Set(); for (let file of files) { if (file.filename.startsWith('lib/core/')) { - if (file.filename.startsWith('lib/core/auth/')) { - level = 'extreme'; - } level = 'major'; packageName = 'core'; packagesAffected.add(packageName); @@ -50,18 +47,10 @@ async function getPRDetails(github, core, owner, repo, pull_number) { } if (level !== 'major') { - if (linesChanged > 100) { + if (filesChanged > LIMIT_FILE_CHANGED) { level = 'major'; - } else if (linesChanged > 50) { - level = 'medium'; - } - } - - if (level !== 'major') { - if (filesChanged > 10) { + } else if (linesChanged > LIMIT_LINES_CHANGED) { level = 'major'; - } else if (filesChanged > 5) { - level = 'medium'; } } @@ -78,6 +67,9 @@ module.exports = async ({ core, github, context, fileChangedLimit = 5, linesChan const repo = context.repo.repo; const pull_number = context.payload.pull_request.number; + const LIMIT_FILE_CHANGED = fileChangedLimit; + const LIMIT_LINES_CHANGED = linesChangedLimit; + core.info(`Getting PR details for ${owner}/${repo}#${pull_number}`); core.info(`Limit for files changed: ${fileChangedLimit}`); core.info(`Limit for lines changed: ${linesChangedLimit}`); From 16c79cd7b83c9bd72117a69403e355802ca4b967 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 12:56:22 +0200 Subject: [PATCH 45/62] Rely on limit fix --- .github/actions/determine-complexity/action.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/actions/determine-complexity/action.yml b/.github/actions/determine-complexity/action.yml index 52c3770395d..cb0d932d33f 100644 --- a/.github/actions/determine-complexity/action.yml +++ b/.github/actions/determine-complexity/action.yml @@ -19,12 +19,11 @@ runs: - name: Determine complexity uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1 env: - file-changed-limit: ${{ inputs.file-changed-limit }} - line-changed-limit: ${{ inputs.lines-changed-limit }} + fileChangedLimit: ${{ inputs.file-changed-limit }} + lineChangedLimit: ${{ inputs.lines-changed-limit }} with: script: | console.log('Determine Complexity'); - console.log(`File changed limit: ${process.env.fileChangedLimit}`); const determineComplexity = require('./.github/actions/determine-complexity/determine-pr-complexity.js'); determineComplexity({ From 6d76497e6bde5cba3bd590ab873d9f4bfa12db02 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 13:16:57 +0200 Subject: [PATCH 46/62] Rely on limit fix 2 --- .github/actions/determine-complexity/action.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/actions/determine-complexity/action.yml b/.github/actions/determine-complexity/action.yml index cb0d932d33f..18cf30ad756 100644 --- a/.github/actions/determine-complexity/action.yml +++ b/.github/actions/determine-complexity/action.yml @@ -24,6 +24,8 @@ runs: with: script: | console.log('Determine Complexity'); + console.log('Lines changed limit: ' + process.env.lineChangedLimit); + console.log('Files changed limit: ' + process.env.fileChangedLimit); const determineComplexity = require('./.github/actions/determine-complexity/determine-pr-complexity.js'); determineComplexity({ From d556b8b87d941bdb907ae0e6ca1acea423023911 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 13:23:31 +0200 Subject: [PATCH 47/62] Rely on limit fix 4 --- .github/actions/determine-complexity/action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/actions/determine-complexity/action.yml b/.github/actions/determine-complexity/action.yml index 18cf30ad756..aca61fb28f8 100644 --- a/.github/actions/determine-complexity/action.yml +++ b/.github/actions/determine-complexity/action.yml @@ -24,8 +24,8 @@ runs: with: script: | console.log('Determine Complexity'); - console.log('Lines changed limit: ' + process.env.lineChangedLimit); console.log('Files changed limit: ' + process.env.fileChangedLimit); + console.log('Lines changed limit: ' + process.env.lineChangedLimit); const determineComplexity = require('./.github/actions/determine-complexity/determine-pr-complexity.js'); determineComplexity({ @@ -33,6 +33,6 @@ runs: github, context, fileChangedLimit: process.env.fileChangedLimit, - lineChangedLimit: process.env.lineChangedLimit + linesChangedLimit: process.env.lineChangedLimit }); From fca6f0d1fa3bf1640cb92cfd913dc36b1684efd5 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 13:26:42 +0200 Subject: [PATCH 48/62] Remove change on core --- .github/actions/determine-complexity/action.yml | 3 --- lib/core/src/lib/auth/oidc/auth.service.ts | 1 - 2 files changed, 4 deletions(-) diff --git a/.github/actions/determine-complexity/action.yml b/.github/actions/determine-complexity/action.yml index aca61fb28f8..c8f34b95d36 100644 --- a/.github/actions/determine-complexity/action.yml +++ b/.github/actions/determine-complexity/action.yml @@ -23,9 +23,6 @@ runs: lineChangedLimit: ${{ inputs.lines-changed-limit }} with: script: | - console.log('Determine Complexity'); - console.log('Files changed limit: ' + process.env.fileChangedLimit); - console.log('Lines changed limit: ' + process.env.lineChangedLimit); const determineComplexity = require('./.github/actions/determine-complexity/determine-pr-complexity.js'); determineComplexity({ diff --git a/lib/core/src/lib/auth/oidc/auth.service.ts b/lib/core/src/lib/auth/oidc/auth.service.ts index a6d3efe00ca..1007d051928 100644 --- a/lib/core/src/lib/auth/oidc/auth.service.ts +++ b/lib/core/src/lib/auth/oidc/auth.service.ts @@ -20,7 +20,6 @@ import { Observable } from 'rxjs'; /** * Provide authentication/authorization through OAuth2/OIDC protocol. - * simulate a change */ export abstract class AuthService { abstract onLogin: Observable; From 3839a736c77288159e1e2f9d71cbb60951b14563 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 13:31:50 +0200 Subject: [PATCH 49/62] Remove change on core --- lib/core/src/lib/auth/oidc/auth.service.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/core/src/lib/auth/oidc/auth.service.ts b/lib/core/src/lib/auth/oidc/auth.service.ts index 1007d051928..e7d113499c8 100644 --- a/lib/core/src/lib/auth/oidc/auth.service.ts +++ b/lib/core/src/lib/auth/oidc/auth.service.ts @@ -19,7 +19,7 @@ import { LoginOptions, TokenResponse } from 'angular-oauth2-oidc'; import { Observable } from 'rxjs'; /** - * Provide authentication/authorization through OAuth2/OIDC protocol. + * Provide authentication/authorization through OAuth2/OIDC protocol. 2 */ export abstract class AuthService { abstract onLogin: Observable; From 80b44deafb04acf4b95ebe65053dd96c1e4591f0 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 13:33:13 +0200 Subject: [PATCH 50/62] Remove change on core --- lib/core/src/lib/auth/oidc/auth.service.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/core/src/lib/auth/oidc/auth.service.ts b/lib/core/src/lib/auth/oidc/auth.service.ts index e7d113499c8..1007d051928 100644 --- a/lib/core/src/lib/auth/oidc/auth.service.ts +++ b/lib/core/src/lib/auth/oidc/auth.service.ts @@ -19,7 +19,7 @@ import { LoginOptions, TokenResponse } from 'angular-oauth2-oidc'; import { Observable } from 'rxjs'; /** - * Provide authentication/authorization through OAuth2/OIDC protocol. 2 + * Provide authentication/authorization through OAuth2/OIDC protocol. */ export abstract class AuthService { abstract onLogin: Observable; From daf8c684ee16ea135716d9f034378a9a40c25f68 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 13:35:56 +0200 Subject: [PATCH 51/62] Remove change on core --- lib/core/src/lib/auth/oidc/auth.service.ts | 72 +++++++++++----------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/lib/core/src/lib/auth/oidc/auth.service.ts b/lib/core/src/lib/auth/oidc/auth.service.ts index 1007d051928..4d44aa2d372 100644 --- a/lib/core/src/lib/auth/oidc/auth.service.ts +++ b/lib/core/src/lib/auth/oidc/auth.service.ts @@ -22,40 +22,40 @@ import { Observable } from 'rxjs'; * Provide authentication/authorization through OAuth2/OIDC protocol. */ export abstract class AuthService { - abstract onLogin: Observable; - - abstract onTokenReceived: Observable; - - /** Subscribe to whether the user has valid Id/Access tokens. */ - abstract authenticated$: Observable; - - /** Get whether the user has valid Id/Access tokens. */ - abstract authenticated: boolean; - - /** Subscribe to errors reaching the IdP. */ - abstract idpUnreachable$: Observable; - - /** - * Initiate the IdP login flow. - */ - abstract login(currentUrl?: string): Promise | void; - - abstract baseAuthLogin(username: string, password: string): Observable; - - /** - * Disconnect from IdP. - * - * @returns Promise may be returned depending on implementation - */ - abstract logout(): Promise | void; - - /** - * Complete the login flow. - * - * In browsers, checks URL for auth and stored state. Call this once the application returns from IdP. - * - * @returns Promise, resolve with stored state, reject if unable to reach IdP - */ - abstract loginCallback(loginOptions?: LoginOptions): Promise; - abstract updateIDPConfiguration(...args: any[]): void; + abstract onLogin: Observable; + + abstract onTokenReceived: Observable; + + /** Subscribe to whether the user has valid Id/Access tokens. */ + abstract authenticated$: Observable; + + /** Get whether the user has valid Id/Access tokens. */ + abstract authenticated: boolean; + + /** Subscribe to errors reaching the IdP. */ + abstract idpUnreachable$: Observable; + + /** + * Initiate the IdP login flow. + */ + abstract login(currentUrl?: string): Promise | void; + + abstract baseAuthLogin(username: string, password: string): Observable ; + + /** + * Disconnect from IdP. + * + * @returns Promise may be returned depending on implementation + */ + abstract logout(): Promise | void; + + /** + * Complete the login flow. + * + * In browsers, checks URL for auth and stored state. Call this once the application returns from IdP. + * + * @returns Promise, resolve with stored state, reject if unable to reach IdP + */ + abstract loginCallback(loginOptions?: LoginOptions): Promise; + abstract updateIDPConfiguration(...args: any[]): void; } From cd08a54e2423cf5958ace6c465de317668313dc0 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 13:38:54 +0200 Subject: [PATCH 52/62] Remove change on core --- .../determine-complexity/determine-pr-complexity.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/actions/determine-complexity/determine-pr-complexity.js b/.github/actions/determine-complexity/determine-pr-complexity.js index ab4e3b33310..5e0ee722b9e 100644 --- a/.github/actions/determine-complexity/determine-pr-complexity.js +++ b/.github/actions/determine-complexity/determine-pr-complexity.js @@ -62,13 +62,16 @@ async function getPRDetails(github, core, owner, repo, pull_number) { }; } +let LIMIT_FILE_CHANGED; +let LIMIT_LINES_CHANGED; + module.exports = async ({ core, github, context, fileChangedLimit = 5, linesChangedLimit = 50 }) => { const owner = context.repo.owner; const repo = context.repo.repo; const pull_number = context.payload.pull_request.number; - const LIMIT_FILE_CHANGED = fileChangedLimit; - const LIMIT_LINES_CHANGED = linesChangedLimit; + LIMIT_FILE_CHANGED = fileChangedLimit; + LIMIT_LINES_CHANGED = linesChangedLimit; core.info(`Getting PR details for ${owner}/${repo}#${pull_number}`); core.info(`Limit for files changed: ${fileChangedLimit}`); From db66db6046de44c767da972df8cc2e19b6672ca5 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 14:22:19 +0200 Subject: [PATCH 53/62] Remove change on core 2 --- .../determine-pr-complexity.js | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/.github/actions/determine-complexity/determine-pr-complexity.js b/.github/actions/determine-complexity/determine-pr-complexity.js index 5e0ee722b9e..3fb7aaa7540 100644 --- a/.github/actions/determine-complexity/determine-pr-complexity.js +++ b/.github/actions/determine-complexity/determine-pr-complexity.js @@ -15,7 +15,7 @@ * limitations under the License. */ -async function getPRDetails(github, core, owner, repo, pull_number) { +async function getPRDetails(github, core, owner, repo, pull_number, limitFileChanged, limitLinesChanged) { const { data: files } = await github.rest.pulls.listFiles({ owner, repo, @@ -47,9 +47,9 @@ async function getPRDetails(github, core, owner, repo, pull_number) { } if (level !== 'major') { - if (filesChanged > LIMIT_FILE_CHANGED) { + if (filesChanged > limitFileChanged) { level = 'major'; - } else if (linesChanged > LIMIT_LINES_CHANGED) { + } else if (linesChanged > limitLinesChanged) { level = 'major'; } } @@ -62,22 +62,16 @@ async function getPRDetails(github, core, owner, repo, pull_number) { }; } -let LIMIT_FILE_CHANGED; -let LIMIT_LINES_CHANGED; - module.exports = async ({ core, github, context, fileChangedLimit = 5, linesChangedLimit = 50 }) => { const owner = context.repo.owner; const repo = context.repo.repo; const pull_number = context.payload.pull_request.number; - LIMIT_FILE_CHANGED = fileChangedLimit; - LIMIT_LINES_CHANGED = linesChangedLimit; - core.info(`Getting PR details for ${owner}/${repo}#${pull_number}`); core.info(`Limit for files changed: ${fileChangedLimit}`); core.info(`Limit for lines changed: ${linesChangedLimit}`); - const details = await getPRDetails(github, core, owner, repo, pull_number); + const details = await getPRDetails(github, core, owner, repo, pull_number, fileChangedLimit, linesChangedLimit); core.info(`PR details: ${JSON.stringify(details)}`); core.setOutput('level', details.level); From 5c5e825b674ef9a402ab039b1c96f1cc8704b153 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 14:30:13 +0200 Subject: [PATCH 54/62] Remove change on core 3 --- .../determine-complexity/determine-pr-complexity.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/actions/determine-complexity/determine-pr-complexity.js b/.github/actions/determine-complexity/determine-pr-complexity.js index 3fb7aaa7540..f5a190a6e69 100644 --- a/.github/actions/determine-complexity/determine-pr-complexity.js +++ b/.github/actions/determine-complexity/determine-pr-complexity.js @@ -31,14 +31,15 @@ async function getPRDetails(github, core, owner, repo, pull_number, limitFileCha for (let file of files) { if (file.filename.startsWith('lib/core/')) { level = 'major'; - packageName = 'core'; - packagesAffected.add(packageName); + packagesAffected.add(file.filename.split('/')[2]); break; } else if (file.filename.startsWith('lib/extensions/')) { level = 'major'; - packageName = 'extensions'; - packagesAffected.add(packageName); - + packagesAffected.add(file.filename.split('/')[2]); + break; + } else if (file.filename.startsWith('lib/contetent-services/') || file.filename.startsWith('lib/process-services-cloud/')) { + level = 'minor'; + packagesAffected.add(file.filename.split('/')[2]); break; } else { level = 'minor'; From 9df84cc79786650431a6aeaf6a2c81251c235724 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Fri, 19 Jul 2024 15:26:26 +0200 Subject: [PATCH 55/62] Check new algoritm --- .../determine-pr-complexity.js | 33 +++++++++++++++++++ .github/workflows/pull-request.yml | 2 +- 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/.github/actions/determine-complexity/determine-pr-complexity.js b/.github/actions/determine-complexity/determine-pr-complexity.js index f5a190a6e69..a043658335f 100644 --- a/.github/actions/determine-complexity/determine-pr-complexity.js +++ b/.github/actions/determine-complexity/determine-pr-complexity.js @@ -15,6 +15,31 @@ * limitations under the License. */ +function determineComplexity(changedFiles, totalFilesChanged, totalLinesChanged, limitFileChanged, limitLinesChanged) { + let level = 'unknown'; + let packagesAffected = new Set(); + + // Determine packagesAffected and if the level should be major based on file paths + for (let filePath of changedFiles) { + if (filePath.startsWith('lib/core/') || filePath.startsWith('lib/extensions/')) { + level = 'major'; + packagesAffected.add(filePath.split('/')[2]); + } + } + + // Check if the number of files or lines changed exceeds limits + if (totalFilesChanged > limitFileChanged || totalLinesChanged > limitLinesChanged) { + level = 'major'; + } + + return { + filesChanged: totalFilesChanged, + linesChanged: totalLinesChanged, + level: level, + packagesAffected: Array.from(packagesAffected) // Convert Set to Array for the output + }; +} + async function getPRDetails(github, core, owner, repo, pull_number, limitFileChanged, limitLinesChanged) { const { data: files } = await github.rest.pulls.listFiles({ owner, @@ -22,6 +47,14 @@ async function getPRDetails(github, core, owner, repo, pull_number, limitFileCha pull_number }); + const complexity = determineComplexity( + files.map((file) => file.filename), + files.length, + files.reduce((total, file) => total + file.additions + file.deletions, 0), + limitFileChanged, + limitLinesChanged + ); + let filesChanged = files.length; let linesChanged = files.reduce((total, file) => total + file.additions + file.deletions, 0); diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 1184820a437..3bb3d8e3cda 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -512,7 +512,7 @@ jobs: uses: ./.github/actions/determine-complexity with: file-changed-limit: 10 - lines-changed-limit: 450 + lines-changed-limit: 340 verify-downstream: needs: determine-complexity From 94193a00959d7b9cb212954a3daa8678f2ff4f8b Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Tue, 23 Jul 2024 09:36:24 +0200 Subject: [PATCH 56/62] Handle js-api --- .../determine-pr-complexity.js | 44 ++----------------- 1 file changed, 3 insertions(+), 41 deletions(-) diff --git a/.github/actions/determine-complexity/determine-pr-complexity.js b/.github/actions/determine-complexity/determine-pr-complexity.js index a043658335f..9287c82c1b3 100644 --- a/.github/actions/determine-complexity/determine-pr-complexity.js +++ b/.github/actions/determine-complexity/determine-pr-complexity.js @@ -21,7 +21,7 @@ function determineComplexity(changedFiles, totalFilesChanged, totalLinesChanged, // Determine packagesAffected and if the level should be major based on file paths for (let filePath of changedFiles) { - if (filePath.startsWith('lib/core/') || filePath.startsWith('lib/extensions/')) { + if (filePath.startsWith('lib/core/') || filePath.startsWith('lib/extensions/') || filePath.startsWith('lib/js-api/')) { level = 'major'; packagesAffected.add(filePath.split('/')[2]); } @@ -47,7 +47,7 @@ async function getPRDetails(github, core, owner, repo, pull_number, limitFileCha pull_number }); - const complexity = determineComplexity( + const result = determineComplexity( files.map((file) => file.filename), files.length, files.reduce((total, file) => total + file.additions + file.deletions, 0), @@ -55,45 +55,7 @@ async function getPRDetails(github, core, owner, repo, pull_number, limitFileCha limitLinesChanged ); - let filesChanged = files.length; - let linesChanged = files.reduce((total, file) => total + file.additions + file.deletions, 0); - - let level = 'unknown'; - let packageName = 'unknown'; - let packagesAffected = new Set(); - for (let file of files) { - if (file.filename.startsWith('lib/core/')) { - level = 'major'; - packagesAffected.add(file.filename.split('/')[2]); - break; - } else if (file.filename.startsWith('lib/extensions/')) { - level = 'major'; - packagesAffected.add(file.filename.split('/')[2]); - break; - } else if (file.filename.startsWith('lib/contetent-services/') || file.filename.startsWith('lib/process-services-cloud/')) { - level = 'minor'; - packagesAffected.add(file.filename.split('/')[2]); - break; - } else { - level = 'minor'; - packagesAffected.add(packageName); - } - } - - if (level !== 'major') { - if (filesChanged > limitFileChanged) { - level = 'major'; - } else if (linesChanged > limitLinesChanged) { - level = 'major'; - } - } - - return { - filesChanged, - linesChanged, - level: level, - packagesAffected: Array.from(packagesAffected) - }; + return result; } module.exports = async ({ core, github, context, fileChangedLimit = 5, linesChangedLimit = 50 }) => { From cbc345437c0e8d87d4b60ac9b1932b878c016d69 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Tue, 23 Jul 2024 10:13:10 +0200 Subject: [PATCH 57/62] Revert test --- .../github/update/useme-to-test-restokit.js | 101 ++++-------------- 1 file changed, 20 insertions(+), 81 deletions(-) diff --git a/scripts/github/update/useme-to-test-restokit.js b/scripts/github/update/useme-to-test-restokit.js index 7cd042f238d..5472a11d757 100755 --- a/scripts/github/update/useme-to-test-restokit.js +++ b/scripts/github/update/useme-to-test-restokit.js @@ -16,93 +16,32 @@ const octokit = new Octokit({ } }); -async function getPRDetails(owner, repo, pull_number) { - const { data: files } = await octokit.pulls.listFiles({ - owner, - repo, - pull_number - }); - - let filesChanged = files.length; - let linesChanged = files.reduce((total, file) => total + file.additions + file.deletions, 0); - - let level = 'unknown'; - let packageName = 'unknown'; - let packagesAffected = new Set(); - for (let file of files) { - if (file.filename.startsWith('lib/core/')) { - if (file.filename.startsWith('lib/core/auth/')) { - level = 'extreme'; - } - level = 'major'; - packageName = 'core'; - packagesAffected.add(packageName); - break; - } else if (file.filename.startsWith('lib/extensions/')) { - level = 'major'; - packageName = 'extensions'; - packagesAffected.add(packageName); - - break; - } else { - level = 'minor'; - packagesAffected.add(packageName); - } - } - - if (level !== 'major') { - if (linesChanged > 100) { - level = 'major'; - } else if (linesChanged > 50) { - level = 'medium'; - } - } - - if (level !== 'major') { - if (filesChanged > 10) { - level = 'major'; - } else if (filesChanged > 5) { - level = 'medium'; - } - } - - return { - filesChanged, - linesChanged, - level: level, - packagesAffected: Array.from(packagesAffected) - }; -} - async function asyncCall() { const organization = 'alfresco'; - const owner = 'Alfresco'; - const repo = 'alfresco-ng2-components'; - const pull_number = '9957'; - - const changes = await getPRDetails(owner, repo, pull_number); - // const { data: availablePakages } = await octokit.rest.packages.getAllPackageVersionsForPackageOwnedByOrg({ - // package_type: 'npm', - // package_name: 'adf-core', - // org: organization - // }); + const { data: availablePakages } = await octokit.rest.packages.getAllPackageVersionsForPackageOwnedByOrg({ + package_type: 'npm', + package_name: 'adf-core', + org: organization + }); - // // console.log(availablePakages[0]) + // console.log(availablePakages[0]) - // availablePakages.push({ - // id: 123, - // name: '6.0.0-A.3', - // metadata: { package_type: 'npm' } - // }) - // availablePakages.push({ - // id: 222, - // name: '6.0.1', - // metadata: { package_type: 'npm' } - // }) + availablePakages.push({ + id: 123, + name: '6.0.0-A.3', + metadata: { package_type: 'npm' } + }); + availablePakages.push({ + id: 222, + name: '6.0.1', + metadata: { package_type: 'npm' } + }); - // const filteredReleasePkgs = availablePakages.filter( (item) => item.name.match('^[0-9]*.[0-9]*.[0-9]*.A.[0-9]*$') || item.name.match('^[0-9]*.[0-9]*.[0-9]*$') ) - // console.log(filteredReleasePkgs) + const filteredReleasePkgs = availablePakages.filter( + (item) => item.name.match('^[0-9]*.[0-9]*.[0-9]*.A.[0-9]*$') || item.name.match('^[0-9]*.[0-9]*.[0-9]*$') + ); + console.log(filteredReleasePkgs); // console.log('alpha') // const filteredAlphaPkgs = availablePakages.filter( (item) => item.name.match('^[0-9]*\.[0-9]*\.[0-9]*.A\.[0-9]\.[0-9]*$') ) From a7df8076fb917c2ea1c3f563ac77bff7ac13267d Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Tue, 23 Jul 2024 10:14:44 +0200 Subject: [PATCH 58/62] Revert test --- .../github/update/useme-to-test-restokit.js | 96 ++++++++++--------- 1 file changed, 50 insertions(+), 46 deletions(-) diff --git a/scripts/github/update/useme-to-test-restokit.js b/scripts/github/update/useme-to-test-restokit.js index 5472a11d757..0fb17506ff5 100755 --- a/scripts/github/update/useme-to-test-restokit.js +++ b/scripts/github/update/useme-to-test-restokit.js @@ -1,6 +1,7 @@ -const { Octokit } = require('@octokit/rest'); + +const { Octokit } = require("@octokit/rest"); const octokit = new Octokit({ - auth: '', + auth: "", userAgent: 'myApp v1.2.3', baseUrl: 'https://api.github.com', log: { @@ -8,61 +9,64 @@ const octokit = new Octokit({ info: () => {}, warn: console.warn, error: console.error - }, - request: { + }, + request: { agent: undefined, fetch: undefined, timeout: 0 - } -}); + } + }); -async function asyncCall() { - const organization = 'alfresco'; - const { data: availablePakages } = await octokit.rest.packages.getAllPackageVersionsForPackageOwnedByOrg({ - package_type: 'npm', - package_name: 'adf-core', - org: organization - }); + async function asyncCall() { + const organization = 'alfresco'; - // console.log(availablePakages[0]) + const { data: availablePakages } = await octokit.rest.packages.getAllPackageVersionsForPackageOwnedByOrg({ + package_type: 'npm', + package_name: 'adf-core', + org: organization + }); + + // console.log(availablePakages[0]) + + availablePakages.push({ + id: 123, + name: '6.0.0-A.3', + metadata: { package_type: 'npm' } + }) + availablePakages.push({ + id: 222, + name: '6.0.1', + metadata: { package_type: 'npm' } + }) + + const filteredReleasePkgs = availablePakages.filter( (item) => item.name.match('^[0-9]*.[0-9]*.[0-9]*.A.[0-9]*$') || item.name.match('^[0-9]*.[0-9]*.[0-9]*$') ) + console.log(filteredReleasePkgs) + + // console.log('alpha') + // const filteredAlphaPkgs = availablePakages.filter( (item) => item.name.match('^[0-9]*\.[0-9]*\.[0-9]*.A\.[0-9]\.[0-9]*$') ) + // console.log(filteredAlphaPkgs) - availablePakages.push({ - id: 123, - name: '6.0.0-A.3', - metadata: { package_type: 'npm' } - }); - availablePakages.push({ - id: 222, - name: '6.0.1', - metadata: { package_type: 'npm' } - }); - const filteredReleasePkgs = availablePakages.filter( - (item) => item.name.match('^[0-9]*.[0-9]*.[0-9]*.A.[0-9]*$') || item.name.match('^[0-9]*.[0-9]*.[0-9]*$') - ); - console.log(filteredReleasePkgs); - // console.log('alpha') - // const filteredAlphaPkgs = availablePakages.filter( (item) => item.name.match('^[0-9]*\.[0-9]*\.[0-9]*.A\.[0-9]\.[0-9]*$') ) - // console.log(filteredAlphaPkgs) + // const { data: info } = await octokit.rest.packages.getPackageForOrganization({ + // package_type: 'npm', + // package_name: 'adf-core', + // org: organization + // }); - // const { data: info } = await octokit.rest.packages.getPackageForOrganization({ - // package_type: 'npm', - // package_name: 'adf-core', - // org: organization - // }); + // console.log(info) - // console.log(info) + // const { data: infos } = await octokit.rest.packages.getPackageVersionForOrganization({ + // package_type: 'npm', + // package_name: 'adf-core', + // org: organization, + // package_version_id: 85591610 + // }); - // const { data: infos } = await octokit.rest.packages.getPackageVersionForOrganization({ - // package_type: 'npm', - // package_name: 'adf-core', - // org: organization, - // package_version_id: 85591610 - // }); + // console.log(infos) + + } - // console.log(infos) -} -asyncCall(); + asyncCall(); \ No newline at end of file From 53c8c35a2fd4bea47b385a61aae9c2c8a5b13e1c Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Tue, 23 Jul 2024 10:15:17 +0200 Subject: [PATCH 59/62] Revert simulation --- .../src/lib/app/models/application-instance.model.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/process-services-cloud/src/lib/app/models/application-instance.model.ts b/lib/process-services-cloud/src/lib/app/models/application-instance.model.ts index fe2af3693a7..792afa69459 100644 --- a/lib/process-services-cloud/src/lib/app/models/application-instance.model.ts +++ b/lib/process-services-cloud/src/lib/app/models/application-instance.model.ts @@ -49,6 +49,7 @@ export interface Descriptor { } export enum DescriptorCustomUIAuthFlowType { + CODE = 'CODE', IMPLICIT = 'IMPLICIT' } From d484201f9a72cc5e4d70fa5cb4e24d2cf3b6f9b8 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Tue, 23 Jul 2024 10:16:49 +0200 Subject: [PATCH 60/62] Revert simulation --- .github/workflows/pull-request.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 3bb3d8e3cda..3dfae67e687 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -153,7 +153,6 @@ jobs: DEVEL_FLAG: ${{ inputs.devel }} GH_TOKEN: ${{ github.token }} skip_check: "false" - if: false run: | if [ "${{ github.event_name }}" == "schedule" ] || [ "${{ github.actor }}" == "dependabot[bot]" ]; then echo -e "\033[32mci:force check can be skipped\033[0m" @@ -196,7 +195,6 @@ jobs: name: "Setup" runs-on: ubuntu-latest needs: [check-if-pr-is-approved, pre-checks] - if: false steps: - name: Checkout repository uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -217,7 +215,6 @@ jobs: name: "Unit tests: ${{ matrix.unit-tests.name }}" runs-on: ubuntu-latest needs: [setup] - if: false strategy: fail-fast: false # max-parallel: 4 @@ -252,7 +249,6 @@ jobs: name: "Lint" runs-on: ubuntu-latest needs: [setup] - if: false steps: - name: Checkout repository uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -268,7 +264,6 @@ jobs: name: "Build libs" runs-on: ubuntu-latest needs: [setup] - if: false steps: - name: Checkout repository uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -286,7 +281,6 @@ jobs: name: "e2e: storybook" needs: [build-libs, lint, unit-tests] runs-on: ubuntu-latest - if: false steps: - name: Checkout repository uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -306,7 +300,6 @@ jobs: name: "e2e: ${{ matrix.e2e-test.description }}" needs: [build-libs, lint, unit-tests] runs-on: ubuntu-latest - if: false strategy: fail-fast: false # max-parallel: 4 From fadb0bfb24f3488b3f9c7605acf7f6ee98f48ee4 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Tue, 23 Jul 2024 10:22:09 +0200 Subject: [PATCH 61/62] Use slack channel --- .github/workflows/pull-request.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 3dfae67e687..bf9ed182347 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -529,8 +529,8 @@ jobs: "use-local-adf": "${{ env.BRANCH_NAME }}", "notify-on-failure": true, "rp-trigger": "adf-to-hxp-test", - "slack-channel-id": "D056HA6MP6Y", - "slack-message-title": "ADF => HxP check\n🔴 Frontend e2e test failed" + "slack-channel-id": "C016SMNNL8L", + "slack-message-title": "ADF => HxP check\n🔴 Frontend e2e test failed on branch ${{ env.BRANCH_NAME }}" } token: ${{ secrets.ALFRESCO_BUILD_GH_TOKEN }} wait-for-completion: true From baa3dce64c3f923565e07b25613b2d9d06adf824 Mon Sep 17 00:00:00 2001 From: mauriziovitale Date: Tue, 23 Jul 2024 10:22:57 +0200 Subject: [PATCH 62/62] Start with a limit --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index bf9ed182347..3cb8e400058 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -505,7 +505,7 @@ jobs: uses: ./.github/actions/determine-complexity with: file-changed-limit: 10 - lines-changed-limit: 340 + lines-changed-limit: 400 verify-downstream: needs: determine-complexity