Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 when changing team view when viewing a problem description #3

Open
Benezivas opened this issue Oct 20, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@Benezivas
Copy link
Collaborator

Benezivas commented Oct 20, 2023

Minor bug, reproducible by simply opening a problem description and changing the team view.

@Benezivas Benezivas changed the title Changing from 404 when changing team view when viewing a problem description Oct 20, 2023
@Benezivas Benezivas added the bug Something isn't working label Oct 20, 2023
@ImogenBits
Copy link
Collaborator

This issue not only occurs when changing the team view, but in general whenever a URL is requested that contains "%2F" (URL encoded "/") and possibly some other special characters, but e.g. not %20 (URL encoded space). When navigating the UI this doesn't occur since we then aren't requesting these pages but are using the vue SPA mechanism and only modifying browser history entries.

I'm fairly certain that this is an encoding issue with some part of the stack in front of the docker containers. The 404 page is neither our web server's 404 (compare the page to the one you get when typing in a garbage url), nor the default nginx one. I'm guessing some part of the reverse proxy is improperly decoding and/or re-encoding the URL. Looking at the nginx logs the requests also seem to not make it to the docker containers at all. The problem also does not reproduce in any local setups.

A workaround is to just avoid names containing these special characters. Currently the only ones needed for this are the tournament and problem names since they will appear in problem URLs. E.g. renaming "WS 23/24" to "WS 23-24" or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants