You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just wanted to report what I think might be a mistake in using the PCN test data not only for testing, but also for validation. Shouldn't utils.data_loaders.DatasetSubset.TEST in the following rather be utils.data_loaders.DatasetSubset.VAL..?
Hi,
Thank you for your interest in our work. To have a fair comparisn with previous work on the PCN benchmark, the model is trained on the training set and validated on the test set as most previous work does.
Hi!
I just wanted to report what I think might be a mistake in using the PCN test data not only for testing, but also for validation. Shouldn't
utils.data_loaders.DatasetSubset.TEST
in the following rather beutils.data_loaders.DatasetSubset.VAL
..?SnowflakeNet/core/train_pcn.py
Lines 36 to 37 in 93e7151
Regards,
Lucas
The text was updated successfully, but these errors were encountered: