Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change language : Francais #18

Open
brazouck opened this issue May 5, 2020 · 5 comments
Open

Change language : Francais #18

brazouck opened this issue May 5, 2020 · 5 comments
Labels
developper questions related to developpement and implementation question Further information is requested

Comments

@brazouck
Copy link

brazouck commented May 5, 2020

Hello, I don't find where to modify the character sheet to change it to french, can you help me ? Thanks for the fantastic work

@Althea21
Copy link
Owner

Althea21 commented May 5, 2020

Bonjour :)

[Ça fait plaisir de voir le ruleset utilisé par des francophones, néanmoins je répondrai à ton message en anglais pour qu'il soit compréhensible par le plus grand nombre :) ]

All strings that needed to be translated are located within the ruleset in a single file : strings/strings_campaign2.xml

You can try to edit this file manually to translate what you need but know that this may cause some errors, particulary with a campaign created before you translate the file.

Different language modules are planned (french and spanish) but I didn't have the time yet to work on this feature properly.

If you need further help or encounter any error after translating, please report them here, I will fix them as soon as I can.

Thanks,
Althea

@Althea21 Althea21 added developper questions related to developpement and implementation question Further information is requested labels May 5, 2020
@Althea21 Althea21 closed this as completed Aug 7, 2020
@Rom1an
Copy link

Rom1an commented Apr 27, 2021

Hello,

I tried to modify the strings_campaign2.xml file in order to translate to french, but it seems that some of the functionalities are based on the values of the strings themselves rather than the string reference.
This is the case for the Profession for instance. When the profession name is translated, the Profession Panel does not show the profession related skills or branch.

This seems to be because the id of the profession is directly obtained by transforming the label into an id (function getIdFromLabel, line 65 og char_profession_detail.lua file) but I can of course be totally wrong.

By the while, I can translate everything to french and give you the resulting file. Sine I own the rule book in French, the term will be the same as in the official book.

@Althea21
Copy link
Owner

Althea21 commented May 7, 2021

Hi,

Could you send me your translated strings_campaign2.xml file (even if not complete for now, it'll help me to fix this asap) ?

As some of my players have a hard time in english I'm personaly interested in having a french module :)

Regards,
Althea

@Althea21 Althea21 reopened this May 7, 2021
@Rom1an
Copy link

Rom1an commented May 7, 2021

Hi,

Here is the file (work in progress).
strings_campaign2_fr.xml.txt

@Althea21
Copy link
Owner

Althea21 commented Dec 21, 2021

Hello there,

I've just published a new version (0.6.0) that should fix the profession combo bug when localized : https://github.com/Althea21/witcher_fg_ruleset/releases/

Please let me know if this issue can be close for now.

Regards,
Althea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developper questions related to developpement and implementation question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants