Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Social media sharing broken again #1336

Closed
BeritJanssen opened this issue Oct 31, 2024 · 4 comments
Closed

🐛 Social media sharing broken again #1336

BeritJanssen opened this issue Oct 31, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@BeritJanssen
Copy link
Collaborator

BeritJanssen commented Oct 31, 2024

Description

It seems that, again, X and Facebook have changed the format of their sharing links, and our current implementation is broken.

Screenshots

Hopefully following soon... please update this issue.

Reproduction URL

app.amsterdammusiclab.nl/tunetwins

Reproduction steps

1. Finish an experiment with sharing links
2. Click on a sharing button while being logged into the social media in question

Logs

No response

Browsers

No response

OS

No response

Additional context

No response

@BeritJanssen BeritJanssen added the bug Something isn't working label Oct 31, 2024
@Lia-JX-Li
Copy link
Collaborator

Lia-JX-Li commented Oct 31, 2024

截屏2024-10-29 17 28 21 截屏2024-10-24 11 42 46

The corresponding sharing interface looks like these now. The sharing link is still in there, but it seems not showing the score and other content. Also in X the link is doubled.

@BeritJanssen BeritJanssen added this to the Infrastructure milestone Nov 5, 2024
@drikusroor
Copy link
Contributor

I think it would also be a good idea if we would eventually refrain from using next-share, which is still in version 0.27 and hasn't been updated for a year. I briefly looked and react-share seems to be maintained regularly and supports many social media https://github.com/nygardk/react-share

@BeritJanssen
Copy link
Collaborator Author

BeritJanssen commented Nov 19, 2024

That's a really nice find! Hoping that the maintainers of this library will indeed continue their great work. I do wonder though, looking at the documentation, whether it will be possible to preset the share message for Facebook (this seems to only allow specification of hashtag?). I think this may be a Facebook limitation though, which we would probably run into anyway.

@drikusroor
Copy link
Contributor

Tested this on https://acc.amsterdammusiclab.nl/tunetwins and saw that it works as expected for Twitter at least. Facebook does now allow text anymore, see also nygardk/react-share#537 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants