Skip to content
This repository has been archived by the owner on Apr 19, 2022. It is now read-only.

PHP code is modified after beautify #9

Closed
kwyatt242 opened this issue Sep 13, 2016 · 4 comments
Closed

PHP code is modified after beautify #9

kwyatt242 opened this issue Sep 13, 2016 · 4 comments

Comments

@kwyatt242
Copy link

kwyatt242 commented Sep 13, 2016

Every time I beautify, I must go back and correct my code since beautify makes an "update" that breaks the app.

original -
$image=new Imagick();

after beautify -
$image=newImagick();

@kwyatt242
Copy link
Author

kwyatt242 commented Oct 11, 2016

Here is another scenario where the bug is evident -

original -
$usersTimezone=new DateTimeZone($userStatus['userTimezone']);
$l10nDate=new DateTime($msTimestamp);

after beautify -
$usersTimezone=newDateTimeZone($userStatus['userTimezone']);
$l10nDate=newDateTime($msTimestamp);

I don't want to assume it does this with anything that has the'new' keyword, but so far, that seems to be the case.

@kwyatt242 kwyatt242 changed the title JS code is modified after beautify PHP code is modified after beautify Oct 12, 2016
@kwyatt242
Copy link
Author

I updated the ACE components hoping for a fix but it made no difference.
https://github.com/Codiad/Codiad/wiki/Tutorial:-How-to-manually-upgrade-to-latest-ACE-version

@Andr3as
Copy link
Owner

Andr3as commented Oct 17, 2016

This plugin uses its own version (file) of the necessary ace extension because of some dirty fixes. There is still no update of the original extension (file) since the initial commit of this plugin.

I created a dirty fix (7d29473) for your problem, but I'm not happy with it.

@Andr3as
Copy link
Owner

Andr3as commented Oct 17, 2016

See #10 for further developments.

@Andr3as Andr3as closed this as completed Oct 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants