-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: future deprecation of macros CONTRACT,ACTION,TABLE #133
Comments
Pros: I like the ease of them vs having to write/remember the expanded versions. Cons: Pretty clearly problematic from the issues listed above I sent this ticket to the antelope dev chat so we can open up some discussion about them and see what directions should be taken. |
In addition to the more explicit issues described above, I'd be in favor of one way to do things just for consistency's sake. A developer might be familiar with one style and that means the other style can be confusing to read. I'd also like to put |
Deprecation will be announced in upcoming CDT v4.0.0 release |
@ericpassmore Should we close this as wontfix? |
Some of the current documentation and code examples reference using the macros, these should be changed prior to deprecation. |
Based on the experience with:
Additionally, macros are no able to handle:
[[eosio::on_notify("*::transfer")]]
As a developer looking at various code examples and seeing these macros, seems like it would cause more confusion and unclear direction on how to implement a proper smart contract.
Since there are still developers using Macros currently, would be best to announce a deprecation notice and later on at a later major release a removal.
The text was updated successfully, but these errors were encountered: