From 2a93dd057d41ecbf268c08981a80210d2bf940db Mon Sep 17 00:00:00 2001 From: Alexander Song Date: Fri, 17 Jan 2025 10:12:04 -0800 Subject: [PATCH] add notes to notebook --- .../examples/tracer.ipynb | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/python/openinference-instrumentation/examples/tracer.ipynb b/python/openinference-instrumentation/examples/tracer.ipynb index 5d56628a5..082411427 100644 --- a/python/openinference-instrumentation/examples/tracer.ipynb +++ b/python/openinference-instrumentation/examples/tracer.ipynb @@ -1,5 +1,30 @@ { "cells": [ + { + "cell_type": "markdown", + "metadata": {}, + "source": [ + "Notes:\n", + "\n", + "- imagine `phoenix.otel.register` returns `OpenInferenceTracerProvider`\n", + "- imagine there is an `@agent` decorator that behaves the same as `@chain`\n", + "- imagine decorators can be also be used from a particular tracer with `@tracer.chain`\n", + "- import paths will change\n", + "\n", + "\n", + "Proposed imports:\n", + "\n", + "```python\n", + "from openinference.semconv.trace import (\n", + " get_input_value_and_mime_type,\n", + " get_openinference_span_kind,\n", + " get_output_value_and_mime_type,\n", + " get_tool_attributes,\n", + ")\n", + "from openinference.instrumentation import tool, chain, OpenInferenceTracerProvider\n", + "```" + ] + }, { "cell_type": "code", "execution_count": 1,