From 05b3e7b5f46dfd3390d36ef588e4b4dd7d413abc Mon Sep 17 00:00:00 2001 From: Parker Stafford Date: Tue, 30 Apr 2024 13:29:46 -0700 Subject: [PATCH] update workflows to remove lint from build / test --- .github/workflows/main.yml | 23 ++++++++++++++++------- src/Points.tsx | 10 +++++----- 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 6f9b6f24..1bc4e587 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,9 +1,24 @@ name: CI on: [push] jobs: + ci: + name: Lint TypeScript + runs-on: ubuntu-latest + steps: + - name: Checkout Repository + uses: actions/checkout@v3 + - name: Set up Nodejs + uses: actions/setup-node@v3 + with: + node-version: 18 + - name: Install deps and build (with cache) + uses: bahmutov/npm-install@v1 + - name: Lint + run: yarn lint + - name: Prettier + run: yarn prettier:check build: name: Build, lint, and test on Node ${{ matrix.node }} and ${{ matrix.os }} - runs-on: ${{ matrix.os }} strategy: matrix: @@ -22,12 +37,6 @@ jobs: - name: Install deps and build (with cache) uses: bahmutov/npm-install@v1 - - name: Lint - run: yarn lint - - - name: Prettier - run: yarn prettier:check - - name: Test run: yarn test --ci --coverage --maxWorkers=2 diff --git a/src/Points.tsx b/src/Points.tsx index 1978548e..fda49e3b 100644 --- a/src/Points.tsx +++ b/src/Points.tsx @@ -208,15 +208,15 @@ export function Points({ { + onPointerUp={e => { if (e.intersections) { const instanceIds = e.intersections - .map((e) => e?.instanceId) + .map(e => e?.instanceId) .filter((i): i is NonNullable => i != null); // Multi click onPointsClicked && - onPointsClicked(instanceIds.map((i) => data[i])); + onPointsClicked(instanceIds.map(i => data[i])); // Single click instanceIds.length > 0 && @@ -224,10 +224,10 @@ export function Points({ onPointClicked(data[instanceIds[0]]); } }} - onPointerOver={(e) => { + onPointerOver={e => { if (e.intersections) { const instanceIds = e.intersections - .map((e) => e?.instanceId) + .map(e => e?.instanceId) .filter((i): i is NonNullable => i != null); // Single instance callback