Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: <br> should not just get stripped when indexing, but converted into a line break #41196

Open
gibrown opened this issue Jan 20, 2025 · 1 comment
Labels
[Feature] Search For all things related to Search [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] Auto-allocated [Status] Search Index Change Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@gibrown
Copy link
Member

gibrown commented Jan 20, 2025

Impacted plugin

Jetpack

Quick summary

When indexing text we strip html (and do a bit of preprocessing).

It looks like we've missed converting
(and probably
) into a new line.

Example:

WPCOM: oliverklicker2014<br>Email: oliverklicker@gmail.com

Is matching on "oliverklicker201" but not "oliverklicker2014".

That appears to be getting indexed as:

Oliver KlickerWPCOM: oliverklicker2014Email:

It is also a little odd that it isn't matching. Maybe due to the max number of chars for the search as you type edgengram parsing?

Steps to reproduce

This example can be tested on blog_id 142211303

Site owner impact

Fewer than 20% of the total website/platform users

Severity

Moderate

What other impact(s) does this issue have?

No response

If a workaround is available, please outline it here.

No response

Platform (Simple and/or Atomic)

No response

@gibrown gibrown added [Feature] Search For all things related to Search [Status] Search Index Change [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Jan 20, 2025
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low labels Jan 20, 2025
Copy link
Contributor

This issue could use some more labels, to help prioritize and categorize our work. Could you please add at least a [Type], a [Feature], and a [Pri] label?

@jeherve jeherve added Triaged and removed Needs triage Ticket needs to be triaged labels Jan 21, 2025
@jeherve jeherve moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] Auto-allocated [Status] Search Index Change Triaged [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests

3 participants