From d4b85d571396425f08f0fdd497244734c8d8dcf0 Mon Sep 17 00:00:00 2001 From: Yael Rubinstein Date: Wed, 27 Jul 2022 22:33:01 -0700 Subject: [PATCH 1/2] Updates Locked Plus section info label text in Profile screen --- podcasts/PlusLockedInfoView.swift | 20 +++++++++++++++++--- podcasts/Strings+Generated.swift | 2 ++ podcasts/en.lproj/Localizable.strings | Bin 355920 -> 356162 bytes 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/podcasts/PlusLockedInfoView.swift b/podcasts/PlusLockedInfoView.swift index 45eb4aee8b..7b09e1358b 100644 --- a/podcasts/PlusLockedInfoView.swift +++ b/podcasts/PlusLockedInfoView.swift @@ -7,7 +7,12 @@ protocol PlusLockedInfoDelegate: AnyObject { } class PlusLockedInfoView: ThemeableView { - weak var delegate: PlusLockedInfoDelegate? + weak var delegate: PlusLockedInfoDelegate? { + didSet{ + setInfoLabelText() + } + } + @IBOutlet var contentView: ThemeableView! { didSet { contentView.style = .primaryUi01 @@ -23,7 +28,7 @@ class PlusLockedInfoView: ThemeableView { @IBOutlet var infoLabel: ThemeableLabel! { didSet { infoLabel.style = .primaryText02 - infoLabel.text = L10n.plusPromoParagraph + setInfoLabelText() } } @@ -37,7 +42,7 @@ class PlusLockedInfoView: ThemeableView { @IBOutlet var learnMoreButton: ThemeableUIButton! { didSet { learnMoreButton.style = .primaryInteractive01 - learnMoreButton.setTitle(L10n.learnMore, for: .normal) + learnMoreButton.setTitle(L10n.plusMarketingLearnMoreButton, for: .normal) } } @@ -75,4 +80,13 @@ class PlusLockedInfoView: ThemeableView { let source: PlusUpgradeViewSource = delegate?.displaySource ?? .unknown NavigationManager.sharedManager.showUpsellView(from: displayingVC, source: source) } + + private func setInfoLabelText() { + switch delegate?.displaySource { + case .profile: + infoLabel.text = L10n.profileHelpSupport + default: + infoLabel.text = L10n.plusPromoParagraph + } + } } diff --git a/podcasts/Strings+Generated.swift b/podcasts/Strings+Generated.swift index 40fa82915b..590c45c293 100644 --- a/podcasts/Strings+Generated.swift +++ b/podcasts/Strings+Generated.swift @@ -1550,6 +1550,8 @@ internal enum L10n { internal static var preview: String { return L10n.tr("Localizable", "preview") } /// Profile internal static var profile: String { return L10n.tr("Localizable", "profile") } + /// Help support Pocket Casts by upgrading your account + internal static var profileHelpSupport: String { return L10n.tr("Localizable", "profile_help_support") } /// App last refreshed %1$@ internal static func profileLastAppRefresh(_ p1: Any) -> String { return L10n.tr("Localizable", "profile_last_app_refresh", String(describing: p1)) diff --git a/podcasts/en.lproj/Localizable.strings b/podcasts/en.lproj/Localizable.strings index 65bca3629ff9a7b6077b5afab957fe19bee14664..b900e5ee2f3cc241c96525d98d4c0889a9000067 100644 GIT binary patch delta 142 zcmca`NA%D=(S{br7N!>F7M3lnCXV7x4EYQx43!KDKspUb1~B9>lrj`gpZJbNbh5!w zHvVFUREA`R5{68mf;46?h(&8CF!5oGHhIoczpy~o3%x5TKD48Drh*^{yNoe}U fh0OBINeq>fFU#mp-e)W@y}^`KWV@FmE1NC==ddQC delta 30 mcmX?fPxQha(S{br7N!>F7M3lnCXUk|_^@(qH*jJV(ggs(5DI<( From caa868d45d85f34f6870b5e64952ea32d3832b6c Mon Sep 17 00:00:00 2001 From: Yael Rubinstein Date: Wed, 27 Jul 2022 22:59:00 -0700 Subject: [PATCH 2/2] Fixing Danger --- podcasts/PlusLockedInfoView.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/podcasts/PlusLockedInfoView.swift b/podcasts/PlusLockedInfoView.swift index 7b09e1358b..bf43f7ce2f 100644 --- a/podcasts/PlusLockedInfoView.swift +++ b/podcasts/PlusLockedInfoView.swift @@ -8,7 +8,7 @@ protocol PlusLockedInfoDelegate: AnyObject { class PlusLockedInfoView: ThemeableView { weak var delegate: PlusLockedInfoDelegate? { - didSet{ + didSet { setInfoLabelText() } }