Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Set .Context.Operation.Id, not only parent-child relationships #4

Open
SergeyKanzhelev opened this issue Nov 20, 2018 · 8 comments
Open

Comments

@SergeyKanzhelev
Copy link

I'd suggest to set .Context.Operation.Id across entire distributed trace so missing telemetry will not break a chain of execution and end-to-end view will be rendered successfully.

@SLdragon
Copy link
Contributor

Hi, @SergeyKanzhelev
Do you mean we need to set Operation Id to the correlationId in the logs?

@SergeyKanzhelev
Copy link
Author

Yes. This will enable transaction view in Application Insights UI

@SLdragon
Copy link
Contributor

OK, i know, thanks

@SLdragon
Copy link
Contributor

Fixed: #8

@SergeyKanzhelev
Copy link
Author

@SLdragon I don't see it fixed in that PR. Please set Operation.Id explicitly. You may be lucky by relying on this issue: https://github.com/Microsoft/ApplicationInsights-Home/issues/237

@SLdragon
Copy link
Contributor

Hi, @SergeyKanzhelev , maybe i misunderstood your suggestion, do you mean I also need to add this:
dependencyTelemetry.Context.Operation.Id = correlationId;
We have already set dependencyTelemetry.Id = correlationId , why we also need to set this?

@SergeyKanzhelev
Copy link
Author

dependencyTelemetry.Context.Operation.Id = correlationId refer to the ID of the overall transaction. dependencyTelemetry.Id = correlationId refer to the ID of this specific call. All events of the distributed trace should have the same value in .Context.Operation.Id so they can be correlated.

@SLdragon
Copy link
Contributor

SLdragon commented Dec 4, 2018

Thanks @SergeyKanzhelev, I created another pull request to fix this issue, you can have a look. #9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants