diff --git a/.github/workflows/_reusable-eng-tools-test.yaml b/.github/workflows/_reusable-eng-tools-test.yaml index d0aa84d636dc0..5f069ba10b746 100644 --- a/.github/workflows/_reusable-eng-tools-test.yaml +++ b/.github/workflows/_reusable-eng-tools-test.yaml @@ -53,12 +53,12 @@ jobs: working-directory: ./eng/tools/${{ inputs.package }} - run: npm run lint - if: ${{ github.event.inputs.lint == 'true' }} + if: inputs.lint == true shell: pwsh working-directory: ./eng/tools/${{ inputs.package }} - run: npm run prettier - if: ${{ github.event.inputs.prettier == 'true' }} + if: inputs.prettier == true shell: pwsh working-directory: ./eng/tools/${{ inputs.package }} diff --git a/eng/tools/specs-model/tsconfig.json b/eng/tools/specs-model/tsconfig.json index 24ff1fb5e4679..cc02542745f9d 100644 --- a/eng/tools/specs-model/tsconfig.json +++ b/eng/tools/specs-model/tsconfig.json @@ -1,7 +1,7 @@ { "extends": [ "../tsconfig.json", - // [strictest] + // [strictest], but see the comment inside the extended file. "../tsconfig_strictest.json" ], "compilerOptions": { @@ -10,7 +10,7 @@ "lib": ["ES2022"], // checkJS is set to true by [strictest] but we need to disable it to avoid this [build failure]. - // We don't need it anyway, as all sources are in JS except the cmd entry-point. + // We don't need it anyway, as all sources are in .js except the 3-line cmd entry-point. // https://www.typescriptlang.org/tsconfig/#checkJs "checkJs": false }