Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create script to process SDK breaking change suppression files #9320

Closed
raych1 opened this issue Nov 4, 2024 · 2 comments
Closed

Create script to process SDK breaking change suppression files #9320

raych1 opened this issue Nov 4, 2024 · 2 comments
Assignees
Labels
Automation Tool Central-EngSys This issue is owned by the Engineering System team. Mgmt-Sdk-Release-Revamp

Comments

@raych1
Copy link
Member

raych1 commented Nov 4, 2024

What does the script do?

  • Identify the suppression file based on the spec PR or based on the spec path
  • Load the suppression file
  • Label the spec PR based on the suppression content
@raych1 raych1 added Automation Tool Central-EngSys This issue is owned by the Engineering System team. labels Nov 4, 2024
@raych1 raych1 self-assigned this Nov 4, 2024
@JackTn
Copy link
Member

JackTn commented Nov 18, 2024

---
title: Update Sdk-[language]-Suppressions Labels
---
flowchart TD
    A[Get PR File Changes] -- Filter by sdkSuppressionsFileName --> B(Get Suppression Files)
    B --> C{ Has Suppressions Files}
    B -- Has no Suppressions Files --> End
    C --> C1(Load PR head&base suppression content)
    C1 --> C2{Validate Header Content}
    C2 -- Validate Error --> End
    C2 -- Validate Success --> C4(Parse Suppression Files & Get SDKNames)
    C4 --> C5{Header is empty & Base has sdk}
    C5 --> C6(Return baseSdksWithSuppressions's SDKNames)
    C4 --> C7{Both Base & Header is empty}
    C7 --> C8(Return Empty sdkNames)
    C4 --> C9{Header is not empty}
    C9 --> C10( diff with suppression content denpends on package, breaking-changes)
    C10 --> C11( Return diff SDKNames)
    C11 --> F(Get corresponding Label By SDKNames)
    F --> F1{sdkNames = 0}
    F1 --> F9{no present labels exist}
    F9 --> End
    F1 --> F5{present labels exist}
    F5 --> F3(Remove Exist Label)
    F --> F2{sdkNames > 0 }
    F2 --> F6{present labels exist}
    F2 --> F7{present labels not exist}
    F6 --> F4(update labels without present lables)
    F7 --> F8(update labels)
    F3 --> End
    F4 --> End
    F8 --> End
Loading

@raych1 raych1 moved this from 🤔 Triage to 🐝 Dev in Azure SDK EngSys 🚢🎉 Nov 26, 2024
@raych1 raych1 moved this from Backlog to In Progress in API to SDK automation Nov 26, 2024
@raych1 raych1 moved this from 🐝 Dev to 🔬 Dev in PR in Azure SDK EngSys 🚢🎉 Dec 10, 2024
@raych1
Copy link
Member Author

raych1 commented Jan 7, 2025

This is the PR in review state

@maririos maririos closed this as completed Jan 9, 2025
@github-project-automation github-project-automation bot moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚢🎉 Jan 9, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in API to SDK automation Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Tool Central-EngSys This issue is owned by the Engineering System team. Mgmt-Sdk-Release-Revamp
Projects
Status: Done
Archived in project
Development

No branches or pull requests

3 participants