Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MONITOR-SPEC-PR] Breaking change exists in parts of languages, might caused by emitter/pipeline bugs #9542

Open
jianingwang123 opened this issue Dec 16, 2024 · 6 comments

Comments

@jianingwang123
Copy link

jianingwang123 commented Dec 16, 2024

section1:
https://github.com/Azure/azure-rest-api-specs/pull/31830/checks?check_run_id=34400107656
Description:
Breaking changes for java:
The files changed no related removals, and no breaking changes in other languages.
Image

section2:
go:
https://github.com/Azure/azure-rest-api-specs/pull/31834/checks?check_run_id=34459936819
js:
https://github.com/Azure/azure-rest-api-specs/pull/31834/checks?check_run_id=34459938642
Description:
The files changed no related removals, and no breaking changes in other languages.
Image
Image

section3:
python:
https://github.com/Azure/azure-rest-api-specs/pull/31905/checks?check_run_id=34515118075
Description:
The files changed no related removals, and no breaking changes in other languages.
Image

@wanlwanl
Copy link
Member

@XiaofeiCao
Could you take a look it why it has breaking changes?

https://github.com/Azure/azure-rest-api-specs/pull/31830/checks?check_run_id=34400107656
Description:
Breaking changes for java:
The files changed no related removals, and no breaking changes in other languages.

@wanlwanl
Copy link
Member

wanlwanl commented Dec 25, 2024

@jianingwang123 for section 2:
look like this pr is still in review, the breaking change related label is still there. you can keep monitoring this pr.
Different languages might have their own breaking changes due to new version of emitters.
As you can see, emitter owner already comment in this pr, so you don't need to worry about this pr.

@wanlwanl
Copy link
Member

@ChenxiJiang333
Could you take a look, is abnormal
section3:
python:
https://github.com/Azure/azure-rest-api-specs/pull/31905/checks?check_run_id=34515118075
Description:
The files changed no related removals, and no breaking changes in other languages.

@wanlwanl wanlwanl changed the title [MONITOR-SPEC-PR] This breaking change may require attention [MONITOR-SPEC-PR] Breaking change exists in parts of languages, might caused by emitter/pipeline bugs Dec 25, 2024
@wanlwanl wanlwanl assigned v-hongli1 and unassigned XiaofeiCao Dec 25, 2024
@ChenxiJiang333
Copy link
Member

@ChenxiJiang333 Could you take a look, is abnormal section3: python: https://github.com/Azure/azure-rest-api-specs/pull/31905/checks?check_run_id=34515118075 Description: The files changed no related removals, and no breaking changes in other languages.

This breaking change is caused by codegen upgrade and would be resolved by adding directives .

@wanlwanl
Copy link
Member

@XiaofeiCao Could you take a look it why it has breaking changes?

https://github.com/Azure/azure-rest-api-specs/pull/31830/checks?check_run_id=34400107656 Description: Breaking changes for java: The files changed no related removals, and no breaking changes in other languages.

@v-hongli1 could you take a look?

@Azure Azure deleted a comment from wanlwanl Jan 23, 2025
@v-hongli1
Copy link
Member

@wanlwanl
Compared with the stable version package-2022-06-15-java, myworkbooks_API.json has been removed from the package-2024-08-01-only, which is theoretically a breaking change for the service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

5 participants