-
Notifications
You must be signed in to change notification settings - Fork 393
Where is the spec for "pack"/starting with pack writing tutorial? and some more pack writing questions #527
Comments
Hey! There’s a few questions here so I’ll try to answer them separately.
|
Thanks
Thoughts? insights? I might be missing lots of things, as I"m new to this codebase |
Nope, that summarizes the situation fairly well. :) Are you looking to choose between minor/patch releases of the programming language, or the major release? I believe either approach may have entirely different approaches to the problem, most notably being that
This has been something I've been pondering as well, so any feedback or input on this problem is greatly appreciated. |
In some ecosystem (e.g node.js for example) major versions are the same workflow basically, but even if not (And I don't know if go 1 is in use in new projects, and if go community has a convention of using version file in the repo to help multi language version detection tools like nvm/ pyenv) enough Templating can handle that. That being said, I was thinking minor/patch versions (in python for example, new language features can be introduced in minor version e.g 3.6 has new features over 3.5) About draft create:
|
Go 2 isn't out yet. I was just using it as a hypothetical question. :) My only concern going forward is now that means we need to source Docker images that support all releases of every programming language going forward. Taking a look at library/python it only supports 3.4 to 3.7, and we'd really prefer to be on the "default" images providing support for those language stacks rather than supporting that own infrastructure. Given that constraint I'm not sure it's really worth the effort to allow this form of customization, but I'm still interested in hearing about the use cases this would solve. |
Actually I don't think this would need to source multiple docker files. just a simple template in the dockerfile, changing the base "from" , I can understand why this would be problematic to support . For me at least this limits usability of draft only for new projects, while beginning them, and not to help dockerizing my existing projects. Seems draft current main use case is the first. And if I would want something else, I should probably add a custom repo (given the limitations raised in #509 not sure how that would behave) Thanks for the responsiveness and helpful attitude |
No problem! It was nice to pick your brain on this proposal. The good news is that we haven't released v1.0 yet and we plan to get
Yeah in regards to the criticism around |
Where is the spec for "pack" Couldn't find one in the docs.
I noticed some packs (python for example) have a detect script, while others (javascript) don't . Should I add one in a PR? when is the "detect" being used"
As far as I can tell from current packs they don't support multiple language versions, but take latest (python) or latest LTS (node.js) since there are common idioms indicating language version (.python-version, .nvmrc, .node-version) we can detect language version and use the correct DockerFile FROM clause . Would a pr in that direction would be a good idea?
The text was updated successfully, but these errors were encountered: