Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

rename --config/-f flag on draft init #679

Open
michelleN opened this issue Apr 19, 2018 · 3 comments
Open

rename --config/-f flag on draft init #679

michelleN opened this issue Apr 19, 2018 · 3 comments

Comments

@michelleN
Copy link
Contributor

#670 adds a flag on draft init that allows you to pass a toml file indicating which plugins and pack repositories you'd like to add/override when setting up draft. This makes it easier for orgs/teams that want to use custom plugins or their own draft pack repositories and don't want to do the manual draft plugin install and draft pack-repo add steps for each item.

--config/-f was put in for a quick mvp release of that functionality but we may want to think about if that is the right name for the flag at all. config is very overloaded. Should it be --custom or --defaults or --overrides or something else entirely?

If anyone has any thoughts here, they would be greatly appreciated.

This is also a great first issue for anyone looking to contribute. Bonus points for adding tests. :)

@jessfraz
Copy link
Contributor

okay so I need to play with the tool a bit before I have opinions on the naming of flags :)

@squillace
Copy link
Contributor

squillace commented Apr 20, 2018

--custom-toml :-)
--custom-app-config

@bhavin192
Copy link

bhavin192 commented Oct 15, 2018

Hey folks, do we have any preference on this one?
I would like to do the required change :)
How about --config-file, --custom-config or --custom-config-file (really long flag)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants