Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

remove the embedded Azure SDK from Draft once ACR Build is in azure-sdk-for-go #694

Open
bacongobbler opened this issue Apr 23, 2018 · 2 comments
Open

remove the embedded Azure SDK from Draft once ACR Build is in azure-sdk-for-go #694

bacongobbler opened this issue Apr 23, 2018 · 2 comments
Labels
refactor size/medium

Comments

@bacongobbler
Copy link
Contributor

bacongobbler commented Apr 23, 2018 •
edited
Loading

refs discussion in #691
@ehotinger
Copy link

ehotinger commented May 17, 2018 •
edited
Loading

@bacongobbler ACR Build is in azure-sdk-for-go and published in /preview so this item is unblocked now.

Ref: https://github.com/Azure/azure-sdk-for-go/tree/master/services/preview/containerregistry/mgmt/2018-02-01/containerregistry

There should be no major breaking changes from the work you did earlier in #691 but the models may be ever-so-slightly different since I believe you hand-crafted a few properties like DockerImages?

@bacongobbler
Copy link
Contributor Author

Yeah, we'll also need to retain some things like util.go until we contribute that upstream. Thanks for the heads up!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
refactor size/medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bacongobbler @ehotinger