Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Proposal: pull default draft packs into its own repo #698

Open
bacongobbler opened this issue Apr 24, 2018 · 3 comments
Open

Proposal: pull default draft packs into its own repo #698

bacongobbler opened this issue Apr 24, 2018 · 3 comments

Comments

@bacongobbler
Copy link
Contributor

bacongobbler commented Apr 24, 2018

Because of the current repository setup, when draft init is called it clones all of Azure/draft. This causes draft pack-repo to list all of the packs in their test directories:

C:\Users\mafishe\go\src\github.com
λ draft pack-repo list
github.com/Azure/draft
github.com/Azure/draft/cmd/draft/testdata/drafthome
github.com/Azure/draft/cmd/draft/testdata/drafthome/packs/github.com/Azure/draft
github.com/Azure/draft/pkg/draft/pack/repo/installer/testdata/packdir/defaultpacks
github.com/Azure/draft/pkg/draft/pack/repo/testdata
github.com/Azure/draft/pkg/draft/pack/repo/testdata/packs/github.com/testOrg1/testRepo1
github.com/Azure/draft/pkg/draft/pack/repo/testdata/packs/github.com/testOrg1/testRepo2

We should pull the default packs into a separate repository such that draft init only fetches the files it needs, rather than the entire codebase.

@michelleN
Copy link
Contributor

michelleN commented Apr 25, 2018

+100 sounds great. Let's create a packs repo in github.com/draftcreate?

@bacongobbler
Copy link
Contributor Author

SGTM. Let's figure out the CLA stuff first then sync up on that. :)

@squillace
Copy link
Contributor

YES. Also, I'd like it if the new default draft packs now add in debug tomls for those langs we have working happily. node/go/ for now, soon java and dotnetcore

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants