Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: pod is not restarted if docker tag name is not changed #318

Open
1 task done
youngkyu-c opened this issue Mar 27, 2024 · 0 comments
Open
1 task done

Bug: pod is not restarted if docker tag name is not changed #318

youngkyu-c opened this issue Mar 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@youngkyu-c
Copy link

What happened?

if the manifest file is deployment, i expected restarting pod.
but, pod is not restarted because owner is wrong.
it is related with this code block.

    if (result?.stdout) {
         const stdout = result.stdout.split('\n')
         core.debug('stdout from getNewReplicaSet is ' + JSON.stringify(stdout))
         stdout.forEach((line: string) => {
            const newreplicaset = 'newreplicaset'
            if (line && line.toLowerCase().indexOf(newreplicaset) > -1) {
               core.debug(
                  `found string of interest for replicaset, line is ${line}`
               )
               core.debug(
                  `substring is ${line.substring(newreplicaset.length).trim()}`
               )
               newReplicaSet = line
                  .substring(newreplicaset.length)
                  .trim()
                  .split(' ')[0]
            }
         })
      }

here is the result of kubectl describe deployment.

...
NewReplicaSet:   xxx-deployment-7675bf5865 (1/1 replicas created)
...

and this line will be converted to : .

스크린샷 2024-03-27 22 55 19

i think const newreplicaset = 'newreplicaset' should be changed to const newreplicaset = 'newreplicaset:'.

Version

  • I am using the latest version

Runner

self hosted

Relevant log output

##[debug]found string of interest for replicaset, line is   Progressing    True    NewReplicaSetAvailable
##[debug]substring is True    NewReplicaSetAvailable
##[debug]found string of interest for replicaset, line is NewReplicaSet:   xxx-deployment-77546558b9 (1/1 replicas created)
##[debug]substring is :   xxx-deployment-77546558b9 (1/1 replicas created)
@youngkyu-c youngkyu-c added the bug Something isn't working label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant