Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make portalocker dependency optional #116

Closed
jiasli opened this issue Jul 25, 2022 · 1 comment
Closed

Make portalocker dependency optional #116

jiasli opened this issue Jul 25, 2022 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@jiasli
Copy link
Contributor

jiasli commented Jul 25, 2022 •
edited
Loading

portalocker relies on PyWin32 which is not allowed on SPython and SAW.

In order to achieve Azure/azure-cli#23315, msal-extensions should make the portalocker dependency optional to support SPython and SAW:

microsoft-authentication-extensions-for-python/msal_extensions/cache_lock.py

Line 9 in 69eef72

import portalocker

See https://microsoft.sharepoint.com/sites/knowledgecenter/SitePages/SPython.aspx?ls=Ans_Office
@rayluo rayluo added the duplicate This issue or pull request already exists label Aug 1, 2022
@rayluo
Copy link
Contributor

rayluo commented Aug 1, 2022

Roger that. Let's keep track in #96

@jiasli jiasli closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rayluo @jiasli