Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Werror=use-without-only not supported in all versions of gcc #1

Open
bishtgautam opened this issue Apr 29, 2016 · 8 comments
Open

Comments

@bishtgautam
Copy link
Contributor

-Werror=use-without-only not supported in gnu 4.9.3, but is supported in 5.1.0. Is there a minimum gcc version requirement?

@bishtgautam bishtgautam changed the title -Werror=use-without-only not supported in few version of gcc -Werror=use-without-only not supported in all versions of gcc Apr 29, 2016
@bandre-ucar
Copy link
Contributor

Um.... I'm using 5.3, I think Jinyun uses 6.1? I'm working on getting travis-ci working now that we have a public repo. Whatever they support will be what we support....

@bishtgautam
Copy link
Contributor Author

Not a big deal. I will just upgrade the compiler on my machine over the weekend to 5.x.

@bandre-ucar
Copy link
Contributor

No, we need to specify build dependancies for the compiler and netcdf. I just haven't made it a priority. If nothing else, we should add some build flags based on compiler version.

@bandre-ucar
Copy link
Contributor

What's the minimum version of gfortran that acme supports? My understanding is that cesm is going with something in the 5.x range.

@jinyun1tang
Copy link
Contributor

The minimum version is more like some 5.x version. I previously stumbled with older versions and decided to go with 6.x versions.

@bishtgautam
Copy link
Contributor Author

acme-se teams says the minimum supported version of gnu is 5.3. Should I close this issue or one wants to support gnu < 5.x?

@bandre-ucar
Copy link
Contributor

I think the gfortran version for travis is about 4.8. I'm not sure how much
of a pain it will be to get 5.x installed. Let me get things working there
and then I'll resolve this issue.

Ben

On Fri, Apr 29, 2016 at 3:02 PM, Gautam Bisht notifications@github.com
wrote:

acme-se teams says the minimum supported version of gnu is 5.3. Should I
close this issue or one wants to support gnu < 5.x?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1 (comment)

@bandre-ucar
Copy link
Contributor

I want to keep the stricter compiler warnings in gfortran >= 5 because they help catch bad coding practices. The correct way to handle this is with feature discovery. Tell cmake to test if the various compiler options are available in the compiler, and add them to the fortran flags only if they are. If we implement that, then we could support gfortran 4.9. I looked at the cmake doc for this, and I don't think it's terribly hard to implement, but I can't really justify the time right now.

zlyu027 pushed a commit to zlyu027/sbetr that referenced this issue Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants