Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Handle certificate errors by moving to the next available provider #42

Closed
serialjaywalker opened this issue Dec 21, 2024 · 7 comments

Comments

@serialjaywalker
Copy link
Contributor

serialjaywalker commented Dec 21, 2024

If a certificate is not accepted by the first chosen provider, the download will fail and failover goes to "completed".
image
The behaviour should be to retry with the next available provider until no providers are left, and then error out.

When doing a naive solution
image

I am able to download again (showing both naive and original).
image

@serialjaywalker
Copy link
Contributor Author

Errors occurred on a standard ubuntu installation as well as a standard raspbian installation (with OMV running alongside), and a SteamOS installation. Users should not have to deal with importing possibly-untrusted certs (if they even know how).

I have not tested on Windows yet, but the same argument applies. There have also been times where domains change or certs simply needed to be renewed (gogo is the most recent [albeit currently-zombie] example).

@serialjaywalker serialjaywalker changed the title Handle certificate errors by moving to the next available provider [Bug] Handle certificate errors by moving to the next available provider Dec 21, 2024
@Benexl
Copy link
Owner

Benexl commented Dec 21, 2024

Will look at this next year.
Taking a break from it.

@Benexl
Copy link
Owner

Benexl commented Dec 21, 2024

Though if you are willing to help will be happy to merge your pr's

@serialjaywalker
Copy link
Contributor Author

Sure, if I have time I can look for an actual and non-hacky solution, but I think we are all in the same boat due to the holidays. That being said, Happy holidays and new year!

@Type-Delta
Copy link
Collaborator

Errors occurred on a standard ubuntu installation as well as a standard raspbian installation (with OMV running alongside), and a SteamOS installation. Users should not have to deal with importing possibly-untrusted certs (if they even know how).

I can confirm that Windows also has the same issue

image

@ajayd-san
Copy link

ajayd-san commented Dec 28, 2024

Hey,
I'd like to work on this.

Though what would be an "actual and non-hacky solution" as mentioned by @serialjaywalker ? The naive solution suggested seems good to me?

@Benexl
Copy link
Owner

Benexl commented Dec 31, 2024

Hey, I'd like to work on this.

Though what would be an "actual and non-hacky solution" as mentioned by @serialjaywalker ? The naive solution suggested seems good to me?

You are welcome to do so am personally taking a long break from fastanime it does everything i wanted it to do plus more and i think i deserve a break coding for 3mnths straight and writing 13k lines of code solo is no joke

@Benexl Benexl closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants