Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Use core to determine base URL #1

Open
dhensby opened this issue May 30, 2014 · 6 comments
Open

Use core to determine base URL #1

dhensby opened this issue May 30, 2014 · 6 comments

Comments

@dhensby
Copy link
Member

dhensby commented May 30, 2014

Why are we introducing another way to manage the base URL for the PDF when we can just use core to do so?

Be it alternate_base_url or $_URL_TO_FILE_MAPPING?

17de2b4#diff-608f3da92c5983277ec89535c449a0eeR19

@willmorgan
Copy link
Member

Ooh, you make a good point about $_URL_TO_FILE_MAPPING. How do I go about using it? Let me know and I'll push it in ASAP.

@dhensby
Copy link
Member Author

dhensby commented May 30, 2014

The CLI pulls it in automatically and uses it to fill the $_SERVER superglobal

@willmorgan
Copy link
Member

This isn't CLI based!

@dhensby
Copy link
Member Author

dhensby commented May 30, 2014

You could look at static publisher's approach?

@willmorgan
Copy link
Member

I've searched through that repository for $_FILE_TO_URL_MAPPING but there's nothing there.

Moreover, the static publisher doesn't need to pull in assets - that's done on the client side - whereas in this instance, the binary needs to request those images itself and embed them directly in to the PDF, before the client views it. Does that make sense?

For now, http://localhost looks like a sensible default to me. If it needs to be changed it'll be because of multi instance live deployment. That's why I'm not using the base URL and calling it something else.

@dhensby
Copy link
Member Author

dhensby commented May 30, 2014

I meant how the publisher use custom domain names.

Ok, lets put it on the back-burner for now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants