Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review other forks and incorporate when it makes sense #20

Open
Apollon77 opened this issue May 22, 2020 · 13 comments
Open

Review other forks and incorporate when it makes sense #20

Apollon77 opened this issue May 22, 2020 · 13 comments

Comments

@biancode
Copy link
Collaborator

@NateZimmer would you be part of the project?

@biancode
Copy link
Collaborator

@sowd would you be part of the project?

@Apollon77
Copy link
Collaborator Author

@nkofl would you be part of the project?

@Apollon77
Copy link
Collaborator Author

@bastiaanv would you be part of the project?

@NubeDev
Copy link

NubeDev commented May 30, 2020

I think this one is vaild re being able define the network number and device ID, being able to define the network number and device ID on exiting networks is very vaild.

NateZimmer/node-bacstack@master...antecursor:master

And past issue.
fh1ch#48

I tested this fork with a BACnet IP <> MS/TP router and it worked well.

client.readProperty( {'ip':'192.168.10.10','net':6000,'adr':[3]} , {type: 0, instance: 0}, 85, (err, value) => {
  console.log('value: ', value);
});

@Apollon77
Copy link
Collaborator Author

@NubeDev Sorry, I do not really get what you mean ;-) You talk about the networknumber and devide Id topic wehich should be integrated (and I can read the last sentence that you verified this). The other link goes to the branch about Weekly-Schedule ...

@NubeDev
Copy link

NubeDev commented May 30, 2020

Sorry i put the wrong link.
What im saying is the branch below adds support for passing the mac address as an option. And also when doing a whoIs you can pass in the network number. Doing this you can also discover bacnet mstp devices that are under a bacnet router. As per this issue fh1ch#140

So i tested NateZimmer branch with bacnet mstp devices and it works well.
fh1ch/node-bacstack@master...NateZimmer:master

@Apollon77
Copy link
Collaborator Author

Ok, fh1ch/node-bacstack@master...NateZimmer:master seems to be in this library too, different but included ... could you try it with our lirary too?

@NubeDev
Copy link

NubeDev commented May 31, 2020

I did test it already. Ill reveiw it again and post results

@bastiaanv
Copy link

Hey guys,

I do not know if you want to continue this project, but, at the company I work for, we have decided to create a new BACNET library. This library is written in Typescript, with the use of Promises and RXJS. If you want to help me, feel free to make a pull request at: https://github.com/bastiaanv/bacnet-driver.

Keep up the good work!

@Apollon77
Copy link
Collaborator Author

@bastiaanv Hey, thank you for the link. WHy you decided to build a new library if there is one with a very big featureset? :-(

@NateZimmer
Copy link

A groundup rewrite or a port to typescript would be a lot of effort for dubious value?

@biancode
Copy link
Collaborator

biancode commented Sep 2, 2020

The BACnet-driver is GPL-2.0 and we want to be MIT licensed. GPL is not the way for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants