Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctypes 0.18.0 support #18

Open
sternenseemann opened this issue Mar 6, 2021 · 0 comments
Open

ctypes 0.18.0 support #18

sternenseemann opened this issue Mar 6, 2021 · 0 comments

Comments

@sternenseemann
Copy link

ctypes 0.18.0 merged the threaded and unthreaded sub package for ctypes.foreign. As a result, building bap-bindings fails with the following message:

  /nix/store/v02f2lbgkrdawgxzgqpy4gs57caqqn0i-ocaml-findlib-1.8.1/bin/ocamlfind opt -o _build/bap/generate -linkpkg -package bap,bap-plugins,ctypes.stubs,ctypes.foreign,findlib.dynload,bap-main _build/bap/lib/bindings.cmx _build/bap/stub_generator/generate.cmx
  ocamlfind: [WARNING] Package `threads': Linking problems may arise because of the missing -thread or -vmthread switch
  File "/build/findlib_initlf9c4b9.ml", line 1:
  Error: No implementations provided for the following modules:
           Thread referenced from /nix/store/81w5jjxw45fxwfwiqhlwqwywl94rwq2c-ocaml4.10.0-ctypes-0.18.0/lib/ocaml/4.10.0/site-lib/ctypes/ctypes-foreign.cmxa(Foreign)
           Mutex referenced from /nix/store/81w5jjxw45fxwfwiqhlwqwywl94rwq2c-ocaml4.10.0-ctypes-0.18.0/lib/ocaml/4.10.0/site-lib/ctypes/ctypes-foreign.cmxa(Foreign)
  make: *** [Makefile:78: _build/bap/generate] Error 2

This can be fixed by passing the -thread flag to ocamlopt when linking, but I'm not sure if this is the best way to alleviate the issue.
sternenseemann added a commit to sternenseemann/nixpkgs that referenced this issue Mar 10, 2021
@sternenseemann
ocamlPackages.ctypes: 0.17.1 -> 0.18.0
16377db 
https://github.com/ocamllabs/ocaml-ctypes/blob/0.18.0/CHANGES.md#ctypes-0180

* ocamlPackages.async_ssl: fix compatibility with ctypes 0.18.0 by using
  ctypes.foreign instead of ctypes.foreign.threaded since the distinction
  between threaded and unthreaded has been removed in this release.
* libbap: link with -thread so linking ctypes.foreign doesn't fail
  BinaryAnalysisPlatform/bap-bindings#18
* ocaml-ng.ocamlPackages_4_07.sodium: patch lib_gen/_tags to also add
  the `package(bigarray)` directive since `ctypes.stubs` no longer
  propgates that, leading to module not found error.
* ocaml-ng.ocamlPackages_4_{04,05,06,07}.async_ssl: mark as broken: due to
  the bigarray-compat dependency, we need dune 2 for ctypes which breaks
  compilation of the legacy async_ssl 0.11 version since we can't
  upgrade to dune 2 for it since that version doesn't support the legacy
  jbuild files.
vbgl pushed a commit to NixOS/nixpkgs that referenced this issue Mar 10, 2021
@sternenseemann @vbgl
ocamlPackages.ctypes: 0.17.1 -> 0.18.0
1979284 
https://github.com/ocamllabs/ocaml-ctypes/blob/0.18.0/CHANGES.md#ctypes-0180

* ocamlPackages.async_ssl: fix compatibility with ctypes 0.18.0 by using
  ctypes.foreign instead of ctypes.foreign.threaded since the distinction
  between threaded and unthreaded has been removed in this release.
* libbap: link with -thread so linking ctypes.foreign doesn't fail
  BinaryAnalysisPlatform/bap-bindings#18
* ocaml-ng.ocamlPackages_4_07.sodium: patch lib_gen/_tags to also add
  the `package(bigarray)` directive since `ctypes.stubs` no longer
  propgates that, leading to module not found error.
* ocaml-ng.ocamlPackages_4_{04,05,06,07}.async_ssl: mark as broken: due to
  the bigarray-compat dependency, we need dune 2 for ctypes which breaks
  compilation of the legacy async_ssl 0.11 version since we can't
  upgrade to dune 2 for it since that version doesn't support the legacy
  jbuild files.
sternenseemann added a commit to sternenseemann/nixpkgs that referenced this issue Jul 24, 2021
@sternenseemann
ocamlPackages.ctypes: 0.17.1 -> 0.18.0
eb62e95 
https://github.com/ocamllabs/ocaml-ctypes/blob/0.18.0/CHANGES.md#ctypes-0180

* ocamlPackages.async_ssl: fix compatibility with ctypes 0.18.0 by using
  ctypes.foreign instead of ctypes.foreign.threaded since the distinction
  between threaded and unthreaded has been removed in this release.
* libbap: link with -thread so linking ctypes.foreign doesn't fail
  BinaryAnalysisPlatform/bap-bindings#18
* ocaml-ng.ocamlPackages_4_07.sodium: patch lib_gen/_tags to also add
  the `package(bigarray)` directive since `ctypes.stubs` no longer
  propgates that, leading to module not found error.
* ocaml-ng.ocamlPackages_4_{04,05,06,07}.async_ssl: mark as broken: due to
  the bigarray-compat dependency, we need dune 2 for ctypes which breaks
  compilation of the legacy async_ssl 0.11 version since we can't
  upgrade to dune 2 for it since that version doesn't support the legacy
  jbuild files.
* ocamlPackages.janeStreet_0_9_0.async_ssl: mark as broken for same
  reasons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sternenseemann