You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ON visits.first_name = fitness_tests.first_name AND visits.last_name = fitness_tests.last_name AND visits.email = fitness_tests.email
LEFT JOIN applications
ON visits.first_name = applications.first_name AND visits.last_name = applications.last_name AND visits.email = applications.email
LEFT JOIN purchases
ON visits.first_name = purchases.first_name AND visits.last_name = purchases.last_name AND visits.email = purchases.email
WHERE visits.visit_date >= '7-1-17'
Great job here. However, I would add line breaks to increase code readability. We did not follow code styling very closely in this course. However, it is very important. I would do:
df = sql_query('''
SELECT visits.first_name,
visits.last_name,
visits.visit_date,
fitness_tests.fitness_test_date,
applications.application_date,
purchases.purchase_date
FROM visits
LEFT JOIN fitness_tests
ON fitness_tests.first_name = visits.first_name
AND fitness_tests.last_name = visits.last_name
AND fitness_tests.email = visits.email
LEFT JOIN applications
ON applications.first_name = visits.first_name
AND applications.last_name = visits.last_name
AND applications.email = visits.email
LEFT JOIN purchases
ON purchases.first_name = visits.first_name
AND purchases.last_name = visits.last_name
AND purchases.email = visits.email
WHERE visits.visit_date >= '7-1-17'
''')
Capstone/musclehub.py
Lines 125 to 135 in 808f4ed
Great job here. However, I would add line breaks to increase code readability. We did not follow code styling very closely in this course. However, it is very important. I would do:
The PEP8 guide for the maximum length of a code line:
https://www.python.org/dev/peps/pep-0008/#maximum-line-length
The text was updated successfully, but these errors were encountered: