Crash after scanning document #282
Comments
|
Hello, |
|
Quite often - about 80% of scanner launch. |
|
Hi @khambir, |
|
@Brankacro yes, sure. As you can see, the scanner works well, but when the document in focus and I activate the passport scanner the app is broken. |
|
Thanks @khambir for the video. Can you please try one more thing, to build the sample from the Sample folder in the root of our SDK, using the PassportRecognizer and see how it goes? How does this sound? |
|
This issue has been there specifically in SDK 5.1.0. I can reproduce it consistently in the attached sample project. Just try scanning any document that is supported by BlinkIDRecognizer multiple times. Like in the attached sample project, after the document is scanning then you will be asked to confirm if the picture taken is clear enough. Hit "Retake" on that screen to do the re-scan. Do this 2-3 times and you will see the crash. |
|
Hi @khambir and @pankajhotwani2, Thanks for reporting this. We've investigated this in more detail and so far it seems we've introduced a memory leak in v5.1. We'll take this with the biggest priority for the next week. If we confirm the issue and find the root cause, we'll be updating the SDK immediately after that. We'll keep you posted. Jurica. |
|
Seems we have similar issue. |
|
Hi @khambir, @pankajhotwani2, @vg-identance, We've found a memor leak in v5.1 where there was a retain cycle between MBBlinkIDRecognizer and MBBlinkIDOverlayViewController. We've managed to fix it and we've released v5.1.1 today. Can you try if you have the same issue with the updated SDK? Thank you, |
|
Hi @Cerovec Unfortunately, I can reproduce the crash on v.5.1.1 |
|
Hi @khambir please send us your demo where you are getting this crash |
|
@juraskrlec behavior is the same as here: https://github.com/BlinkID/blinkid-ios/files/4058341/video.zip |
|
Hi, Thank you. What puzzles us is that we cannot reproduce the same thing with our sample apps. We also ran instruments on our sample app and couldn't find any problems. See attached. Can you:
@pankajhotwani2, @vg-identance - are you still experiencing the same issue? Thank you,
|
|
@khambir Can you check in your Custom UI implementation how do you dismiss the Recognizer Runner View Controller? It looks like the current process is like this
If we're right, this is the problem. You can't have multiple recognizer runner view controllers running at the same time in the same stack. You should dismiss the first one before starting another. Looking forward to your feedback. Jurica. |
|
@Cerovec Thanks Jurica! I verified the new SDK version 5.1.1 and its working like a charm so the fix that you put in seems to be working correctly. Note: If you want to cross check then you can try running the TestBlink sample project that I attached in my previous post. Thanks Again! Pankaj |
|
@Cerovec we do not use multiple recognizer runner view controllers running at the same time. Everything works fine with version 5.0, but with 5.1 and 5.1.1 we have the crash. But frankly speaking, it's too hard to reproduce this crash with 5.1.1, but in any case, it is possible for me. |
|
I tried again today with 5.1.1 in the same sample app project and today I could reproduce the issue again. So looks like there was still an issue with 5.1.1, its just that it was hard to reproduce. Sorry for the confusion.. So @Cerovec, unfortunately the issue still persist in 5.1.1. Can you confirm? Thanks, |
|
|
@Cerovec Are there any plans to fix the crash in the upcoming version? |
|
@Cerovec still get same crash on v5.2 |
|
@vg-identance @Cerovec can confirm, same crash for me on v5.2. Going to try 5.0 and see if that helps.
|
|
@vg-identance @Cerovec I can confirm that on any of the 5.0.x versions, the framework does not crash. As soon as you move to 5.1.0 it becomes unstable. |
|
Please share with us your code where you are getting this crash, so we can reproduce it at our end and see what's going on. Best, |
|
@jowie @vg-identance @pankajhotwani2 You can also contact us directly to support@microblink.com (if you don't want to share your code publicly). Regards |
|
Hi @khambir @pankajhotwani2 @vg-identance @jowie, we were testing TestBlink project provided by pankajhotwani2. We are getting the same crash on 5.0.0 and 5.2.0. In provided TestBlink project, crash is solved by moving With that, the crash was fixed on 5.0.0, but not on 5.2.0. Since we changed the processing queue, it looks like In If you also add in this method |
|
@TCvetkovic Solution provided worked in TestBlink project. Thanks! |
|
The solution for my code was different. I was calling |
|
@jowie, @pankajhotwani2, @vg-identance We've managed to find a part of our OpenGL code which was fragile and sensitive to crashes if used from multiple threads. We're releasing v5.3 this week where this will be sorted out as well. We suggest you upgrade to v5.3 so that we can test if this helps you. |
|
@jowie, @pankajhotwani2, @vg-identance, Can you please check if v5.3 solves your issues? It was released yesterday. Thanks, |
|
@Cerovec Thanks, seems works better |
|
Can not reproduce in v5.3 |
|
Thanks @Cerovec! New version 5.3.0 is working good so far. Thanks, |
|
@pankajhotwani2, @khambir, @vg-identance, @jowie, We're reopening this issue as it appears that it still exists. What's your experience? Do you have any crash reporting mechanisms? Do you see the crash happening in production? Do you have any way of reproducing this issue? Thanks! |
|
Not in production yet. |
|
Hi @Cerovec This crash I do not have in production, but there are other ones. Two types of crashes: The first one:
The second one:
|
|
@vg-identance - thanks for the feedback! @khambir, thanks! For the crash with For the crash with If anyone else experiences the crashes with |
|
@Cerovec so we finally get to the prod state and begin to receive a lot of crashes with |
|
Hi @vg-identance, Thanks for the update! We have some clues as where the issue might be, but we need some more digging to get to the bottom of it. In the meantime, keep us informed about the severity of the crash, if possible. Thanks, |
|
@Cerovec some of the crash logs: |
|
@Cerovec any update on this? |
|
Apologies for keeping you waiting. We've released BlinkID 5.6, where the issue you were having should be fixed now. Would you mind giving us feedback on whether the new release fixed it? Regards, |
|
Yes the issue still persist in Blink ID 5.6.0. I rolled back to 5.3.0 which works for me. |
|
Also have this issue in 5.6.0 but only was able to replicate in Debug build with frequency about 1 crash in 150 tries |
|
Hi everyone, Just to make a follow-up on this thread. Did you maybe get a chance to test the latest version (v5.8) and trying to reproduce the issue? Regards, |
|
@mparadina currently update with 5.8 still in development |
Environment
Describe the problem
The app is crashing after scanning the document.
Steps to reproduce:
MBPassportRecognizerTry to do it several times, the bug is reproducing not every time, but quite often.
I use iPhone X.
I can not reproduce this bug with BlinkID SDK 5.0, only with 5.1.
The text was updated successfully, but these errors were encountered: