Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unsubscribe function #10

Closed
EjembiEmmanuel opened this issue Nov 22, 2024 · 7 comments
Closed

Implement unsubscribe function #10

EjembiEmmanuel opened this issue Nov 22, 2024 · 7 comments
Assignees
Labels
good first issue Good for newcomers ODHack10 This issue is part of OD HACK onchain

Comments

@EjembiEmmanuel
Copy link
Collaborator

EjembiEmmanuel commented Nov 22, 2024

Implement an unsubscribe function to revoke the AutoSwappr contract's approval to spend specific tokens on behalf of the user.

write full unit test for the function

@EjembiEmmanuel EjembiEmmanuel added good first issue Good for newcomers onchain ODHack10 This issue is part of OD HACK and removed good first issue Good for newcomers labels Nov 22, 2024
@No-bodyq
Copy link

Can I jump on this task?

@mimisavage
Copy link

I'd be happy to do this.

@Birdmannn
Copy link

Hey @EjembiEmmanuel, I'd love to work on this issue.

I'm Pascal Torti, a certified Cairo Blockchain developer. I specialise in Cairo Starknet, Java Springboot, Reactjs and Flutter. I have gone through your repo prior to this issue, having applied for the subscribe function and not getting it. I can handle this task.

Adding a new function to the interface, implementing it in the smart contract itself, and carrying out all possible tests on it to make sure it is free from bugs and won't disturb any other written algorithms. ETA is within a day. I have read the contribution guide.

@Kingsuite
Copy link
Contributor

May I try my hand at this?

This is my first time contributing to this project

@Jagadeeshftw
Copy link

Could I take on this issue?

@SoarinSkySagar
Copy link

May I work on this issue @EjembiEmmanuel?

I am a cairo dev with extensive experience in building on cairo and also a regular contributor at @keep-starknet-strange and the starknet ecosystem in general. You can see my PoW on my github and onlydust profile.

my approach: I will go through the entire codebase to understand it and then create the unsubscribe function accordingly. I will write tests for the function to and ensure that all tests are passing before submitting the PR.

eta: 3 days

@saimeunt
Copy link

Hey I'd like to tackle this one please, check my past contributions in Cairo: https://app.onlydust.com/u/saimeunt

@sprtd sprtd closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ODHack10 This issue is part of OD HACK onchain
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants