Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test revoke token approval after swaps #47

Closed
sprtd opened this issue Dec 20, 2024 · 4 comments · Fixed by #49
Closed

Test revoke token approval after swaps #47

sprtd opened this issue Dec 20, 2024 · 4 comments · Fixed by #49
Assignees
Labels
good first issue Good for newcomers ODHack11 This is an ODHack11 issue onchain

Comments

@sprtd
Copy link
Contributor

sprtd commented Dec 20, 2024

Add validation logic in test that guarantees that no token allowance exists if approval is revoked after a successful swap txn (fibrous and avnu)

@sprtd sprtd added good first issue Good for newcomers onchain ODHack11 This is an ODHack11 issue labels Dec 20, 2024
@emarc99
Copy link

emarc99 commented Dec 20, 2024

Can I start working on this?

@martinvibes
Copy link
Contributor

martinvibes commented Dec 20, 2024

hey @sprtd
I'm going to test that when users revoke their token approvals after making swaps on Fibrous or Avnu (which are DEXs)
i will first:

Set up a test swap
Do the swap successfully
Revoke the approval
Check that the approval is truly zero/canceled
i will also check the before and after state of the swap

@wheval
Copy link

wheval commented Dec 20, 2024

Hello @sprtd,
Can I tackle this one?

ETA is 1 day.

@Birdmannn
Copy link

Hey dev @sprtd, Please can I work on this? I'm a good cairo developer, and I'll start this task immediately and finish it in less than 3 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ODHack11 This is an ODHack11 issue onchain
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants