Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update end to end tests for Boavizta API release #467

Closed
demeringo opened this issue Mar 14, 2024 · 0 comments · Fixed by #468
Closed

Update end to end tests for Boavizta API release #467

demeringo opened this issue Mar 14, 2024 · 0 comments · Fixed by #468
Labels
enhancement New feature or request

Comments

@demeringo
Copy link
Collaborator

Problem

Latest Boavizta Boavizta API release brings an updated calculation method of embedded impacts of CPU.

https://github.com/Boavizta/boaviztapi/releases/tag/v1.2.4

The returned values slighty changed, and this breaks the end to end test (which uses latest API by default).

---- boavizta_api_v1::tests::should_retrieve_raw_default_impacts_aws_fr stdout ----
thread 'boavizta_api_v1::tests::should_retrieve_raw_default_impacts_aws_fr' panicked at cloud-scanner-cli/src/boavizta_api_v1.rs:359:9:


json atoms at path ".impacts.gwp.embedded.max" are not equal:
    expected:
        0.002547
    actual:
        0.002545

json atoms at path ".impacts.gwp.embedded.min" are not equal:
    expected:
        0.0009013
    actual:
        0.0008995

json atoms at path ".impacts.pe.embedded.max" are not equal:
    expected:
        0.03333
    actual:
        0.03331

json atoms at path ".impacts.pe.embedded.min" are not equal:
    expected:
        0.01188
    actual:
        0.01186


note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    boavizta_api_v1::tests::should_retrieve_raw_default_impacts_aws_fr

Solution

Update the test values.

This seems consistent with the update on the API tests https://github.com/Boavizta/boaviztapi/pull/279/files#

Alternatives

Additional context or elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant