Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one more option to handle order without reordering plugin lists #18

Open
afwn90cj93201nixr2e1re opened this issue Jul 27, 2020 · 3 comments

Comments

@afwn90cj93201nixr2e1re
Copy link
Contributor

No description provided.

@afwn90cj93201nixr2e1re
Copy link
Contributor Author

Right now we can't handle which one hooked function value gonna be returned or overrided.

if(unlikely(mres > status))

As you can see there's only check against MRES ret stuff.

For example:
Plugin 1 hooking CmdStart_Post or something like that
and returning 0 with override/supercede

Plugin 2 hooking CmdStart_Post or something like that
and returning 0 with override/supercede, and this one plugins should override values without depending on order. It's main plugin which should controll all exclusive stuff.

Plugin 3 hooking CmdStart_Post or something like that
and returning 0 with override/supercede

@afwn90cj93201nixr2e1re
Copy link
Contributor Author

e.g. SET_META_PRIORITY(99) and then plugins which are settting priority to 0 or 10 or 98 or 97 and etc gonna be skipped at reassigning state.

Also if you can add more MRES_ types, for example MRES_BREAK_POST, for breaking post calling, MRES_BREAK_ORIG_POST for breaking original call and post call,
MRES_BREAK_NEXT_ORIG_POST for breaking next pre, origin, post calls
MRES_BREAK_NEXT_POST for breaking next pre and post call's.

Btw i suggest to add another one value instead filling up MRES_ stuff.

But they must be very well designed so that we can flex them the way we want, for example, we can use bitsums to prevent the next pre call, next post call, call POST at all, call POST and origin at all. (im not talking about prevent calling origin due mres_supercede already exists)

@afwn90cj93201nixr2e1re
Copy link
Contributor Author

@jkivilin can u take look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant