Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec] activity list is nullable, currentpage is a query parameter #1240

Closed
archived-2f4dd0 opened this issue May 9, 2020 · 3 comments
Closed

Comments

@archived-2f4dd0
Copy link

archived-2f4dd0 commented May 9, 2020

Destiny.HistoricalStats.DestinyActivityHistoryResults.activities is nullable.
instead of containing an empty array, it'll be completely missing if there's no activities to report.

as reported here, DestinyItemManager/bungie-api-ts#2
GetMembersOfGroup
GetAdminsAndFounderOfGroup
GetBannedMembersOfGroup
GetPendingMemberships
GetInvitedIndividuals
list currentpage as a path parameter,
but i am pretty sure it's actually a query parameter.

actually, the latter is partially a duplicate of #192 / #124

@archived-2f4dd0
Copy link
Author

bonus: putting the stats.bungie.net requirement
in the comments for GetPostGameCarnageReport
would be cool

@archived-2f4dd0
Copy link
Author

archived-2f4dd0 commented Jun 8, 2020

some other nullable things:
UserInfoCard.applicableMembershipTypes
UserInfoCard.supplementalDisplayName
DestinyInventoryItemDefinition.quality

Copy link

This issue was closed because it has been inactive for one week since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants