Replace bool more by an enum class in BlockingWrite.

[dkorolev]

Because Connection& BlockingWrite(const char* s, bool more) is called for BlockingWrite(s, strlen(s)), which clearly is not what the user intends.

[mzhurovich]

@dkorolev Hmm, where did you see BlockingWrite(s, strlen(s))?

[dkorolev]

In the code I wrote last or last last weekend :) hopefully, not presently in Current. But it’s programmers writing program code, and programmers are just like humans, so you never know.

On Tue, Sep 17, 2019 at 7:58 PM Maxim Zhurovich ***@***.***> wrote: @dkorolev <https://github.com/dkorolev> Hmm, where did you see BlockingWrite(s, strlen(s))? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#866?email_source=notifications&email_token=AAQPGVYXDJK6NT2UBHBLYQ3QKFVIRA5CNFSM4IW4PI32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66HWNY#issuecomment-532446007>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQPGV5LQBTQXT37724F2ZTQKFVIRANCNFSM4IW4PI3Q> .

-- Thanks, Dima http://dimakorolev.com/ | http://www.linkedin.com/in/dimakorolev | dmitry.korolev@gmail.com