You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A full-fledged tutorial would be great to help others contribute their existing nxf code.
nf-core has a contributing guide for their modules repo, but we have diverged from them in a number of ways e.g. they switched to nf-test while we still use pytest. https://nf-co.re/docs/contributing/modules
how to add CCBR/nf-modules repo as custom remote modules repo (in addition to nf-core/modules) ... in the README
how to add specific versions of the remote modules to your nf pipeline .. in the README
more documentation on create-test-yml for creating unit tests ... what should the contents be ... may be a good walkthrough creation of unit test will be helpful
@wilfriedguiblet / @kelly-sovacool , I think we should also document when to create a new nf-module under the CCBR/nf-modules repo. IMO, here is what we should do:
Check if the required module exists under nf-core/modules using
nf-core modules list remote | grep <required_module>
No point reinventing the wheel.
If the module is found, install it using nf-core modules install <required_module> and try to see if we can use it as is. REMEMBER: Here we would like to override the docker used by nf-core module using the container directive in the process block in the config file.
If the module is NOT found, then obviously we would like to create and add it to CCBR/nf-modules using the documentation outlined by @kelly-sovacool
If the module was found, but while using it we realize that it needs to be modified as per our/CCBR needs... then we submit the edited/updated/modified version to CCBR/nf-modules eg. feat: adding modified nf-core fastqc module #46
What do you think? Have I missed any other scenario/case?
The contributing doc is very minimal right now, needs more detail to be useful
https://github.com/CCBR/nf-modules/blob/main/.github/CONTRIBUTING.md
A full-fledged tutorial would be great to help others contribute their existing nxf code.
nf-core has a contributing guide for their modules repo, but we have diverged from them in a number of ways e.g. they switched to nf-test while we still use pytest. https://nf-co.re/docs/contributing/modules
Thanks to @wilfriedguiblet for the suggestion!
The text was updated successfully, but these errors were encountered: