Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediary Screen UI: Request for Permissions #412

Open
1 task done
Pavel401 opened this issue Dec 19, 2024 · 10 comments · May be fixed by #432
Open
1 task done

Intermediary Screen UI: Request for Permissions #412

Pavel401 opened this issue Dec 19, 2024 · 10 comments · May be fixed by #432
Assignees
Labels
enhancement New feature or request Hard

Comments

@Pavel401
Copy link
Member

Describe your improvement idea or feature request

The intermediary screen will serve as a buffer between the onboarding process and the main task home screen. It will educate the user about the necessity of granting storage,notification permissions and reassure them about data privacy.

How would you like to see it implemented?

UI

Header
"Why We Need Your Permission"

Title:
"Why We Need Your Permission"

Description:
Provide a short explanation of why the app needs storage access and notifications permissions.

Illustration/Icon:
Include a visually appealing, relevant icon or illustration, such as a secure folder for storage or a notification bell for notifications.

Main Content:
Clearly explain the necessity and benefits of granting these permissions.

Example content:

  • Storage Permission:
    "We use storage access to save your tasks, preferences, and app data securely on your device. This ensures that you can pick up where you left off seamlessly, even offline."

- Notification Permission:
"Notifications keep you updated with important reminders and updates, ensuring you stay on top of your tasks effortlessly."

Assure users about data privacy and security:
"Your privacy is our top priority. We never access or share your personal files or data without your consent."

Action Buttons:

  • Primary Button: "Grant Permission" (Triggers the system permission dialog for storage and/or notifications.)

Optional Footer:

  • Provide a reassuring message:
    "You can manage your permissions anytime later in Settings."

Design Guidelines:

  • Follow Material 3 design principles.
  • Ensure the dialog aligns with the app's existing theme, including colors, typography, and spacing.

Acceptance Criteria:

  • The UI must display the title, description, and relevant illustrations/icons.
  • Action buttons must trigger the correct permission request dialogs.
  • The design should conform to Material 3 guidelines and match the app's theme.
  • Test the UI on both light and dark modes to ensure visual consistency.

Put here any screenshots or videos (optional)

original-276a3f7be249db8ab2ae9068abdb5b95

How can we contact you (optional)

N/A

Would you like to work on this issue?

None

By submitting this issue, I have confirmed that:

  • I have starred the repo ⭐ and watched 👀 it on GitHub and followed the contribution guidelines.
@Pavel401 Pavel401 added enhancement New feature or request Hard labels Dec 19, 2024
@Pavel401 Pavel401 changed the title Intermediary Screen UI: Request for Storage Permission Intermediary Screen UI: Request for Permissions Dec 19, 2024
@dorkydhruv
Copy link

hey @Pavel401 !
Let me work on this issue.
I think the custom ui for explaining the reason behind the permission should be showed if they deny the dialog. But do let me know when it is prompted.

@Pavel401 Pavel401 moved this to Todo in TaskWarrior Dec 26, 2024
@Pavel401 Pavel401 moved this from Todo to In Progress in TaskWarrior Dec 26, 2024
@rohansen856
Copy link
Contributor

@dorkydhruv are you still working on this issue...? If not i would like to work on it @Pavel401

@Pavel401 Pavel401 assigned rohansen856 and unassigned dorkydhruv Jan 11, 2025
@Pavel401
Copy link
Member Author

@rohansen856 Can you quickly send the PR for this before the 15th of Jan?

@rohansen856
Copy link
Contributor

Yupp will try to do it asap... Will Possibly make a pr within tomorrow.

@rohansen856
Copy link
Contributor

@Pavel401 the work is mostly finished... before i make a PR i would like to confirm if the UI is up to the mark

Permission Screen

Did not add any extra images to keep the app size as low as possible...

@BrawlerXull
Copy link
Collaborator

@Pavel401 the work is mostly finished... before i make a PR i would like to confirm if the UI is up to the mark

Permission Screen

Did not add any extra images to keep the app size as low as possible...

Can you please make the page match the theme of rest of the application?

@rohansen856
Copy link
Contributor

@Pavel401 the work is mostly finished... before i make a PR i would like to confirm if the UI is up to the mark
Permission Screen
Did not add any extra images to keep the app size as low as possible...

Can you please make the page match the theme of rest of the application?

sure... would make the necessary changes now and get back to you shortly...

@rohansen856
Copy link
Contributor

WhatsApp Image 2025-01-12 at 10 38 46 PM (1)

WhatsApp Image 2025-01-12 at 10 42 09 PM

@BrawlerXull does this seem about right...?

@Pavel401
Copy link
Member Author

Looks good to me now, @BrawlerXull. I think we can use this.

@BrawlerXull
Copy link
Collaborator

WhatsApp Image 2025-01-12 at 10 38 46 PM (1)

WhatsApp Image 2025-01-12 at 10 42 09 PM

@BrawlerXull does this seem about right...?

Yup this is good can be merged

@rohansen856 rohansen856 linked a pull request Jan 12, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hard
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants