Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Information criterion or Bayesian evidence instead of chi squared to determine best model #58

Open
DanielaBreitman opened this issue Apr 6, 2022 · 2 comments
Assignees
Labels
Baseband Related to integrating Fitburst into baseband enhancement New feature or request

Comments

@DanielaBreitman
Copy link
Contributor

When fitting with multiple models where we vary the number of peaks, currently, we use the chi squared to determine the best model with the least parameters. Better practice would be to change this to use Akaike Information Criterion (AIC) or some other IC OR, if not too difficult to extract, the Bayesian evidence.

@DanielaBreitman DanielaBreitman added enhancement New feature or request Baseband Related to integrating Fitburst into baseband labels Apr 6, 2022
@emmanuelfonseca emmanuelfonseca self-assigned this Apr 6, 2022
@emmanuelfonseca
Copy link
Collaborator

@DanielaBreitman I added an initial stats.py file in fitburst/analysis, which only contains a function to compute an F-test statistic. however, F-tests are certainly not the only thing and I definitely agree that AIC and equivalent tests should be available and used. how about we add one or a few additional functions, like AIC and and Bayes-factor calculations, into this file?

@DanielaBreitman
Copy link
Contributor Author

This is perfect! This is the way to proceed. Thanks @emmanuelfonseca !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseband Related to integrating Fitburst into baseband enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants