Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Allow underlying sensitivity plot to be configured with keyword arguments #423

Closed
drewejohnson opened this issue Oct 6, 2020 · 2 comments · Fixed by #434
Closed
Assignees
Milestone

Comments

@drewejohnson
Copy link
Collaborator

drewejohnson commented Oct 6, 2020

Is your feature request related to a problem? Please describe.
The SensitivityReader has a very nice plot method, but I've found it to be frustrating to configure and tweak at times. Currently, there is no way to manually add markers, colors, tweak the draw style (line, steps, dashed, etc)

Describe the solution you'd like
By allowing the user to pass arguments as keyword arguments through to ax.errorbar, we can easily allow this configuration

ax.errorbar(energies, yVals, yErrs, label=label,
drawstyle='steps-post')

The patch should be merged into the main branch rather than develop since there's a lot going on currently with respect to 0.10.0 and #335, #400

Describe alternatives you've considered
The workaround is to extract and plot the data on your own, but we can do a little better

This is related to #417, but a smaller, more focused issue

@anthonybench
Copy link

I'd like to give this a try please!

@drewejohnson
Copy link
Collaborator Author

@anthonybench I'm so sorry for not following up on this. October was a wild month for me and some things fell through the cracks. Are you still interested in this?

@drewejohnson drewejohnson self-assigned this Jan 4, 2021
drewejohnson added a commit to drewejohnson/serpent-tools that referenced this issue Mar 22, 2021
Closes CORE-GATECH-GROUP#423

Default drawstyle is steps-post

Related to
- CORE-GATECH-GROUP#433 - relying on `drawstyle` over `steps`
- CORE-GATECH-GROUP#417 - passing more kwargs to matplotlib plot routines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants