Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the minimum CMake version to 3.18, as they have in PyTorch? #234

Open
jwallwork23 opened this issue Jan 14, 2025 · 0 comments
Open
Labels
question Further information is requested

Comments

@jwallwork23
Copy link
Contributor

          Do you think it might be worth bumping the minimum CMake version to 3.18, as they have in [PyTorch](https://github.com/pytorch/pytorch/blob/main/torch/CMakeLists.txt)?

I think 3.15 still works in most cases, but CMake 3.18 was the first version to include support for any compiler, enabling CMAKE_CUDA_STANDARD 17 support (it also includes potentially useful things like CMAKE_CUDA_ARCHITECTURES), so it may be safer, although C++17 is already in the FTorch requirements separately.

Originally posted by @ElliottKasoar in #233 (comment)

@jwallwork23 jwallwork23 added the question Further information is requested label Jan 14, 2025
@jwallwork23 jwallwork23 changed the title Bump the minimum CMake version to 3.18, as they have in [PyTorch](https://github.com/pytorch/pytorch/blob/main/torch/CMakeLists.txt)? Bump the minimum CMake version to 3.18, as they have in PyTorch? Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant