You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do you think it might be worth bumping the minimum CMake version to 3.18, as they have in [PyTorch](https://github.com/pytorch/pytorch/blob/main/torch/CMakeLists.txt)?
jwallwork23
changed the title
Bump the minimum CMake version to 3.18, as they have in [PyTorch](https://github.com/pytorch/pytorch/blob/main/torch/CMakeLists.txt)?
Bump the minimum CMake version to 3.18, as they have in PyTorch?
Jan 14, 2025
I think 3.15 still works in most cases, but CMake 3.18 was the first version to include support for any compiler, enabling
CMAKE_CUDA_STANDARD
17 support (it also includes potentially useful things like CMAKE_CUDA_ARCHITECTURES), so it may be safer, although C++17 is already in the FTorch requirements separately.Originally posted by @ElliottKasoar in #233 (comment)
The text was updated successfully, but these errors were encountered: