Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing simpleCell #144

Open
ChasingNeutrons opened this issue Jan 13, 2025 · 0 comments
Open

Removing simpleCell #144

ChasingNeutrons opened this issue Jan 13, 2025 · 0 comments

Comments

@ChasingNeutrons
Copy link
Collaborator

We now have unionCell which is essentially a superset of simpleCell, i.e., it reduces to simpleCell when there are only intersections. It is not necessary to duplicate the code, therefore we should remove simpleCell. As well as deleting the code, the main task is to change old input files which feature cells.

One thing we might want to do is to have unionCell behave like simpleCell in being able to read surfaces as a list, rather than as the new tokenArray object (again provided it contains only intersections). This would make changing all of the old inputs quite straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant