Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement debugging support for the Advanced Transaction Builder #230

Open
rkalis opened this issue Oct 29, 2024 · 2 comments
Open

Implement debugging support for the Advanced Transaction Builder #230

rkalis opened this issue Oct 29, 2024 · 2 comments
Labels
javascript-sdk Relates to the CashScript JavaScript SDK
Milestone

Comments

@rkalis
Copy link
Member

rkalis commented Oct 29, 2024

No description provided.

@rkalis rkalis added this to the v0.11 milestone Oct 29, 2024
@mr-zwets mr-zwets added the javascript-sdk Relates to the CashScript JavaScript SDK label Oct 29, 2024
@mr-zwets
Copy link
Member

In issue #172 we documented a note of the initial difficulties of implementing this:
However we did not add notes from our meeting with Jason, but our assumption about the need to generate multiple scenarios was indeed affirmed.

Note about multiple input handling / advanced transaction builder:

Earlier we mentioned that we're not sure how multiple inputs can be tested at once, since there can only be one 'slot' field in a >scenario. We'll have to discuss this with Jason, but our expectation is that we'd need to generate multiple scenarios, one for each >input, and check that they all pass.

However, we noticed that our scenarios do support P2PKH inputs, which are evaluated separately. So it does seem like it's >possible to evaluate multiple inputs using multiple scripts. We will need to look into this further.

@rkalis
Copy link
Member Author

rkalis commented Jan 14, 2025

Today we started looking at @kiok46's new PR. We extracted his example file into an automated test with documented output. We looked through the output template, which all looks to be correct. We did notice that some tests from the "regular" libauth template fixtures were failing (likely due to naming convention changes), and there were TypeScript issues surrounding the breaking changes.

We also want to further investigate if we can minimise the breaking changes to the TransactionBuilder API and we will need to merge the new TransactionBuilder file with the existing one, and the new LibauthTemplate file with the existing one as well.

Next session we want to expand the test cases a bit by adding more contracts and more configurations of inputs/outputs (e.g. multiple inputs spending with the same function). Then we want to start refactoring / merging the new and existing files as mentioned above.

When we are doing refactors, it will be good to also see if we can address these issues while doing so: #204

We should also update the tests under e2e/transaction-builder to use Mocknet with the new debugging functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript-sdk Relates to the CashScript JavaScript SDK
Projects
None yet
Development

No branches or pull requests

2 participants